qcow2: Don't shadow return value
PATCH 1/1 qcow2: Don't shadow return value
When trying to update the refcounts for a snapshot, the return value of update_refcount on a compressed cluster was pretty much ignored, cancelling the update on error but returning 0. This is caused by an inner "ret" variable shadowing the outer one (the latter is used in the return statement).
Signed-off-by Max Reitz <[email protected]>
--- block/qcow2-refcount.c | 1 - 1 file changed, 1 deletion(-)
block/qcow2-refcount.c +0 -1
@@ -874,7 +874,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs, nb_csectors = ((offset >> s->csize_shift) & s->csize_mask) +1 ;if (addend !=0 ) { -int ret; ret = update_refcount(bs, (offset & s->cluster_offset_mask) & ~511, nb_csectors * 512, addend,
Signature · 1 line
1.8.3.1
Kevin Wolf
AppliedAm 24.09.2013 um 13:50 hat Max Reitz geschrieben:
Quoted 7 lines
When trying to update the refcounts for a snapshot, the return value of
update_refcounton a compressed cluster was pretty much ignored, cancelling the update on error but returning 0. This is caused by an inner "ret" variable shadowing the outer one (the latter is used in the return statement).Signed-off-by Max Reitz <[email protected]>
Thanks, applied to the block branch.
Kevin