Skip to contentSkip to conversation

backlight: lm3630: signedness bug in lm3630a_chip_init()

PATCH In review Dan Carpenter 3 participants 5 messages Sep 25, 2013 – Sep 26, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 backlight: lm3630: signedness bug in lm3630a_chip_init()

"rval" needs to be signed for the error handling to work.

drivers/video/backlight/lm3630a_bl.c +1 -1
index c63f918..65392f9 100644
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);
Acked-by on v1 1/2
#1 lore raw
Quoted 4 lines · Dan Carpenter

"rval" needs to be signed for the error handling to work.

CC'ed Andrew Morton, Daniel Jeong,

Quoted 14 lines
drivers/video/backlight/lm3630a_bl.c +1 -1
index c63f918..65392f9 100644
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);
#2 lore raw

PATCH 1/2 backlight: lm3630: signedness bug in lm3630a_chip_init()

In reply to Dan Carpenter

"rval" needs to be signed for the error handling to work.

drivers/video/backlight/lm3630a_bl.c +1 -1
index c63f918..65392f9 100644
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Dan Carpenter
Quoted 10 lines · Dan Carpenter

"rval" needs to be signed for the error handling to work.

drivers/video/backlight/lm3630a_bl.c +0 -0
index c63f918..65392f9 100644

drivers/video/backlight/lm3630a_bl.c static int lm3630a_chip_init(struct lm3630a_chip *pchip) · line 111

Quoted 8 lines
drivers/video/backlight/lm3630a_bl.c +1 -1
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);

There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel is this for?

Tomi

#4 lore raw
In reply to Dan Carpenter
Quoted 17 lines · Tomi Valkeinen
Quoted 16 lines · Dan Carpenter

"rval" needs to be signed for the error handling to work.

drivers/video/backlight/lm3630a_bl.c +1 -1
index c63f918..65392f9 100644
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
Quoted 6 lines

drivers/video/backlight/lm3630a_bl.c static int lm3630a_chip_init(struct lm3630a_chip *pchip) · line 111

Quoted 2 lines
drivers/video/backlight/lm3630a_bl.c +0 -0
 	pchip = container_of(work, struct lm3630a_chip, work.work);

There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel is this for?

The story is that this driver wasn't submitted to you or to linux-fbdev but only to lkml.

Andrew Morton (the only person who reads LKML) picked it up in his tree. Probably at some point he will prod you into taking it through your tree. Anyway, I resent the patches so they're in -mm now.

regards,
dan carpenter