Skip to contentSkip to conversation

clk: wm831x: get rid of the implementation of remove function

PATCH In review Laxman Dewangan 3 participants 3 messages Sep 26, 2013 – Oct 2, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: wm831x: get rid of the implementation of remove function

The remove function implemented for platform driver's remove callback just return 0 as part of its implementation.

Remove this APIs and do not pass the valid .remove for platform driver.

---
I was referring this driver for clock driver implementation for Palma and realise that this remove function can be removed.
This is just outcome of code reading.

 drivers/clk/clk-wm831x.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/clk/clk-wm831x.c +0 -6
index 805b4c3..b131041 100644
@@ -391,14 +391,8 @@ static int wm831x_clk_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int wm831x_clk_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static struct platform_driver wm831x_clk_driver = {
 	.probe = wm831x_clk_probe,
-	.remove = wm831x_clk_remove,
 	.driver		= {
 		.name	= "wm831x-clk",
 		.owner	= THIS_MODULE,
Signature · 1 line
1.7.1.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Laxman Dewangan

The remove function implemented for platform driver's remove callback just return 0 as part of its implementation.

Remove this APIs and do not pass the valid .remove for platform driver.

Yes, this should have been done when the driver was coverted to devm_clk_register()

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130926/e74e0792/attachment.sig>

#2 lore raw

Quoting Mark Brown (2013-09-26 07:47:43)

Quoted 10 lines · Laxman Dewangan
Quoted 4 lines

The remove function implemented for platform driver's remove callback just return 0 as part of its implementation.

Remove this APIs and do not pass the valid .remove for platform driver.

Yes, this should have been done when the driver was coverted to devm_clk_register()

Taken into clk-next.

Thanks,
Mike