gnupg: option to include RSA support.
PATCH 1/1 gnupg: option to include RSA support.
gnupg is compiled with --enable-minimal flag. This produces a binary that only supports ElGamal and DSA public key algorithms.
RSA has been the default for gpg --gen-key since 2009, so it makes sense to be able to build a gnupg binary that supports it.
--- package/gnupg/Config.in | 5 +++++ package/gnupg/gnupg.mk | 4 ++++ 2 files changed, 9 insertions(+)
package/gnupg/Config.in +5 -0
@@ -15,6 +15,11 @@ config BR2_PACKAGE_GNUPG if BR2_PACKAGE_GNUPG +config BR2_PACKAGE_GNUPG_RSA + bool "RSA support" + help + Support for RSA public key algorithm + config BR2_PACKAGE_GNUPG_GPGV bool "gpgv" help
package/gnupg/gnupg.mk +4 -0
@@ -31,6 +31,10 @@ else GNUPG_CONF_OPT += --without-readline endif +ifeq ($(BR2_PACKAGE_GNUPG_RSA),y) +GNUPG_CONF_OPT += --enable-rsa +endif + ifneq ($(BR2_PACKAGE_GNUPG_GPGV),y) define GNUPG_REMOVE_GPGV rm -f $(TARGET_DIR)/usr/bin/gpgv \
Signature · 1 line
1.7.9.5
PATCH 1/1 gnupg: option to include RSA support.
Dear Peter Sanford,
Thanks! Some comments below.
package/gnupg/Config.in config BR2_PACKAGE_GNUPG · line 21
Quoted 4 lines · Peter Sanford
package/gnupg/Config.in +4
-0+config BR2_PACKAGE_GNUPG_RSA + bool "RSA support" + help + Support for RSA public key algorithm
The indentation here is not good: it should be one tab before "bool" and "help", and one tab+two spaces before the help text. See the Buildroot manual and other examples throughout the Buildroot tree.
package/gnupg/gnupg.mk else · line 36
Quoted 3 lines
package/gnupg/gnupg.mk +3
-0+ifeq ($(BR2_PACKAGE_GNUPG_RSA),y) +GNUPG_CONF_OPT += --enable-rsa +endif
We generally like to have an "else" clause that explicitly disables the option when not enabled, i.e:
elseGNUPG_CONF_OPT += --disable-rsa
endif
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com