powerpc/iommu: use GFP_KERNEL instead of GFP_ATOMIC in iommu_init_table()
PATCH 1/1 powerpc/iommu: use GFP_KERNEL instead of GFP_ATOMIC in iommu_init_table()
Under heavy (DLPAR?) stress, we tripped this panic() in arch/powerpc/kernel/iommu.c::iommu_init_table():
page = alloc_pages_node(nid, GFP_ATOMIC, get_order(sz));
if (!page)
panic("iommu_init_table: Can't allocate %ld bytes\n",
sz);Before the panic() we got a page allocation failure for an order-2 allocation. There appears to be memory free, but perhaps not in the ATOMIC context. I looked through all the call-sites of iommu_init_table() and didn't see any obvious reason to need an ATOMIC allocation. Most call-sites in fact have an explicit GFP_KERNEL allocation shortly before the call to iommu_init_table(), indicating we are not in an atomic context. There is some indirection for some paths, but I didn't see any locks indicating that GFP_KERNEL is inappropriate.
With this change under the same conditions, we have not been able to reproduce the panic.
arch/powerpc/kernel/iommu.c +1 -1
@@ -661,7 +661,7 @@ struct iommu_table *iommu_init_table(struct iommu_table *tbl, int nid)/* number of bytes needed for the bitmap */ sz =BITS_TO_LONGS (tbl->it_size) *sizeof (unsigned long ); - page =alloc_pages_node (nid,GFP_ATOMIC ,get_order (sz)); + page =alloc_pages_node (nid,GFP_KERNEL ,get_order (sz));if (!page)panic ("iommu_init_table: Can't allocate %ld bytes\n" , sz); tbl->it_map =page_address (page);
Quoted 27 lines · Nishanth Aravamudan
Under heavy (DLPAR?) stress, we tripped this
panic()in arch/powerpc/kernel/iommu.c::iommu_init_table():page = alloc_pages_node(nid, GFP_ATOMIC, get_order(sz)); if (!page) panic("iommu_init_table: Can't allocate %ld bytes\n", sz);Before the
panic()we got a page allocation failure for an order-2 allocation. There appears to be memory free, but perhaps not in the ATOMIC context. I looked through all the call-sites ofiommu_init_table()and didn't see any obvious reason to need an ATOMIC allocation. Most call-sites in fact have an explicitGFP_KERNELallocation shortly before the call toiommu_init_table(), indicating we are not in an atomic context. There is some indirection for some paths, but I didn't see any locks indicating thatGFP_KERNELis inappropriate.With this change under the same conditions, we have not been able to reproduce the panic.
Signed-off-by Nishanth Aravamudan <[email protected]>arch/powerpc/kernel/iommu.c +0
-0
arch/powerpc/kernel/iommu.c struct iommu_table *iommu_init_table(struct iommu_table *tbl, int nid) · line 667
Quoted 8 lines
arch/powerpc/kernel/iommu.c +1
-1@@ -661,7 +661,7 @@ struct iommu_table *iommu_init_table(struct iommu_table *tbl, int nid)/* number of bytes needed for the bitmap */ sz =BITS_TO_LONGS (tbl->it_size) *sizeof (unsigned long ); - page =alloc_pages_node (nid,GFP_ATOMIC ,get_order (sz)); + page =alloc_pages_node (nid,GFP_KERNEL ,get_order (sz));if (!page)panic ("iommu_init_table: Can't allocate %ld bytes\n" , sz); tbl->it_map =page_address (page);
I didn't respond to the previous message, but also checked if there were any history on the logs, and found this was as it is from the start. I also found no other reasons why it needs to be atomic. Therefore,