Skip to contentSkip to conversation

usb: chipidea: cosmetic clean up on pci id list

PATCH In review David Cohen 2 participants 5 messages Oct 1, 2013 – Oct 3, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 usb: chipidea: cosmetic clean up on pci id list

In order to fill a struct with zeroes just the first element needs to be set to 0, the rest can me omitted. This looks cleaner when reading the code.

This patch does such clean up change on last item of pci id list.

---
 drivers/usb/chipidea/ci_hdrc_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/chipidea/ci_hdrc_pci.c +1 -1
index 042320a..08a724b 100644
@@ -129,7 +129,7 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
 		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
 	},
-	{ 0, 0, 0, 0, 0, 0, 0 /* end: all zeroes */ }
+	{ 0 } /* end: all zeroes */
 };
 MODULE_DEVICE_TABLE(pci, ci_hdrc_pci_id_table);
 
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH v2 2/2 usb: chipidea: add Intel Clovertrail pci id

---
 drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/usb/chipidea/ci_hdrc_pci.c +5 -0
index 08a724b..d514332 100644
@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
 		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
 	},
+	{
+		/* Intel Clovertrail */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
+		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
+	},
 	{ 0 } /* end: all zeroes */
 };
 MODULE_DEVICE_TABLE(pci, ci_hdrc_pci_id_table);
Signature · 1 line
1.8.4.rc3
maintainer
#2 lore raw

Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

Quoted 10 lines · David Cohen
---
 drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/usb/chipidea/ci_hdrc_pci.c +0 -0
index 08a724b..d514332 100644

drivers/usb/chipidea/ci_hdrc_pci.c static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = { · line 136

Quoted 8 lines
drivers/usb/chipidea/ci_hdrc_pci.c +5 -0
@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
 		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
 	},
+	{
+		/* Intel Clovertrail */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
+		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
+	},

Can this go into 3.12-final, and any other stable kernel releases as well? Or does this platform also need other fixes that aren't in 3.10 and 3.11?

thanks,

greg k-h

#3 lore raw

Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

Hi Greg,

Quoted 15 lines · Greg KH
Quoted 14 lines · David Cohen
---
  drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/usb/chipidea/ci_hdrc_pci.c +1 -0
index 08a724b..d514332 100644
@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
  		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
  		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
  	},
+	{
Quoted 8 lines

drivers/usb/chipidea/ci_hdrc_pci.c static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = { · line 136

Quoted 4 lines
drivers/usb/chipidea/ci_hdrc_pci.c +4 -0
+		/* Intel Clovertrail */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
+		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
+	},

Can this go into 3.12-final, and any other stable kernel releases as well? Or does this platform also need other fixes that aren't in 3.10 and 3.11?

This was tested on 3.10+
It might work on 3.4 but it's not validated. I can test it if we care about chipidea on 3.4.

Br, David

Quoted 5 lines

thanks,

greg k-h

maintainer
#4 lore raw

Re: [PATCH v2 2/2] usb: chipidea: add Intel Clovertrail pci id

Quoted 27 lines · David Cohen

Hi Greg,

Quoted 15 lines · Greg KH
Quoted 14 lines · David Cohen
---
 drivers/usb/chipidea/ci_hdrc_pci.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/usb/chipidea/ci_hdrc_pci.c +1 -0
index 08a724b..d514332 100644
@@ -129,6 +129,11 @@ static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829),
 		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
 	},
+	{
Quoted 8 lines

drivers/usb/chipidea/ci_hdrc_pci.c static DEFINE_PCI_DEVICE_TABLE(ci_hdrc_pci_id_table) = { · line 136

Quoted 4 lines
drivers/usb/chipidea/ci_hdrc_pci.c +4 -0
+		/* Intel Clovertrail */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006),
+		.driver_data = (kernel_ulong_t)&penwell_pci_platdata,
+	},

Can this go into 3.12-final, and any other stable kernel releases as well? Or does this platform also need other fixes that aren't in 3.10 and 3.11?

Quoted 3 lines

This was tested on 3.10+
It might work on 3.4 but it's not validated. I can test it if we care about chipidea on 3.4.

I doubt anyone cares about chipidea on 3.4, 3.10 is good enough. I've mushed these patches together into one to make it easier to backport and apply to Linus's tree for 3.12-final.

thanks,

greg k-h