virt/kvm/iommu.c: Add leading zeros to device's BDF notation in debug messages
PATCH 1/1 virt/kvm/iommu.c: Add leading zeros to device's BDF notation in debug messages
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the printk(KERN_DEBUG ...) with dev_info() and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.
--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
virt/kvm/iommu.c +2 -10
@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:
@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );return 0 ; }
Signature · 1 line
1.8.1.2
Quoted 8 lines · Andre Richter
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the
printk(KERN_DEBUG ...)withdev_info()and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.
Legacy assigned device is deprecated, but this looks nice enough to apply. Alex can you glance at it?
Quoted 38 lines
Signed-off-by Andre Richter <[email protected]>--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)virt/kvm/iommu.c +2
-10@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );return 0 ; }Signature · 1 line
1.8.1.2
--
Gleb.
Quoted 11 lines · Gleb Natapov
Quoted 8 lines · Andre Richter
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the
printk(KERN_DEBUG ...)withdev_info()and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.Legacy assigned device is deprecated, but this looks nice enough to apply. Alex can you glance at it?
Seems ok to me, my only question would be why are we promoting this from KERN_DEBUG to KERN_INFO. We could use dev_dbg() to maintain the same kernel log level. A nice feature of either is that it prints out the attached driver so we can see in dmesg whether the device is attached to a host driver, nothing, or pci-stub. Thanks,
Alex
Quoted 41 lines
Quoted 38 lines
Signed-off-by Andre Richter <[email protected]>--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)virt/kvm/iommu.c +2
-10@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );return 0 ; }Signature · 1 line
1.8.1.2--
Gleb.
2013/10/2 Alex Williamson <[email protected]>:
Quoted 13 lines · Gleb Natapov
Quoted 11 lines · Andre Richter
Quoted 8 lines
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the
printk(KERN_DEBUG ...)withdev_info()and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.Legacy assigned device is deprecated, but this looks nice enough to apply. Alex can you glance at it?
Quoted 7 lines
Seems ok to me, my only question would be why are we promoting this from
KERN_DEBUGtoKERN_INFO. We could usedev_dbg()to maintain the same kernel log level. A nice feature of either is that it prints out the attached driver so we can see in dmesg whether the device is attached to a host driver, nothing, or pci-stub. Thanks,Alex
I made it dev_info() because on my test system, dev_dbg() did not show up in dmesg, whereas
the original printk(KERN_DEBUG ...) did. I guess dev_dbg() was stripped due to compiling without DEBUG?
Therefore, I found dev_info() to better mimic the original behavior. I can change it to dev_dbg() if you wish?
Andre
Quoted 45 lines
Quoted 42 lines
Quoted 38 lines
Signed-off-by Andre Richter <[email protected]>--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)virt/kvm/iommu.c +2
-11@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );return 0 ; } --Quoted 1 line
1.8.1.2
--
Gleb.
Alex Williamson
Acked-byQuoted 20 lines · Andre Richter
2013/10/2 Alex Williamson <[email protected]>:
Quoted 19 lines · Gleb Natapov
Quoted 11 lines · Andre Richter
Quoted 8 lines
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the
printk(KERN_DEBUG ...)withdev_info()and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.Legacy assigned device is deprecated, but this looks nice enough to apply. Alex can you glance at it?
Seems ok to me, my only question would be why are we promoting this from
KERN_DEBUGtoKERN_INFO. We could usedev_dbg()to maintain the same kernel log level. A nice feature of either is that it prints out the attached driver so we can see in dmesg whether the device is attached to a host driver, nothing, or pci-stub. Thanks,
Quoted 8 lines
Quoted 1 line
Alex
I made it
dev_info()because on my test system,dev_dbg()did not show up in dmesg, whereas
the originalprintk(KERN_DEBUG ...)did. I guessdev_dbg()was stripped due to compiling without DEBUG?
Therefore, I founddev_info()to better mimic the original behavior. I can change it todev_dbg()if you wish?
Ah, dev_dbg is dynamic. I guess I don't really mind the change, host drivers print out more.
Quoted 49 lines
Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
Signed-off-by Andre Richter <[email protected]>--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)virt/kvm/iommu.c +2
-10@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
virt/kvm/iommu.c +0
-1return 0 ; } --1.8.1.2
--
Gleb.--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Gleb Natapov
AppliedQuoted 10 lines · Andre Richter
When KVM (de)assigns PCI(e) devices to VMs, a debug message is printed including the BDF notation of the respective device. Currently, the BDF notation does not have the commonly used leading zeros. This produces messages like "assign device 0:1:8.0", which look strange at first sight.
The patch fixes this by exchanging the
printk(KERN_DEBUG ...)withdev_info()and also inserts "kvm" into the debug message, so that it is obvious where the message comes from. Also reduces LoC.Signed-off-by Andre Richter <[email protected]>
Applied, thanks.
Quoted 36 lines
--- virt/kvm/iommu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)virt/kvm/iommu.c +2
-10@@ -190,11 +190,7 @@ int kvm_assign_device(struct kvm *kvm, pdev->dev_flags |=PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "assign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm assign device\n" );return 0 ; out_unmap:@@ -220,11 +216,7 @@ int kvm_deassign_device(struct kvm *kvm, pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED ; -printk (KERN_DEBUG "deassign device %x:%x:%x.%x\n" , - assigned_dev->host_segnr, - assigned_dev->host_busnr, -PCI_SLOT (assigned_dev->host_devfn), -PCI_FUNC (assigned_dev->host_devfn)); +dev_info (&pdev->dev,"kvm deassign device\n" );return 0 ; }Signature · 1 line
1.8.1.2
--
Gleb.