clk: armada-370: fix tclk frequencies
Subsystems (2)
PATCH 1/1 clk: armada-370: fix tclk frequencies
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/mvebu/armada-370.c +2 -2
@@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] __initconst = { };static const u32 a370_tclk_freqs[]__initconst = { -16600000 , -20000000 , +166000000 , +200000000 , };static u32 __init a370_get_tclk_freq (void __iomem *sar)
Signature · 1 line
1.7.10.4
PATCH 1/1 clk: armada-370: fix tclk frequencies
Simon,
Quoted 1 line · Simon Guinot
Signed-off-by Simon Guinot <[email protected]>
Could you elaborate on this? What symptom did you notice? How did this fix it? When was the regression introduced?
thx,
Jason.
Quoted 22 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/clk/mvebu/armada-370.c +2
-2@@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] __initconst = { };static const u32 a370_tclk_freqs[]__initconst = { -16600000 , -20000000 , +166000000 , +200000000 , };static u32 __init a370_get_tclk_freq (void __iomem *sar)Signature · 1 line
1.7.10.4
PATCH 1/1 clk: armada-370: fix tclk frequencies
Quoted 7 lines · Jason Cooper
Simon,
Quoted 1 line · Simon Guinot
Signed-off-by Simon Guinot <[email protected]>Could you elaborate on this? What symptom did you notice? How did this fix it? When was the regression introduced?
Hi Jason,
While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad networking performances... After some investigations, I found out that the coalescence configuration (derived from the tclk) was suspect.
While checking for the tclk value, I found this typo. There is not much to say about this patch except that the correct tclk frequencies for Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.
Simon
Quoted 23 lines
thx,
Jason.
Quoted 18 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/clk/mvebu/armada-370.c +2
-2@@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] __initconst = { };static const u32 a370_tclk_freqs[]__initconst = { -16600000 , -20000000 , +166000000 , +200000000 , };
Quoted 4 lines
Quoted 4 lines
drivers/clk/mvebu/armada-370.c +0
-0static u32 __init a370_get_tclk_freq (void __iomem *sar)Signature · 1 line
1.7.10.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131002/b0c4d977/attachment.sig>
PATCH 1/1 clk: armada-370: fix tclk frequencies
Quoted 11 lines · Simon Guinot
Quoted 7 lines · Jason Cooper
Simon,
Quoted 1 line · Simon Guinot
Signed-off-by Simon Guinot <[email protected]>Could you elaborate on this? What symptom did you notice? How did this fix it? When was the regression introduced?
Hi Jason,
Quoted 7 lines
While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad networking performances... After some investigations, I found out that the coalescence configuration (derived from the tclk) was suspect.
While checking for the tclk value, I found this typo. There is not much to say about this patch except that the correct tclk frequencies for Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.
Yes, I know it's simple, but it's a huge help to us when trying to decide whether or not to flag it for stable. fwiw, the regression was introduced by:
6b72333d clk: mvebu: add Armada 370 SoC-centric clock init
and this should be applied from v3.11 onwards.
thx,
Jason.
PATCH 1/1 clk: armada-370: fix tclk frequencies
Quoted 20 lines · Jason Cooper
Quoted 11 lines · Simon Guinot
Quoted 7 lines · Jason Cooper
Simon,
Quoted 1 line · Simon Guinot
Signed-off-by Simon Guinot <[email protected]>Could you elaborate on this? What symptom did you notice? How did this fix it? When was the regression introduced?
Hi Jason,
Quoted 7 lines
While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad networking performances... After some investigations, I found out that the coalescence configuration (derived from the tclk) was suspect.
While checking for the tclk value, I found this typo. There is not much to say about this patch except that the correct tclk frequencies for Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.
Quoted 7 lines
Yes, I know it's simple, but it's a huge help to us when trying to decide whether or not to flag it for stable. fwiw, the regression was introduced by:
6b72333dclk: mvebu: add Armada 370 SoC-centric clock initand this should be applied from v3.11 onwards.
Ok, I will reword this commit. Note that this bug can't be called a regression. The tclk frequencies array was wrong from the beginning:
97fa4cf4: clk: mvebu: add mvebu core clocks
The commit you pointed out simply moves the typo. I am not familiar with the stable process but if needed I can provide a patch against some stable branches.
Please let know how do you want handle this.
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131003/61a9c13c/attachment.sig>
PATCH 1/1 clk: armada-370: fix tclk frequencies
Quoted 27 lines · Simon Guinot
Quoted 26 lines · Jason Cooper
Quoted 11 lines · Simon Guinot
Quoted 7 lines · Jason Cooper
Simon,
Quoted 1 line · Simon Guinot
Signed-off-by Simon Guinot <[email protected]>Could you elaborate on this? What symptom did you notice? How did this fix it? When was the regression introduced?
Hi Jason,
Quoted 7 lines
While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad networking performances... After some investigations, I found out that the coalescence configuration (derived from the tclk) was suspect.
While checking for the tclk value, I found this typo. There is not much to say about this patch except that the correct tclk frequencies for Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.
Yes, I know it's simple, but it's a huge help to us when trying to decide whether or not to flag it for stable. fwiw, the regression was introduced by:
6b72333dclk: mvebu: add Armada 370 SoC-centric clock init
Quoted 8 lines
Quoted 1 line
and this should be applied from v3.11 onwards.
Ok, I will reword this commit. Note that this bug can't be called a regression. The tclk frequencies array was wrong from the beginning:
97fa4cf4: clk: mvebu: add mvebu core clocksThe commit you pointed out simply moves the typo.
Ahh, good catch! Yes, please reword the commit.
Quoted 2 lines
I am not familiar with the stable process but if needed I can provide a patch against some stable branches.
Usually, there should only need to be one patch against mainline. But since the bad values were moved during the lifetime of the error, there may need to be two patches. Depends on how magical git is. I've seen it do some pretty amazing stuff.
Please find the original commit introducing the error, reference that in the commit, and use 'tag --contains ...' to see which versions need the fix. You can mention that below the cutoff. That's generally all we need to flag it for stable and help the stable guys figure out which trees to apply it to.
hth,
Jason.