USB: OHCI: Properly handle ohci-exynos suspend
A message that is not in the archive (sent off-list or not yet received): CAKsNYyws1m1kT4KiJ6GFcTSo0cT=cu+0nA0vwx=wu_SuRhAfhA@mail.gmail.com
PATCH 6/11 USB: OHCI: Properly handle ohci-exynos suspend
Quoted 31 lines · manju goudar
Quoted 29 lines · Alan Stern
Quoted 7 lines · Bartlomiej Zolnierkiewicz
Hi,
Quoted 3 lines · Alan Stern
Quoted 1 line · Bartlomiej Zolnierkiewicz
Maybe it would make sense to cleanup
ohci_suspend()first (beforeadding
Quoted 18 lines
Quoted 5 lines
Quoted 1 line
new
ohci_suspend()users) and remove unuseddo_wakeupparameter?Not possible. The
do_wakeupparameter is part of a function prototype shared by other callback routines (such asehci_suspend()) that _do_ use the parameter.If you mean
ohci-pci.cusage (which is currently the only usage ofohci_suspend()looking at the latest -next kernel) than it is enough to add a simple wrapper for it inohci-pci.c:...
static intohci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup){ ohci_suspend(hcd); } ... ohci_pci_hc_driver.pci_suspend = ohci_pci_suspend;...
Quoted 8 lines
Quoted 7 lines
Ah, now I see your point. Yes, it's true; that parameter could be eliminated.
Manjunath, would you like to update your patch series to get rid of the
do_wakeupargument toohci_suspend()?Yes I will do. I think we can also rid of
ehci_suspend()do_wakeupargument.
Arrgh! Manjunath, I was wrong. I'm sorry to make you do all this extra work -- your original patch series was correct.
Bartlomiej, we both failed to notice that the 1/11 patch in the original series adds a usage of do_wakeup. Therefore that argument cannot be removed.
Greg, please ignore Manjunath's V2 series (sent today) and merge the original 11-patch series posted on October 2.
Alan Stern
PATCH 6/11 USB: OHCI: Properly handle ohci-exynos suspend
Quoted 40 lines · Alan Stern
Quoted 38 lines · manju goudar
Quoted 36 lines · Alan Stern
Quoted 7 lines · Bartlomiej Zolnierkiewicz
Hi,
Quoted 3 lines · Alan Stern
Quoted 1 line · Bartlomiej Zolnierkiewicz
Maybe it would make sense to cleanup
ohci_suspend()first (beforeadding
Quoted 10 lines
Quoted 5 lines
Quoted 1 line
new
ohci_suspend()users) and remove unuseddo_wakeupparameter?Not possible. The
do_wakeupparameter is part of a function prototype shared by other callback routines (such asehci_suspend()) that _do_ use the parameter.If you mean
ohci-pci.cusage (which is currently the only usage ofohci_suspend()looking at the latest -next kernel) than it is enough to add a simple wrapper for it inohci-pci.c:Quoted 8 lines
...
static intohci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup){ ohci_suspend(hcd); } ... ohci_pci_hc_driver.pci_suspend = ohci_pci_suspend;...
Ah, now I see your point. Yes, it's true; that parameter could be eliminated.
Manjunath, would you like to update your patch series to get rid of the
do_wakeupargument toohci_suspend()?Yes I will do. I think we can also rid of
ehci_suspend()do_wakeup
Quoted 8 lines
Quoted 1 line
argument.
Arrgh! Manjunath, I was wrong. I'm sorry to make you do all this extra work -- your original patch series was correct.
Bartlomiej, we both failed to notice that the 1/11 patch in the original series adds a usage of
do_wakeup. Therefore that argument cannot be removed.
Uhh, indeed. Sorry about that.
Quoted 2 lines
Greg, please ignore Manjunath's V2 series (sent today) and merge the original 11-patch series posted on October 2.
Yep.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
PATCH 6/11 USB: OHCI: Properly handle ohci-exynos suspend
In reply to Alan SternQuoted 45 lines · Alan Stern
Quoted 31 lines · manju goudar
Quoted 29 lines · Alan Stern
Quoted 7 lines · Bartlomiej Zolnierkiewicz
Hi,
Quoted 3 lines · Alan Stern
Quoted 1 line · Bartlomiej Zolnierkiewicz
Maybe it would make sense to cleanup
ohci_suspend()first (beforeadding
Quoted 18 lines
Quoted 5 lines
Quoted 1 line
new
ohci_suspend()users) and remove unuseddo_wakeupparameter?Not possible. The
do_wakeupparameter is part of a function prototype shared by other callback routines (such asehci_suspend()) that _do_ use the parameter.If you mean
ohci-pci.cusage (which is currently the only usage ofohci_suspend()looking at the latest -next kernel) than it is enough to add a simple wrapper for it inohci-pci.c:...
static intohci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup){ ohci_suspend(hcd); } ... ohci_pci_hc_driver.pci_suspend = ohci_pci_suspend;...
Quoted 8 lines
Quoted 7 lines
Ah, now I see your point. Yes, it's true; that parameter could be eliminated.
Manjunath, would you like to update your patch series to get rid of the
do_wakeupargument toohci_suspend()?Yes I will do. I think we can also rid of
ehci_suspend()do_wakeupargument.
Arrgh! Manjunath, I was wrong. I'm sorry to make you do all this extra work -- your original patch series was correct.
Quoted 6 lines
Bartlomiej, we both failed to notice that the 1/11 patch in the original series adds a usage of
do_wakeup. Therefore that argument cannot be removed.Greg, please ignore Manjunath's V2 series (sent today) and merge the original 11-patch series posted on October 2.
I no longer have these. Manjunath, can you please resend the "correct" series that I should apply so that it is obvious which is your latest version?
thanks,
greg k-h