Skip to contentSkip to conversation

bin/bitbake: Catch establish connection log messages

PATCH In review Richard Purdie 2 participants 2 messages Oct 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bin/bitbake: Catch establish connection log messages

If for example you try "bitbake -m" with an invalid BBSERVER, error messages are not dsplayed. This change ensures logging is in place to catch and display such errors.

---

bitbake/bin/bitbake +2 -2
index 222dabd..21a6c81 100755
@@ -297,8 +297,6 @@ def main():
         server = servermodule.BitBakeXMLRPCClient(configParams.observe_only)
         server.saveConnectionDetails(configParams.remote_server)
 
-    logger.removeHandler(handler)
-
     if not configParams.server_only:
         # Collect the feature set for the UI
         featureset = getattr(ui_module, "featureSet", [])
@@ -310,6 +308,8 @@ def main():
         for k in cleanedvars:
             os.environ[k] = cleanedvars[k]
 
+        logger.removeHandler(handler)
+
         try:
             return ui_module.main(server_connection.connection, server_connection.events, configParams)
         finally:
#1 lore raw
Quoted 2 lines · Richard Purdie

If for example you try "bitbake -m" with an invalid BBSERVER, error messages are not dsplayed. This change ensures logging is in place

small typo ^
displayed

Quoted 32 lines

to catch and display such errors.

---

bitbake/bin/bitbake +2 -2
index 222dabd..21a6c81 100755
@@ -297,8 +297,6 @@ def main():
         server = servermodule.BitBakeXMLRPCClient(configParams.observe_only)
         server.saveConnectionDetails(configParams.remote_server)
 
-    logger.removeHandler(handler)
-
     if not configParams.server_only:
         # Collect the feature set for the UI
         featureset = getattr(ui_module, "featureSet", [])
@@ -310,6 +308,8 @@ def main():
         for k in cleanedvars:
             os.environ[k] = cleanedvars[k]
 
+        logger.removeHandler(handler)
+
         try:
             return ui_module.main(server_connection.connection, server_connection.events, configParams)
         finally:

_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]