of: irq: Pass trigger type in IRQ resource flags
PATCH 1/1 of: irq: Pass trigger type in IRQ resource flags
Some drivers might rely on availability of trigger flags in IRQ resource, for example to configure the hardware for particular interrupt type. However current code creating IRQ resources from data in device tree does not configure trigger flags in resulting resources.
This patch tries to solve the problem, based on the fact that irq_of_parse_and_map() configures the trigger based on DT interrupt specifier and IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*, and we can get correct trigger flags by calling irqd_get_trigger_type() after mapping the interrupt.
--- drivers/of/irq.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/of/irq.c +10 -0
@@ -356,6 +356,16 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) r->start = r->end = irq; r->flags =IORESOURCE_IRQ ; r->name = name ? name : dev->full_name; + +/* +* Some drivers might rely on availability of trigger flags +* in IRQ resource. Since irq_of_parse_and_map() configures the +* trigger based on interrupt specifier and IRQD_TRIGGER_* +* flags are consistent with IORESOURCE_IRQ_*, we can get +* trigger type that was just set and pass it through resource +* flags as well. +*/ + r->flags |=irqd_get_trigger_type (irq_get_irq_data (irq)); }return irq;
Signature · 6 lines
1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Grant Likely
AppliedQuoted 5 lines · Tomasz Figa
Some drivers might rely on availability of trigger flags in IRQ resource, for example to configure the hardware for particular interrupt type. However current code creating IRQ resources from data in device tree does not configure trigger flags in resulting resources.
Quoted 7 lines
This patch tries to solve the problem, based on the fact that
irq_of_parse_and_map()configures the trigger based on DT interrupt specifier and IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*, and we can get correct trigger flags by callingirqd_get_trigger_type()after mapping the interrupt.Signed-off-by Tomasz Figa <[email protected]>
Applied, thanks.
g.
Quoted 28 lines
--- drivers/of/irq.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/of/irq.c +10
-0@@ -356,6 +356,16 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) r->start = r->end = irq; r->flags =IORESOURCE_IRQ ; r->name = name ? name : dev->full_name; + +/* +* Some drivers might rely on availability of trigger flags +* in IRQ resource. Since irq_of_parse_and_map() configures the +* trigger based on interrupt specifier and IRQD_TRIGGER_* +* flags are consistent with IORESOURCE_IRQ_*, we can get +* trigger type that was just set and pass it through resource +* flags as well. +*/ + r->flags |=irqd_get_trigger_type (irq_get_irq_data (irq)); }return irq;Signature · 1 line
1.8.3.2