Skip to contentSkip to conversation

Lots of SPDX-License Identifer have a trailing space

U-Boot Masahiro Yamada 2 participants 3 messages Oct 4, 2013

lore
Share & tools
lore
#0 lore raw

Hello Wolfgang,

I noticed many of SPDX-License blocks
have a trailing space after "GPL-2.0+".

For example, arch/arm/cpu/arm1136/start.S

*
* SPDX-License-Identifier: GPL-2.0+[A Trailing Space]
*/

Is this space the one intentinally added?
(If not, I can send a patch to fix it.)

I am not sure whether I should precisely copy and paste SPDX indentifier or drop a trailing space
when I add a new source file.

Best Regards
Masahiro Yamada

#1 lore raw

Dear Masahiro,

Quoted 3 lines · In message <[email protected]> you wrote:

I noticed many of SPDX-License blocks
have a trailing space after "GPL-2.0+".

Oops...

Quoted 2 lines

Is this space the one intentinally added?
(If not, I can send a patch to fix it.)

No, this is definitely not intentional.

Quoted 3 lines

I am not sure whether I should precisely copy and paste SPDX indentifier or drop a trailing space
when I add a new source file.

Trailing white space should not be present anywhere in the source files.

Thanks for noticing & reporting this issue!

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"To IBM, 'open' means there is a modicum  of  interoperability  among
some of their equipment."                            - Harv Masterson
#2 lore raw

Hello Wolfgang

Quoted 4 lines
Quoted 2 lines

Is this space the one intentinally added?
(If not, I can send a patch to fix it.)

No, this is definitely not intentional.

OK.
SPDX might be your turf, so I will hold back sending a patch.

Best Regards
Masahiro Yamada