block: use correct filename
PATCH 1/1 block: use correct filename
The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open()
So it's better to use bs->filename.
Signed-off-by Dunrong Huang <[email protected]>
--- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
block.c +2 -2
@@ -824,8 +824,8 @@ static int bdrv_open_common(BlockDriverState *bs, BlockDriverState *file,#ifndef _WIN32if (bs->is_temporary) { -assert (filename !=NULL ); -unlink (filename); +assert (bs->filename[0 ] !='\0' ); +unlink (bs->filename); }#endif return 0 ;
Signature · 1 line
1.7.12.4 (Apple Git-37)
Quoted 9 lines · Dunrong Huang
The content filename point to may be erased by
qemu_opts_absorb_qdict()inraw_open_common()indrv->bdrv_file_open()So it's better to use
bs->filename.Signed-off-by Dunrong Huang <[email protected]>--- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Max Reitz <[email protected]>
Stefan Hajnoczi
AppliedQuoted 9 lines · Dunrong Huang
The content filename point to may be erased by
qemu_opts_absorb_qdict()inraw_open_common()indrv->bdrv_file_open()So it's better to use
bs->filename.Signed-off-by Dunrong Huang <[email protected]>--- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan