Skip to contentSkip to conversation

Trivial patches ready for merging

PATCH New Otavio Salvador 2 participants 7 messages Oct 3, 2013 – Oct 7, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

v3 cover Trivial patches ready for merging

Hello,

I am resending the patches I think are ready to be applied and are trivial.

Please also add:

http://patchwork.ozlabs.org/patch/279105/

as it fixes a watchdog to work.

Changes in v3:
- Fix code comment (dropped 'either')

Changes in v2:
- rework commit log (Eric Benard)
- rework commitlog (Fabio)

Otavio Salvador (3):
mtd: Fix function description in part_validate comment include/linux/fb.h: Add a missing include for 'list.h'
doc: Fix a typo in the description in doc/README.JFFS2_NAND

 common/cmd_mtdparts.c | 7 +++----
 doc/README.JFFS2_NAND | 2 +-
 include/linux/fb.h    | 1 +
 3 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH v3 1/3 mtd: Fix function description in part_validate comment

The part_validate comment had a wrong description of the actions it does and referenced to non-existent functions while in fact it calls 'part_validate_eraseblock()'.

---
Changes in v3:
- Fix code comment (dropped 'either')

Changes in v2:
- rework commit log (Eric Benard)

 common/cmd_mtdparts.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
common/cmd_mtdparts.c +3 -4
index 38a6e6d..f791372 100644
@@ -381,10 +381,9 @@ static int part_validate_eraseblock(struct mtdids *id, struct part_info *part)
 
 
 /**
- * Performs sanity check for supplied partition. Offset and size are verified
- * to be within valid range. Partition type is checked and either
- * parts_validate_nor() or parts_validate_nand() is called with the argument
- * of part.
+ * Performs sanity check for supplied partition. Offset and size are
+ * verified to be within valid range. Partition type is checked and
+ * part_validate_eraseblock() is called with the argument of part.
  *
  * @param id of the parent device
  * @param part partition to validate
Signature · 1 line
1.8.4.rc3
#2 lore raw

PATCH v3 1/3 mtd: Fix function description in part_validate comment

Quoted 5 lines · Otavio Salvador

The part_validate comment had a wrong description of the actions it does and referenced to non-existent functions while in fact it calls 'part_validate_eraseblock()'.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131007/5585c3dc/attachment.pgp>
#3 lore raw

PATCH v3 2/3 include/linux/fb.h: Add a missing include for 'list.h'

In reply to Otavio Salvador

The modelist data uses the list definition but the 'list.h' header were not being included. The build failure is bellow:

,----

| In file included from yyyy.c:16:0:
| .../u-boot/include/linux/fb.h:503:19: error: field 'modelist' has incomplete type
|   struct list_head modelist; /* mode list */
|                    ^
| make[1]: *** [yyyy.o] Error 1
| make[1]: Leaving directory `.../u-boot/board/xxx/yyyy'
| make: *** [board/xxx/yyyy/libyyyy.o] Error 2

`----

---
Changes in v3: None
Changes in v2:
- rework commitlog (Fabio)

 include/linux/fb.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/fb.h +1 -0
index 3858f8f..111372c 100644
@@ -2,6 +2,7 @@
 #define _LINUX_FB_H
 
 #include <linux/types.h>
+#include <linux/list.h>
 
 /* Definitions of frame buffers						*/
 
Signature · 1 line
1.8.4.rc3
#4 lore raw

PATCH v3 2/3 include/linux/fb.h: Add a missing include for 'list.h'

Quoted 11 lines · Otavio Salvador

The modelist data uses the list definition but the 'list.h' header were not being included. The build failure is bellow:

,----

| In file included from yyyy.c:16:0:
| .../u-boot/include/linux/fb.h:503:19: error: field 'modelist' has incomplete type
|   struct list_head modelist; /* mode list */
|                    ^
| make[1]: *** [yyyy.o] Error 1
| make[1]: Leaving directory `.../u-boot/board/xxx/yyyy'
| make: *** [board/xxx/yyyy/libyyyy.o] Error 2
Quoted 3 lines

`----

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131007/d79af6bb/attachment.pgp>
#5 lore raw

PATCH v3 3/3 doc: Fix a typo in the description in doc/README.JFFS2_NAND

In reply to Otavio Salvador

---
Changes in v3: None
Changes in v2: None

 doc/README.JFFS2_NAND | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/README.JFFS2_NAND +1 -1
index 5018ae8..09788d5 100644
@@ -1,6 +1,6 @@
 JFFS2 NAND support:
 
-To ebable, use the following #define in the board configuration file:
+To enable, use the following #define in the board configuration file:
 
 #define CONFIG_JFFS2_NAND 1
 
Signature · 1 line
1.8.4.rc3
#6 lore raw

PATCH v3 3/3 doc: Fix a typo in the description in doc/README.JFFS2_NAND

Quoted 14 lines · Otavio Salvador

---
Changes in v3: None
Changes in v2: None

 doc/README.JFFS2_NAND | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/README.JFFS2_NAND +0 -0
index 5018ae8..09788d5 100644

doc/README.JFFS2_NAND line 5

Quoted 6 lines
doc/README.JFFS2_NAND +1 -1
@@ -1,6 +1,6 @@
 JFFS2 NAND support:
 
-To ebable, use the following #define in the board configuration file:
+To enable, use the following #define in the board configuration file:
 
 #define CONFIG_JFFS2_NAND 1

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131007/81d9caea/attachment.pgp>