Skip to contentSkip to conversation

rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice

PATCH Superseded Kevin Lo 2 participants 2 messages Oct 7, 2013 – Oct 8, 2013 Networking drivers (wireless)

lore
Share & tools
lore

Kevin Lo

author
#0 lore raw

PATCH v2 1/1 rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice

In rt2800_config_channel_rf3xxx(), there's no need to toggle RF R30 bit 7 twice.

Signed-off-by Kevin Lo <[email protected]>

---
Changes since v1:
- the previous patch was malformed
---

drivers/net/wireless/rt2x00/rt2800lib.c +0 -7
index 25aaa5e..65b4416 100644
@@ -2029,13 +2029,6 @@ static void rt2800_config_channel_rf3xxx(struct rt2x00_dev *rt2x00dev,
                          rt2x00dev->default_ant.tx_chain_num <= 2);
        rt2800_rfcsr_write(rt2x00dev, 1, rfcsr);
 
-       rt2800_rfcsr_read(rt2x00dev, 30, &rfcsr);
-       rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 1);
-       rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
-       msleep(1);
-       rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 0);
-       rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
-
        rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
        rt2x00_set_field8(&rfcsr, RFCSR23_FREQ_OFFSET, 

rt2x00dev->freq_offset);
        rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
NAK
#1 lore raw
Quoted 4 lines · Kevin Lo
        rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
        rt2x00_set_field8(&rfcsr, RFCSR23_FREQ_OFFSET,
rt2x00dev->freq_offset);
        rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);

NACK, still malformed