Skip to contentSkip to conversation

xlib_libpthread-stubs: needs thread support

PATCH New Jerzy Grzegorek 2 participants 3 messages Oct 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xlib_libpthread-stubs: needs thread support

Fixes:
http://autobuild.buildroot.org/results/609/6099baac4bb469ae18aab6512233db25183eaabd/

---
 package/x11r7/xlib_libpthread-stubs/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
package/x11r7/xlib_libpthread-stubs/Config.in +4 -0
index fb53585..b2df95a 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS
 	bool "libpthread-stubs"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  This library provides weak aliases for pthread functions not
 	  provided in libc or otherwise available by default.
 
 	  http://xcb.freedesktop.org/
+
+comment "xlib_libpthread-stubs needs a toolchain with thread support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 xlib_libpthread-stubs: needs thread support

Dear Jerzy Grzegorek,

package/x11r7/xlib_libpthread-stubs/Config.in line 3

Quoted 3 lines · Jerzy Grzegorek

config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS

package/x11r7/xlib_libpthread-stubs/Config.in +1 -0
 	bool "libpthread-stubs"
+	depends on BR2_TOOLCHAIN_HAS_THREADS

No, that doesn't work. When you add a toolchain dependency to one package, you must propagate it to the reverse dependencies of this package that are selecting this package.

For example, libdrm and libxcb are both selecting XLIB_LIBPTHREAD_STUBS, but they do not have the BR2_TOOLCHAIN_HAS_THREADS, so you should add this dependency to libdrm and libxcb as well.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 xlib_libpthread-stubs: needs thread support

Hi Thomas,

Quoted 11 lines

Dear Jerzy Grzegorek,

package/x11r7/xlib_libpthread-stubs/Config.in line 3

Quoted 3 lines · Jerzy Grzegorek

config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS
bool "libpthread-stubs"

package/x11r7/xlib_libpthread-stubs/Config.in +1 -0
+	depends on BR2_TOOLCHAIN_HAS_THREADS

No, that doesn't work. When you add a toolchain dependency to one package, you must propagate it to the reverse dependencies of this package that are selecting this package.

Quoted 4 lines

For example, libdrm and libxcb are both selecting XLIB_LIBPTHREAD_STUBS, but they do not have the BR2_TOOLCHAIN_HAS_THREADS, so you should add this dependency to libdrm and libxcb as well.

Thanks for clarification.

Regards,
Jerzy

Quoted 3 lines

Best regards,

Thomas