Skip to contentSkip to conversation

xfstests: mkfs scratch device in generic/294

PATCH In review Eric Sandeen 3 participants 3 messages Oct 6, 2013 – Oct 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: mkfs scratch device in generic/294

test 294 is using the scratch device w/o mkfs-ing it first, this runs the risk of following a test which completely fills the fs, causing 294 to fail.

add "rm -f $seqres.full" as well, it was growing on every run.

---

tests/generic/294 +3 -0
index fa7f339..3fa6ba2 100755
@@ -48,6 +48,9 @@ _supported_fs generic
 _supported_os Linux
 _require_scratch
 
+rm -f $seqres.full
+_scratch_mkfs > $seqres.full 2>&1 || _fail "Could not mkfs scratch device"
+
 THIS_TEST_DIR=$SCRATCH_MNT/$seq.test
 
 _create_files()

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Eric Sandeen

test 294 is using the scratch device w/o mkfs-ing it first, this runs the risk of following a test which completely fills the fs, causing 294 to fail.

add "rm -f $seqres.full" as well, it was growing on every run.

*nod*

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs