Skip to contentSkip to conversation

protobuf: needs thread support

PATCH New Axel Lin 3 participants 4 messages Oct 10, 2013

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 protobuf: needs thread support

Fix:
http://autobuild.buildroot.net/results/086/08661b6bd6796c9126bcbad3245323160b182ac8/

---
 package/protobuf/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/protobuf/Config.in +3 -2
index b044ef0..92e85ba 100644
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.
 
 	  http://code.google.com/p/protobuf/
 
-comment "protobuf requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "protobuf requires a toolchain with C++ and thread support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 2/2 protobuf-c: needs thread support

---
 package/protobuf-c/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/protobuf-c/Config.in +3 -2
index 9aff6e2..17cc8f1 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PROTOBUF_C
 	bool "protobuf-c"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
 	select BR2_PACKAGE_PROTOBUF
 	help
 	  Code generator and runtime libraries to use Protocol Buffers
@@ -8,5 +9,5 @@ config BR2_PACKAGE_PROTOBUF_C
 
 	  http://code.google.com/p/protobuf-c/
 
-comment "protobuf-c requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "protobuf-c requires a toolchain with C++ and thread support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 2/2 protobuf-c: needs thread support

Hi Axel,

Quoted 10 lines · Axel Lin
---
 package/protobuf-c/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/protobuf-c/Config.in +0 -0
index 9aff6e2..17cc8f1 100644

package/protobuf-c/Config.in line 4

Quoted 4 lines
package/protobuf-c/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PROTOBUF_C
 	bool "protobuf-c"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf

This should be squashed into the previous patch. Although strictly speaking bisectability is not broken by the previous patch (build without threads is broken already), it is nicer IMO.

baruch

Quoted 11 lines
package/protobuf-c/Config.in +2 -2
 	select BR2_PACKAGE_PROTOBUF
 	help
 	  Code generator and runtime libraries to use Protocol Buffers
@@ -8,5 +9,5 @@ config BR2_PACKAGE_PROTOBUF_C
 
 	  http://code.google.com/p/protobuf-c/
 
-comment "protobuf-c requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "protobuf-c requires a toolchain with C++ and thread support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -