Skip to contentSkip to conversation

xdriver_xf86-input-evdev: enable compile without udev dependency.

PATCH New Peter Seiderer 3 participants 4 messages Oct 10, 2013 – Oct 14, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xdriver_xf86-input-evdev: enable compile without udev dependency.

---
 package/x11r7/xdriver_xf86-input-evdev/Config.in   |  4 --
 ...01-Enable-compile-wihtout-udev-dependency.patch | 58 ++++++++++++++++++++++
 .../xdriver_xf86-input-evdev.mk                    | 10 +++-
 3 files changed, 67 insertions(+), 5 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-evdev/xdriver_xf86-input-evdev-0001-Enable-compile-wihtout-udev-dependency.patch
package/x11r7/xdriver_xf86-input-evdev/Config.in +0 -4
index cc159c9..798fffc 100644
@@ -1,11 +1,7 @@
 config BR2_PACKAGE_XDRIVER_XF86_INPUT_EVDEV
 	bool "xf86-input-evdev"
-	depends on BR2_PACKAGE_UDEV # libudev is configure dependency
 	select BR2_PACKAGE_XPROTO_INPUTPROTO
 	select BR2_PACKAGE_XPROTO_RANDRPROTO
 	select BR2_PACKAGE_XPROTO_XPROTO
 	help
 	  Generic Linux input driver
-
-comment "xf86-input-evdev requires udev to be enabled"
-        depends on !BR2_PACKAGE_UDEV
package/x11r7/xdriver_xf86-input-evdev/xdriver_xf86-input-evdev-0001-Enable-compile-wihtout-udev-dependency.patch new file +58 -0

58 lines not on this page · raw message

package/x11r7/xdriver_xf86-input-evdev/xdriver_xf86-input-evdev.mk +9 -1
index 61f0ce7..e2092bf 100644
@@ -9,6 +9,14 @@ XDRIVER_XF86_INPUT_EVDEV_SOURCE = xf86-input-evdev-$(XDRIVER_XF86_INPUT_EVDEV_VE
 XDRIVER_XF86_INPUT_EVDEV_SITE = http://xorg.freedesktop.org/releases/individual/driver
 XDRIVER_XF86_INPUT_EVDEV_LICENSE = MIT
 XDRIVER_XF86_INPUT_EVDEV_LICENSE_FILES = COPYING
-XDRIVER_XF86_INPUT_EVDEV_DEPENDENCIES = xproto_inputproto xserver_xorg-server xproto_randrproto xproto_xproto udev
+XDRIVER_XF86_INPUT_EVDEV_DEPENDENCIES = xproto_inputproto xserver_xorg-server xproto_randrproto xproto_xproto
+
+# autoreconf required because of patched configure.ac, see
+# xdriver_xf86-input-evdev-0001-Enable-compile-wihtout-udev-dependency.patch
+XDRIVER_XF86_INPUT_EVDEV_AUTORECONF = YES
+
+ifeq ($(BR2_PACKAGE_UDEV),y)
+XDRIVER_XF86_INPUT_EVDEV_DEPENDENCIES += udev
+endif
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 xdriver_xf86-input-evdev: enable compile without udev dependency.

Dear Peter Seiderer,

Quoted 7 lines · Peter Seiderer
---
 package/x11r7/xdriver_xf86-input-evdev/Config.in   |  4 --
 ...01-Enable-compile-wihtout-udev-dependency.patch | 58 ++++++++++++++++++++++
 .../xdriver_xf86-input-evdev.mk                    | 10 +++-
 3 files changed, 67 insertions(+), 5 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-evdev/xdriver_xf86-input-evdev-0001-Enable-compile-wihtout-udev-dependency.patch

Thanks. Have you submitted this patch upstream? This is more-and-less a feature patch, and in Buildroot, we don't like too much carrying feature patches if we don't believe they will be merged upstream.

Of course, if it has been submitted upstream and received what seems like a positive feedback, it's perfectly fine to take it in Buildroot until upstream makes a new release.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 xdriver_xf86-input-evdev: enable compile without udev dependency.

Hello Thomas,

Quoted 11 lines · Thomas Petazzoni

Dear Peter Seiderer,

Quoted 7 lines · Peter Seiderer
---
 package/x11r7/xdriver_xf86-input-evdev/Config.in   |  4 --
 ...01-Enable-compile-wihtout-udev-dependency.patch | 58 ++++++++++++++++++++++
 .../xdriver_xf86-input-evdev.mk                    | 10 +++-
 3 files changed, 67 insertions(+), 5 deletions(-)
 create mode 100644 package/x11r7/xdriver_xf86-input-evdev/xdriver_xf86-input-evdev-0001-Enable-compile-wihtout-udev-dependency.patch
Quoted 4 lines

Thanks. Have you submitted this patch upstream? This is more-and-less a feature patch, and in Buildroot, we don't like too much carrying feature patches if we don't believe they will be merged upstream.

Yes, patch already proposed upstream, see https://bugs.freedesktop.org/show_bug.cgi?id=70356

Quoted 3 lines

Of course, if it has been submitted upstream and received what seems like a positive feedback, it's perfectly fine to take it in Buildroot until upstream makes a new release.

Let's wait awhile for upstream comments...

Thanks,

Peter

Quoted 8 lines

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 xdriver_xf86-input-evdev: enable compile without udev dependency.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 4 lines

Thanks. Have you submitted this patch upstream? This is more-and-less a feature patch, and in Buildroot, we don't like too much carrying feature patches if we don't believe they will be merged upstream.

Peter> Yes, patch already proposed upstream, see https://bugs.freedesktop.org/show_bug.cgi?id=70356

Quoted 3 lines
Quoted 3 lines

Of course, if it has been submitted upstream and received what seems like a positive feedback, it's perfectly fine to take it in Buildroot until upstream makes a new release.

Peter> Let's wait awhile for upstream comments...

In the mean time Peter (there's too many Peters in this discussion) Hutterer has closed it as WONTFIX, so I'm afraid I'll have to disappoint and say no..

Signature · 1 line
Bye, Peter Korsgaard