farsync: fix info leak in ioctl
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 farsync: fix info leak in ioctl
From: Salva Peiró <[email protected]>
The fst_get_iface() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak.
Signed-off-by Dan Carpenter <[email protected]>
--- linux-3.4-xm/drivers/net/wan/farsync.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wan/farsync.c +1 -0
@@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port, } i = port->index; +memset (&sync,0 ,sizeof (sync)); sync.clock_rate =FST_RDL (card, portConfig[i].lineSpeed);/* Lucky card and linux use same encoding here */ sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==
Signature · 1 line
1.7.10.4
David Miller
maintainerFrom: Dan Carpenter <[email protected]>
Date: Fri, 11 Oct 2013 12:50:03 +0300
Quoted 7 lines
From: Salva Peiró <[email protected]>
The
fst_get_iface()code fails to initialize the two padding bytes of structsync_serial_settingsafter the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak.Signed-off-by Dan Carpenter <[email protected]>
Applied and queued up for -stable.