ARM: mvebu: dts: remove unneeded linux, default-state from led nodes
PATCH 1/1 ARM: mvebu: dts: remove unneeded linux, default-state from led nodes
Generally, power LEDs should indicate when power is applied, and go out once power is removed. _Not_ annoy the developer with migraine-inducing blinking reminicent of some badly animated television series designed to sell sugar to children.
On a more serious note, most of these OS-specific properties aren't necessary and should be removed. I left two that are legitimately tying disk LEDs to disk activity. Other than that, we keep the state the bootloader left them in until userspace changes the state via sysfs.
--- arch/arm/boot/dts/armada-370-mirabox.dts | 4 ++-- arch/arm/boot/dts/armada-370-netgear-rn102.dts | 2 +- arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 3 +-- arch/arm/boot/dts/dove-cubox.dts | 2 +- arch/arm/boot/dts/kirkwood-dns320.dts | 2 +- arch/arm/boot/dts/kirkwood-dns325.dts | 2 +- arch/arm/boot/dts/kirkwood-dockstar.dts | 2 +- arch/arm/boot/dts/kirkwood-goflexnet.dts | 2 +- arch/arm/boot/dts/kirkwood-ib62x0.dts | 2 +- arch/arm/boot/dts/kirkwood-iconnect.dts | 4 ++-- arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts | 2 +- arch/arm/boot/dts/kirkwood-lsxl.dtsi | 2 +- arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts | 2 +- arch/arm/boot/dts/kirkwood-ns2lite.dts | 2 +- arch/arm/boot/dts/kirkwood-sheevaplug-esata.dts | 2 +- arch/arm/boot/dts/kirkwood-sheevaplug.dts | 2 +- 16 files changed, 18 insertions(+), 19 deletions(-)
arch/arm/boot/dts/armada-370-mirabox.dts +2 -2
@@ -74,13 +74,13 @@ green_pwr_led { label = "mirabox:green:pwr"; gpios = <&gpio1 31 1>; - linux,default-trigger = "heartbeat"; + default-state = "keep"; }; blue_stat_led { label = "mirabox:blue:stat"; gpios = <&gpio2 0 1>; - linux,default-trigger = "cpu0"; + default-state = "off"; }; green_stat_led {
arch/arm/boot/dts/armada-370-netgear-rn102.dts +1 -1
@@ -130,7 +130,7 @@ blue_power_led { label = "rn102:blue:pwr"; gpios = <&gpio1 25 1>; /* GPIO 57 Active Low */ - linux,default-trigger = "heartbeat"; + default-state = "keep"; }; green_sata1_led {
arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts +1 -2
@@ -103,8 +103,7 @@ green_led { label = "green_led"; gpios = <&gpio1 21 1>; - default-state = "off"; - linux,default-trigger = "heartbeat"; + default-state = "keep"; }; };
arch/arm/boot/dts/dove-cubox.dts +1 -1
@@ -23,7 +23,7 @@ power { label = "Power"; gpios = <&gpio0 18 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; };
arch/arm/boot/dts/kirkwood-dns320.dts +1 -1
@@ -25,7 +25,7 @@ blue-power { label = "dns320:blue:power"; gpios = <&gpio0 26 1>; /* GPIO 26 Active Low */ - linux,default-trigger = "default-on"; + default-state = "keep"; }; blue-usb { label = "dns320:blue:usb";
arch/arm/boot/dts/kirkwood-dns325.dts +1 -1
@@ -25,7 +25,7 @@ white-power { label = "dns325:white:power"; gpios = <&gpio0 26 1>; /* GPIO 26 Active Low */ - linux,default-trigger = "default-on"; + default-state = "keep"; }; white-usb { label = "dns325:white:usb";
arch/arm/boot/dts/kirkwood-dockstar.dts +1 -1
@@ -43,7 +43,7 @@ health { label = "status:green:health"; gpios = <&gpio1 14 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; fault { label = "status:orange:fault";
arch/arm/boot/dts/kirkwood-goflexnet.dts +1 -1
@@ -86,7 +86,7 @@ health { label = "status:green:health"; gpios = <&gpio1 14 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; fault { label = "status:orange:fault";
arch/arm/boot/dts/kirkwood-ib62x0.dts +1 -1
@@ -82,7 +82,7 @@ green-os { label = "ib62x0:green:os"; gpios = <&gpio0 25 0>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; red-os { label = "ib62x0:red:os";
arch/arm/boot/dts/kirkwood-iconnect.dts +2 -2
@@ -95,12 +95,12 @@ led-level { label = "led_level"; gpios = <&gpio1 9 0>; - linux,default-trigger = "default-on"; + default-state = "on"; }; power-blue { label = "power:blue"; gpios = <&gpio1 10 0>; - linux,default-trigger = "timer"; + default-state = "keep"; }; power-red { label = "power:red";
arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts +1 -1
@@ -128,7 +128,7 @@ power_led { label = "status:white:power_led"; gpios = <&gpio0 16 0>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; rebuild_led { label = "status:white:rebuild_led";
arch/arm/boot/dts/kirkwood-lsxl.dtsi +1 -1
@@ -150,7 +150,7 @@ led at 4 { label = "lsxl:blue:power"; gpios = <&gpio1 7 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; led at 5 {
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +1 -1
@@ -113,7 +113,7 @@ power_led { label = "status:blue:power_led"; gpios = <&gpio0 31 1>; /* GPIO 31 Active Low */ - linux,default-trigger = "default-on"; + default-state = "keep"; }; activity_led { label = "status:blue:activity_led";
arch/arm/boot/dts/kirkwood-ns2lite.dts +1 -1
@@ -26,7 +26,7 @@ blue-sata { label = "ns2:blue:sata"; gpios = <&gpio0 30 1>; - linux,default-trigger = "default-on"; + linux,default-trigger = "ide-disk"; }; }; };
arch/arm/boot/dts/kirkwood-sheevaplug-esata.dts +1 -1
@@ -37,7 +37,7 @@ health { label = "sheevaplug:blue:health"; gpios = <&gpio1 17 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; }; };
arch/arm/boot/dts/kirkwood-sheevaplug.dts +1 -1
@@ -32,7 +32,7 @@ health { label = "sheevaplug:blue:health"; gpios = <&gpio1 17 1>; - linux,default-trigger = "default-on"; + default-state = "keep"; }; misc {
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM: mvebu: dts: remove unneeded linux,default-state from led nodes
Quoted 9 lines · Jason Cooper
Generally, power LEDs should indicate when power is applied, and go out once power is removed. _Not_ annoy the developer with migraine-inducing blinking reminicent of some badly animated television series designed to sell sugar to children.
On a more serious note, most of these OS-specific properties aren't necessary and should be removed. I left two that are legitimately tying disk LEDs to disk activity. Other than that, we keep the state the bootloader left them in until userspace changes the state via sysfs.
Hi Jason
Do you know what happens with "keep" and the bootloader setting the LED to hardware blink? I'm just wondering if some of these default-on, are actually disabling hardware blinking and making it constant on?
Thanks
Andrew
PATCH 1/1 ARM: mvebu: dts: remove unneeded linux,default-state from led nodes
Quoted 11 lines · Andrew Lunn
Quoted 9 lines · Jason Cooper
Generally, power LEDs should indicate when power is applied, and go out once power is removed. _Not_ annoy the developer with migraine-inducing blinking reminicent of some badly animated television series designed to sell sugar to children.
On a more serious note, most of these OS-specific properties aren't necessary and should be removed. I left two that are legitimately tying disk LEDs to disk activity. Other than that, we keep the state the bootloader left them in until userspace changes the state via sysfs.
Quoted 5 lines
Hi Jason
Do you know what happens with "keep" and the bootloader setting the LED to hardware blink? I'm just wondering if some of these default-on, are actually disabling hardware blinking and making it constant on?
hmmm, good question. I'll let this patch sit for some time since it is trivial and doesn't conflict with anything in mvebu/dt. We'll see if anyone says anything.
Regardless of the outcome, 'default-state = "on";' can be used instead for that scenario.
thx,
Jason.
PATCH 1/1 ARM: mvebu: dts: remove unneeded linux,default-state from led nodes
Hi Jason, Andrew
Quoted 12 lines · Jason Cooper
Quoted 11 lines · Andrew Lunn
Quoted 9 lines · Jason Cooper
Generally, power LEDs should indicate when power is applied, and go out once power is removed. _Not_ annoy the developer with migraine-inducing blinking reminicent of some badly animated television series designed to sell sugar to children.
On a more serious note, most of these OS-specific properties aren't necessary and should be removed. I left two that are legitimately tying disk LEDs to disk activity. Other than that, we keep the state the bootloader left them in until userspace changes the state via sysfs.
Quoted 5 lines
Quoted 5 lines
Hi Jason
Do you know what happens with "keep" and the bootloader setting the LED to hardware blink? I'm just wondering if some of these default-on, are actually disabling hardware blinking and making it constant on?
This is the reason why I used the default-on in kirkwood-ib62x0.dts at the time. The original bootloader did enable hardware blinking. (Can't check whether "keep" would at least disable the blinking, since I don't have the original bootloader on the box anymore)
For obvious reasons, the uboot support for the IB NAS 62x0 does not copy this behavior from the original uboot. So, it is not an issue anymore once you upgrade the bootloader.
Quoted 3 lines
hmmm, good question. I'll let this patch sit for some time since it is trivial and doesn't conflict with anything in mvebu/dt. We'll see if anyone says anything.
We can see it as a nice incentive to upgrade the boot loader...
Quoted 2 lines
Regardless of the outcome, 'default-state = "on";' can be used instead for that scenario.
Sure.
- Simon