Skip to contentSkip to conversation

Issue building a file based rootfs image with mkfs.btrfs

DISCUSSION Saul Wold 5 participants 11 messages Sep 19, 2013 – Oct 14, 2013 Btrfs file system

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Thanks

Signature · 5 lines
    Sau!

Saul Wold
Yocto Component Wrangler @ Intel
Yocto Project / Poky Build System
author
#1 lore raw
Quoted 15 lines · Saul Wold

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

Quoted 9 lines

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Anybody have any ideas on this? I can reproduce this at will on Fedora 19 (with btrfs-progs-0.20), Ubuntu 12.10 (with btrfs-profs-0.19) and with HEAD from Chris's repo above (is this the right place these days)?

Thanks your your help.

Sau!

Quoted 2 lines

Thanks

#2 lore raw
In reply to Saul Wold

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Thanks!

-chris

author
#3 lore raw
Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Ah great news! I want to verify is your git repo for btrfs-progs the main upstream? I see loads of other patches flying around, but not applied there.

Thanks again

Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 4 lines · Saul Wold

On 09/28/2013 05:29 AM, Chris Mason wrote:
Ah great news! I want to verify is your git repo for btrfs-progs the main upstream? I see loads of other patches flying around, but not applied there.

The patches land in the integration git repo

http://repo.or.cz/w/btrfs-progs-unstable/devel.git

at branches tagged by date.

#5 lore raw
Quoted 9 lines · Saul Wold
Quoted 4 lines · Chris Mason

Ah great news! I want to verify is your git repo for btrfs-progs the main upstream? I see loads of other patches flying around, but not applied there.

The patches land in the integration git repo

http://repo.or.cz/w/btrfs-progs-unstable/devel.git

David no only did a great job in maintaining btrfs-progs but also helped a lot with us newbies towards btrfs world.

Anyway, i think we do need some necessary btrfs-progs update(for example some regression bug fixes)…

Thanks,
Wang

Quoted 6 lines

at branches tagged by date.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#6 lore raw
In reply to Chris Mason
Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Any update on this? Just curious.

Thanks
Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#7 lore raw

Hi Saul,

The patch ended up a little bigger than I expected because it is sharing infrastructure with btfs-convert. Travel added a little more delay, but I'm almost there.

-chris
________________________________________
From: Saul Wold [[email protected]]
Sent: Tuesday, October 01, 2013 4:50 PM
To: Chris Mason
Cc: [email protected]
Subject: Re: Issue building a file based rootfs image with mkfs.btrfs

Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Any update on this? Just curious.

Thanks
Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#8 lore raw
Quoted 4 lines · Chris Mason

Hi Saul,

The patch ended up a little bigger than I expected because it is sharing infrastructure with btfs-convert. Travel added a little more delay, but I'm almost there.

Any news on this patch?

Sau!

Quoted 56 lines

-chris
________________________________________
From: Saul Wold [[email protected]]
Sent: Tuesday, October 01, 2013 4:50 PM
To: Chris Mason
Cc: [email protected]
Subject: Re: Issue building a file based rootfs image with mkfs.btrfs

Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Any update on this? Just curious.

Thanks
Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#9 lore raw

Hi Saul,

Sorry for the delay, I'll push the patch out this afternoon.

-chris

Quoting Saul Wold (2013-10-14 11:25:28)

Quoted 66 lines · Chris Mason
Quoted 4 lines

Hi Saul,

The patch ended up a little bigger than I expected because it is sharing infrastructure with btfs-convert. Travel added a little more delay, but I'm almost there.

Any news on this patch?

Sau!

Quoted 56 lines

-chris
________________________________________
From: Saul Wold [[email protected]]
Sent: Tuesday, October 01, 2013 4:50 PM
To: Chris Mason
Cc: [email protected]
Subject: Re: Issue building a file based rootfs image with mkfs.btrfs

Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Any update on this? Just curious.

Thanks
Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#10 lore raw

Hi Saul,

Well, a little bigger than I expected turned into a lot bigger than I expected. I've pushed the current code to my integration branch, but the next step is to re-integrate it with Dave's current tree and push out rc2.

I need to retest convert as well.

-chris

Quoting Chris Mason (2013-10-14 11:26:55)

Quoted 77 lines

Hi Saul,

Sorry for the delay, I'll push the patch out this afternoon.

-chris

Quoting Saul Wold (2013-10-14 11:25:28)

Quoted 66 lines · Chris Mason
Quoted 4 lines

Hi Saul,

The patch ended up a little bigger than I expected because it is sharing infrastructure with btfs-convert. Travel added a little more delay, but I'm almost there.

Any news on this patch?

Sau!

Quoted 56 lines

-chris
________________________________________
From: Saul Wold [[email protected]]
Sent: Tuesday, October 01, 2013 4:50 PM
To: Chris Mason
Cc: [email protected]
Subject: Re: Issue building a file based rootfs image with mkfs.btrfs

Quoted 25 lines · Chris Mason

Quoting Saul Wold (2013-09-19 14:19:34)

Quoted 20 lines

Hi there,

I am attempting to build a rootfs image from an existing rootfs directory tree. I am using the 0.20 @ 194aa4a of Chris's git repo.

The couple problem I saw was that the target image file needed to exist, although I think I can patch that then the FS size was much larger than the actual size, I tracked this to the usage of ftw not accounting for symlinks, I have a patch for that which I will send once I finish getting the other issues resolved.

Next issue I hit was an assertion failure after getting "not enough free space" message:

not enough free space
add_file_items failed
unable to traverse_directory
Making image is aborted.
mkfs.btrfs: mkfs.c:1542: main: Assertion `!(ret)' failed.

Quoted 3 lines

I am kind of stuck on this one, took it as far as I can right now. Would I be better off dropping back to 0.19 or can we move forward fixing this?

Quoted 8 lines

Hi Saul,

Update on my end, the problem is the image code expects every file to fit inside a single chunk. It's only creating 8MB chunks, so any file over 8MB in size is causing problems.

I'm fixing it up here, I should have a patch for you on Monday.

Any update on this? Just curious.

Thanks
Sau!

Quoted 9 lines

Thanks!

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html