Skip to contentSkip to conversation

8390 ei_debug : Reenable the use of debugging in 8390 based chips

PATCH In review Matthew Whitehead 1 participant 2 messages Oct 14, 2013 – Oct 15, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 8390 ei_debug : Reenable the use of debugging in 8390 based chips

Ethernet boards based on the 8390 chip had an '#ifdef notdef' disabling the use of the debug variable ei_debug. Reenable it for those of us who still occasionally use it.

---
 drivers/net/ethernet/8390/8390.h     |    2 +-
 drivers/net/ethernet/8390/axnet_cs.c |    5 -----
 drivers/net/ethernet/8390/lib8390.c  |    4 ++--
 3 files changed, 3 insertions(+), 8 deletions(-)
drivers/net/ethernet/8390/8390.h +1 -1
index ef325ff..2375087 100644
@@ -21,7 +21,7 @@ struct e8390_pkt_hdr {
   unsigned short count; /* header + packet length in bytes */
 };
 
-#ifdef notdef
+#ifdef EI_DEBUG
 extern int ei_debug;
 #else
 #define ei_debug 1
drivers/net/ethernet/8390/axnet_cs.c +0 -5
index d801c141..581560c 100644
@@ -810,11 +810,6 @@ module_pcmcia_driver(axnet_cs_driver);
 #define ei_block_input (ei_local->block_input)
 #define ei_get_8390_hdr (ei_local->get_8390_hdr)
 
-/* use 0 for production, 1 for verification, >2 for debug */
-#ifndef ei_debug
-int ei_debug = 1;
-#endif
-
 /* Index to functions. */
 static void ei_tx_intr(struct net_device *dev);
 static void ei_tx_err(struct net_device *dev);
drivers/net/ethernet/8390/lib8390.c +2 -2
index b329f5c..4ec5e38 100644
@@ -100,8 +100,8 @@
 #define ei_get_8390_hdr (ei_local->get_8390_hdr)
 
 /* use 0 for production, 1 for verification, >2 for debug */
-#ifndef ei_debug
-int ei_debug = 1;
+#ifdef EI_DEBUG
+int ei_debug = EI_DEBUG;
 #endif
 
 /* Index to functions. */
Signature · 1 line
1.7.2.5
#1 lore raw

Dave,
please decline this patch set and instead use the later one posted with subject

"[net-next REPOST] 8390 ei_debug : Reenable the use of debugging in 8390 based chips"

- Matthew