Skip to contentSkip to conversation

xfstests names/numbers

DISCUSSION Eric Sandeen 3 participants 4 messages Oct 16, 2013

lore
Share & tools
lore
#0 lore raw

Hey all (probably specifically Dave) -

Is there any patch in the works to allow non-numeric test names? It'd be nice to get away from the nondescript numbers clashing.

The numeric names "in service of nothing" is making Zach unhappy.

And if Zach ain't happy, ain't nobody happy. ;)

But seriously, I think that was in the works, or in the plan, once. Is there a patch out there somewhere?

Thanks,
-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 1 line

The numeric names "in service of nothing" is making Zach unhappy.

Yeah, it drives me nuts. I never want to rebase a patch series to renumber test number conflicts again.

Quoted 2 lines

But seriously, I think that was in the works, or in the plan, once. Is there a patch out there somewhere?

I'll give it a go if someone hasn't yet :).

- z

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Eric Sandeen
Quoted 4 lines · Eric Sandeen

Hey all (probably specifically Dave) -

Is there any patch in the works to allow non-numeric test names? It'd be nice to get away from the nondescript numbers clashing.

Well, I was kind of waiting for the rest of Lukas' patch that introduced config sections to be finished and committed before touching that same code...

Quoted 3 lines

The numeric names "in service of nothing" is making Zach unhappy.

And if Zach ain't happy, ain't nobody happy. ;)

On the count of 3. 1... 2... 3...

Awwwwww, poor Zach.

:)

Quoted 2 lines

But seriously, I think that was in the works, or in the plan, once. Is there a patch out there somewhere?

There's a bit of infrastructure work to make it a reality - all of the CLI parsing/validity checks assumes tests are numbered and match a sepcific regex, as do some of the test list building functions. That all needs to be reworked, and up until now it hasn't been a huge priority for me so I haven't started that work yet.

You're more than welcome to hack on it if you want....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#3 lore raw
Quoted 7 lines
Quoted 1 line

And if Zach ain't happy, ain't nobody happy. ;)

On the count of 3. 1... 2... 3...

Awwwwww, poor Zach.

:)

*group hugs*

Quoted 1 line

You're more than welcome to hack on it if you want....

Yeah, I'll take a swing at it. What's the worst that could happen? :)

- z

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs