Skip to contentSkip to conversation

ARM: shmobile: Cosmetic update of Lager DT Reference

PATCH New Magnus Damm 2 participants 4 messages Oct 16, 2013 – Oct 17, 2013

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: Cosmetic update of Lager DT Reference

From: Magnus Damm <[email protected]>

Clean up the Lager DT reference board code to make it match Koelsch DT reference including using the rcar-gen2 header.

---

Written against renesas-devel-20131016

 arch/arm/mach-shmobile/board-lager-reference.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/mach-shmobile/board-lager-reference.c +2 -3
@@ -20,16 +20,15 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
 
 static void __init lager_add_standard_devices(void)
 {
-	/* clocks are setup late during boot in the case of DT */
 	r8a7790_clock_init();
-
 	r8a7790_add_dt_devices();
-        of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
 static const char *lager_boards_compat_dt[] __initdata = {
#1 lore raw

PATCH 1/1 ARM: shmobile: Cosmetic update of Lager DT Reference

Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Clean up the Lager DT reference board code to make it match Koelsch DT reference including using the rcar-gen2 header.

This is getting dangerously close to churn.
Do you really want me to take this change?

Quoted 35 lines

---

Written against renesas-devel-20131016

 arch/arm/mach-shmobile/board-lager-reference.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/mach-shmobile/board-lager-reference.c +2 -4
@@ -20,16 +20,15 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
 
 static void __init lager_add_standard_devices(void)
 {
-	/* clocks are setup late during boot in the case of DT */
 	r8a7790_clock_init();
-
 	r8a7790_add_dt_devices();
-        of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
 static const char *lager_boards_compat_dt[] __initdata = {
--

To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#2 lore raw

PATCH 1/1 ARM: shmobile: Cosmetic update of Lager DT Reference

Hi Simon,

Quoted 8 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Clean up the Lager DT reference board code to make it match Koelsch DT reference including using the rcar-gen2 header.

This is getting dangerously close to churn.
Do you really want me to take this change?

I don't mind so much, but I think that the idea of keeping Lager and Koelsch in the same style makes sense. Would you prefer to split this up in several patches? There is some whitespace damage and also the header file inclusion style is different from Koelsch.

Cheers,

/ magnus

#3 lore raw

PATCH 1/1 ARM: shmobile: Cosmetic update of Lager DT Reference

Quoted 9 lines · Magnus Damm

Hi Simon,

Quoted 6 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Clean up the Lager DT reference board code to make it match Koelsch DT reference including using the rcar-gen2 header.

Quoted 7 lines
Quoted 2 lines

This is getting dangerously close to churn.
Do you really want me to take this change?

I don't mind so much, but I think that the idea of keeping Lager and Koelsch in the same style makes sense. Would you prefer to split this up in several patches? There is some whitespace damage and also the header file inclusion style is different from Koelsch.

I don't think splitting it would improve my level of happiness.

I now accept that the header include change is of some merit and I'm prepared to take the rest as baggage.