clk: armada-370: fix tclk frequencies
Subsystems (2)
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit 6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").
A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/mvebu/armada-370.c +2 -2
@@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] __initconst = { };static const u32 a370_tclk_freqs[]__initconst = { -16600000 , -20000000 , +166000000 , +200000000 , };static u32 __init a370_get_tclk_freq (void __iomem *sar)
Signature · 1 line
1.7.10.4
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Simon,
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.org
Quoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Much better, thanks!
This can be applied to v3.11 onwards.
thx,
Jason.
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoted 25 lines · Jason Cooper
Simon,
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.orgQuoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Much better, thanks!
Acked-by Jason Cooper <[email protected]>This can be applied to v3.11 onwards.
Hi Mike,
Please consider applying this patch.
Thanks,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131009/9299dbec/attachment.sig>
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoted 28 lines · Simon Guinot
Quoted 27 lines · Jason Cooper
Simon,
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.orgQuoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Much better, thanks!
Quoted 7 lines
Quoted 3 lines
Acked-by Jason Cooper <[email protected]>This can be applied to v3.11 onwards.
Hi Mike,
Please consider applying this patch.
Ping ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131014/7acad144/attachment.sig>
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoted 31 lines · Simon Guinot
Quoted 30 lines · Simon Guinot
Quoted 29 lines · Jason Cooper
Simon,
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.orgQuoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Much better, thanks!
Acked-by Jason Cooper <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
This can be applied to v3.11 onwards.
Hi Mike,
Please consider applying this patch.
Ping ?
Mike,
this bug could be very annoying. We had some issue recently with i2c, and I am pretty sure it was caused by this wrong rate.
So it would be nice to have this fix in 3.12, and then on the stable branches.
Of course you can also add my:
Thanks,
Quoted 8 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoted 42 lines · Gregory CLEMENT
Quoted 31 lines · Simon Guinot
Quoted 30 lines · Simon Guinot
Quoted 29 lines · Jason Cooper
Simon,
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.orgQuoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Much better, thanks!
Acked-by Jason Cooper <[email protected]>Quoted 7 lines
Quoted 5 lines
Quoted 1 line
This can be applied to v3.11 onwards.
Hi Mike,
Please consider applying this patch.
Ping ?
Mike,
Quoted 7 lines
this bug could be very annoying. We had some issue recently with i2c, and I am pretty sure it was caused by this wrong rate.
So it would be nice to have this fix in 3.12, and then on the stable branches.Of course you can also add my:
Acked-by Gregory CLEMENT <[email protected]>
Well, it seems that Mike is not available this days.
Given that this patch is a trivial one-liner, maybe that someone else can pick it ?
Thanks in advance.
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131017/69bd1a63/attachment.sig>
Jason Cooper
AppliedPATCH v2 1/1 clk: armada-370: fix tclk frequencies
In reply to Simon GuinotMike,
I going to go ahead a take this through my tree. I'll hold it off until my last pull request for the merge window (I'm guessing about a week). If you object, just let me know before then and I'll drop it.
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.org
Quoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to mvebu/drivers for v3.13 and flagged for stable going back to v3.11. Also added Gregory's Ack.
thx,
Jason.
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoting Jason Cooper (2013-10-17 05:31:59)
Quoted 30 lines
Mike,
I going to go ahead a take this through my tree. I'll hold it off until my last pull request for the merge window (I'm guessing about a week). If you object, just let me know before then and I'll drop it.
Quoted 18 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.orgQuoted 3 lines
--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 2 lines
Applied to mvebu/drivers for v3.13 and flagged for stable going back to v3.11. Also added Gregory's Ack.
Worked it out with Jason face to face. I've added to clk-fixes with ACKs and will send out this week.
Regards,
Mike
Quoted 4 lines
thx,
Jason.
PATCH v2 1/1 clk: armada-370: fix tclk frequencies
Quoted 31 lines · Mike Turquette
Quoting Jason Cooper (2013-10-17 05:31:59)
Quoted 30 lines
Mike,
I going to go ahead a take this through my tree. I'll hold it off until my last pull request for the merge window (I'm guessing about a week). If you object, just let me know before then and I'll drop it.
Quoted 21 lines · Simon Guinot
This patch fixes the tclk frequency array for the Armada-370 SoC. This bug has been introduced by commit
6b72333d
("clk: mvebu: add Armada 370 SoC-centric clock init").A wrong tclk frequency affects the following drivers: mvsdio, mvneta, i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
About the mvneta Ethernet driver, note that the tclk frequency is used to compute the Rx time coalescence. Then, this bug harms the coalescence configuration and also degrades the networking performances with the default values.
Signed-off-by Simon Guinot <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Jason Cooper <[email protected]>Cc stable at vger.kernel.org--- drivers/clk/mvebu/armada-370.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 2 lines
Applied to mvebu/drivers for v3.13 and flagged for stable going back to v3.11. Also added Gregory's Ack.
Worked it out with Jason face to face. I've added to clk-fixes with ACKs and will send out this week.
Hi Mike,
Please, don't forget to send out :)
Thanks,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/d779ecb9/attachment-0001.sig>