mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
Subsystems (4)
v2 cover mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
Changes since v1:
* Create flags only for features and errata such things, and keep using is_imx*_esdhc() for small register differences between esdhc variants.
Shawn Guo (4):
mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_ENGCM07207
mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_USDHC
mmc: sdhci-esdhc-imx: pdev->id_entry should be immutable
mmc: sdhci-esdhc-imx: create struct esdhc_soc_data
drivers/mmc/host/sdhci-esdhc-imx.c | 126 +++++++++++++++++++----------------- 1 file changed, 68 insertions(+), 58 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v2 1/4 mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_ENGCM07207
Just like the use of the flag ESDHC_FLAG_MULTIBLK_NO_INT, let's add another flag ESDHC_FLAG_ENGCM07207 to enable the workaround for errata ENGcm07207 and set the flag for i.MX25 and i.MX35 ESDHC.
While at it, let's use BIT() macro for ESDHC_FLAG_MULTIBLK_NO_INT as well.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +10 -2
@@ -83,7 +83,12 @@* As a result, the TC flag is not asserted and SW received timeout * exeception. Bit1 of Vendor Spec registor is used to fix it. */ -#define ESDHC_FLAG_MULTIBLK_NO_INT (1 << 1) +#define ESDHC_FLAG_MULTIBLK_NO_INT BIT(1) +/* +* The flag enables the workaround for ESDHC errata ENGcm07207 which +* affects i.MX25 and i.MX35. +*/ +#define ESDHC_FLAG_ENGCM07207 BIT(2)enum imx_esdhc_type {IMX25_ESDHC ,
@@ -857,6 +862,9 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) imx_data->devtype = pdev->id_entry->driver_data; pltfm_host->priv = imx_data; +if (is_imx25_esdhc (imx_data) ||is_imx35_esdhc (imx_data)) + imx_data->flags |=ESDHC_FLAG_ENGCM07207 ; + imx_data->clk_ipg =devm_clk_get (&pdev->dev,"ipg" );if (IS_ERR (imx_data->clk_ipg)) { err =PTR_ERR (imx_data->clk_ipg);
@@ -897,7 +905,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) host->quirks |=SDHCI_QUIRK_BROKEN_TIMEOUT_VAL ; -if (is_imx25_esdhc (imx_data) ||is_imx35_esdhc (imx_data)) +if (imx_data->flags &ESDHC_FLAG_ENGCM07207 )/* Fix errata ENGcm07207 present on i.MX25 and i.MX35 */ host->quirks |=SDHCI_QUIRK_NO_MULTIBLOCK |SDHCI_QUIRK_BROKEN_ADMA ;
Signature · 1 line
1.7.9.5
PATCH v2 2/4 mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_USDHC
In reply to Shawn GuoAdd flag ESDHC_FLAG_USDHC to tell that the ESDHC is actually an USDHC block, and replace the is_imx6q_usdhc() occurrences with inline function esdhc_is_usdhc() which checks the flag.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 37 ++++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 12 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +25 -12
@@ -89,6 +89,11 @@* affects i.MX25 and i.MX35. */ #define ESDHC_FLAG_ENGCM07207 BIT(2) +/* +* The flag tells that the ESDHC controller is an USDHC block that is +* integrated on the i.MX6 series. +*/ +#define ESDHC_FLAG_USDHC BIT(3)enum imx_esdhc_type {IMX25_ESDHC ,
@@ -175,6 +180,11 @@ static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)return data->devtype ==IMX6Q_USDHC ; } +static inline int esdhc_is_usdhc (struct pltfm_imx_data *data) +{ +return !!(data->flags &ESDHC_FLAG_USDHC ); +} +static inline void esdhc_clrset_le (struct sdhci_host *host,u32 mask,u32 val,int reg) {void __iomem *base = host->ioaddr + (reg & ~0x3 );
@@ -213,11 +223,11 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg) } } -if (unlikely (reg ==SDHCI_CAPABILITIES_1 ) &&is_imx6q_usdhc (imx_data)) +if (unlikely (reg ==SDHCI_CAPABILITIES_1 ) &&esdhc_is_usdhc (imx_data)) val =SDHCI_SUPPORT_DDR50 |SDHCI_SUPPORT_SDR104 |SDHCI_SUPPORT_SDR50 ; -if (unlikely (reg ==SDHCI_MAX_CURRENT ) &&is_imx6q_usdhc (imx_data)) { +if (unlikely (reg ==SDHCI_MAX_CURRENT ) &&esdhc_is_usdhc (imx_data)) { val =0 ; val |=0xFF <<SDHCI_MAX_CURRENT_330_SHIFT ; val |=0xFF <<SDHCI_MAX_CURRENT_300_SHIFT ;
@@ -307,7 +317,7 @@ static u16 esdhc_readw_le(struct sdhci_host *host, int reg)if (unlikely (reg ==SDHCI_HOST_VERSION )) { reg ^=2 ; -if (is_imx6q_usdhc (imx_data)) { +if (esdhc_is_usdhc (imx_data)) {/* * The usdhc register returns a wrong host version. * Correct it here.
@@ -321,7 +331,7 @@ static u16 esdhc_readw_le(struct sdhci_host *host, int reg)if (val &ESDHC_VENDOR_SPEC_VSELECT ) ret |=SDHCI_CTRL_VDD_180 ; -if (is_imx6q_usdhc (imx_data)) { +if (esdhc_is_usdhc (imx_data)) { val =readl (host->ioaddr +ESDHC_MIX_CTRL );if (val &ESDHC_MIX_CTRL_EXE_TUNE ) ret |=SDHCI_CTRL_EXEC_TUNING ;
@@ -379,7 +389,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)writel (v, host->ioaddr +ESDHC_VENDOR_SPEC ); } -if (is_imx6q_usdhc (imx_data)) { +if (esdhc_is_usdhc (imx_data)) {u32 m =readl (host->ioaddr +ESDHC_MIX_CTRL );/* Swap AC23 bit */ if (val &SDHCI_TRNS_AUTO_CMD23 ) {
@@ -404,7 +414,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg) (imx_data->flags & ESDHC_FLAG_MULTIBLK_NO_INT)) imx_data->multiblock_status = MULTIBLK_IN_PROCESS; -if (is_imx6q_usdhc (imx_data)) +if (esdhc_is_usdhc (imx_data))writel (val <<16 , host->ioaddr +SDHCI_TRANSFER_MODE );else
@@ -470,7 +480,7 @@ static void esdhc_writeb_le(struct sdhci_host *host, u8 val, int reg)* The reset on usdhc fails to clear MIX_CTRL register. * Do it manually here. */ -if (is_imx6q_usdhc (imx_data)) +if (esdhc_is_usdhc (imx_data))writel (0 , host->ioaddr +ESDHC_MIX_CTRL ); } }
@@ -507,7 +517,7 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,u32 temp, val;if (clock ==0 ) { -if (is_imx6q_usdhc (imx_data)) { +if (esdhc_is_usdhc (imx_data)) { val =readl (host->ioaddr +ESDHC_VENDOR_SPEC );writel (val & ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON , host->ioaddr +ESDHC_VENDOR_SPEC );
@@ -515,7 +525,7 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, goto out; } -if (is_imx6q_usdhc (imx_data)) +if (esdhc_is_usdhc (imx_data)) pre_div =1 ; temp =sdhci_readl (host,ESDHC_SYSTEM_CONTROL );
@@ -542,7 +552,7 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, | (pre_div << ESDHC_PREDIV_SHIFT));sdhci_writel (host, temp,ESDHC_SYSTEM_CONTROL ); -if (is_imx6q_usdhc (imx_data)) { +if (esdhc_is_usdhc (imx_data)) { val =readl (host->ioaddr +ESDHC_VENDOR_SPEC );writel (val |ESDHC_VENDOR_SPEC_FRC_SDCLK_ON , host->ioaddr +ESDHC_VENDOR_SPEC );
@@ -865,6 +875,9 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)if (is_imx25_esdhc (imx_data) ||is_imx35_esdhc (imx_data)) imx_data->flags |=ESDHC_FLAG_ENGCM07207 ; +if (is_imx6q_usdhc (imx_data)) + imx_data->flags |=ESDHC_FLAG_USDHC ; + imx_data->clk_ipg =devm_clk_get (&pdev->dev,"ipg" );if (IS_ERR (imx_data->clk_ipg)) { err =PTR_ERR (imx_data->clk_ipg);
@@ -917,7 +930,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)* The imx6q ROM code will change the default watermark level setting * to something insane. Change it back here. */ -if (is_imx6q_usdhc (imx_data)) +if (esdhc_is_usdhc (imx_data))writel (0x08100810 , host->ioaddr +ESDHC_WTMK_LVL ); boarddata = &imx_data->boarddata;
@@ -980,7 +993,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) }/* sdr50 and sdr104 needs work on 1.8v signal voltage */ -if ((boarddata->support_vsel) &&is_imx6q_usdhc (imx_data)) { +if ((boarddata->support_vsel) &&esdhc_is_usdhc (imx_data)) { imx_data->pins_100mhz =pinctrl_lookup_state (imx_data->pinctrl,ESDHC_PINCTRL_STATE_100MHZ ); imx_data->pins_200mhz = pinctrl_lookup_state(imx_data->pinctrl,
Signature · 1 line
1.7.9.5
PATCH v2 3/4 mmc: sdhci-esdhc-imx: pdev->id_entry should be immutable
In reply to Shawn GuoAs a good practice, device driver should not modify pdev->id_entry but keep it immutable. Let's assign of_device_id.data with imx_esdhc_type constants directly, so that we do not have to manipulate pdev->id_entry in .probe().
As the result, sdhci-esdhc-imx53 and sdhci-usdhc-imx6q can be removed from platform_device_id table now, since they will only probe from device tree.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +7 -14
@@ -134,23 +134,17 @@ static struct platform_device_id imx_esdhc_devtype[] = { .name = "sdhci-esdhc-imx51", .driver_data = IMX51_ESDHC, }, { - .name = "sdhci-esdhc-imx53", - .driver_data = IMX53_ESDHC, - }, { - .name = "sdhci-usdhc-imx6q", - .driver_data = IMX6Q_USDHC, - }, {/* sentinel */ } };MODULE_DEVICE_TABLE (platform, imx_esdhc_devtype);static const struct of_device_id imx_esdhc_dt_ids[] = { - { .compatible ="fsl,imx25-esdhc" , .data = &imx_esdhc_devtype[IMX25_ESDHC ], }, - { .compatible ="fsl,imx35-esdhc" , .data = &imx_esdhc_devtype[IMX35_ESDHC ], }, - { .compatible ="fsl,imx51-esdhc" , .data = &imx_esdhc_devtype[IMX51_ESDHC ], }, - { .compatible ="fsl,imx53-esdhc" , .data = &imx_esdhc_devtype[IMX53_ESDHC ], }, - { .compatible ="fsl,imx6q-usdhc" , .data = &imx_esdhc_devtype[IMX6Q_USDHC ], }, + { .compatible ="fsl,imx25-esdhc" , .data = (void *)IMX25_ESDHC , }, + { .compatible ="fsl,imx35-esdhc" , .data = (void *)IMX35_ESDHC , }, + { .compatible ="fsl,imx51-esdhc" , .data = (void *)IMX51_ESDHC , }, + { .compatible ="fsl,imx53-esdhc" , .data = (void *)IMX53_ESDHC , }, + { .compatible ="fsl,imx6q-usdhc" , .data = (void *)IMX6Q_USDHC , }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, imx_esdhc_dt_ids);
@@ -867,9 +861,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) goto free_sdhci; } -if (of_id) - pdev->id_entry = of_id->data; - imx_data->devtype = pdev->id_entry->driver_data; + imx_data->devtype = of_id ? (enum imx_esdhc_type ) of_id->data : + pdev->id_entry->driver_data; pltfm_host->priv = imx_data;if (is_imx25_esdhc (imx_data) ||is_imx35_esdhc (imx_data))
Signature · 1 line
1.7.9.5
PATCH v2 4/4 mmc: sdhci-esdhc-imx: create struct esdhc_soc_data
In reply to Shawn GuoCreate a struct esdhc_soc_data with moving 'flags' field from pltfm_imx_data into it, and pass the pointer of this SoC specific data structure through of_device_id.data directly, so that the translation from enum imx_esdhc_type to flags can be saved.
With the change, enum imx_esdhc_type can be eliminated, since we can implement the is_imx*_esdhc() by checking the esdhc_soc_data pointer. The unused is_imx35_esdhc() and is_imx51_esdhc() are also removed, and the others are kept there as we will need to use them to handle some small register differences later, where use of new flags might be a little overkilled.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 86 +++++++++++++++++------------------- 1 file changed, 41 insertions(+), 45 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +41 -45
@@ -95,22 +95,37 @@*/ #define ESDHC_FLAG_USDHC BIT(3) -enum imx_esdhc_type { -IMX25_ESDHC , -IMX35_ESDHC , -IMX51_ESDHC , -IMX53_ESDHC , -IMX6Q_USDHC , +struct esdhc_soc_data { +u32 flags; +}; + +static struct esdhc_soc_data esdhc_imx25_data = { + .flags =ESDHC_FLAG_ENGCM07207 , +}; + +static struct esdhc_soc_data esdhc_imx35_data = { + .flags =ESDHC_FLAG_ENGCM07207 , +}; + +static struct esdhc_soc_data esdhc_imx51_data = { + .flags =0 , +}; + +static struct esdhc_soc_data esdhc_imx53_data = { + .flags =ESDHC_FLAG_MULTIBLK_NO_INT , +}; + +static struct esdhc_soc_data usdhc_imx6q_data = { + .flags =ESDHC_FLAG_USDHC , };struct pltfm_imx_data { -int flags;u32 scratchpad; -enum imx_esdhc_type devtype;struct pinctrl *pinctrl;struct pinctrl_state *pins_default;struct pinctrl_state *pins_100mhz;struct pinctrl_state *pins_200mhz; +const struct esdhc_soc_data *socdata;struct esdhc_platform_data boarddata;struct clk *clk_ipg;struct clk *clk_ahb;
@@ -126,13 +141,13 @@ struct pltfm_imx_data {static struct platform_device_id imx_esdhc_devtype[] = { { .name ="sdhci-esdhc-imx25" , - .driver_data =IMX25_ESDHC , + .driver_data = (kernel_ulong_t) &esdhc_imx25_data, }, { .name ="sdhci-esdhc-imx35" , - .driver_data =IMX35_ESDHC , + .driver_data = (kernel_ulong_t) &esdhc_imx35_data, }, { .name ="sdhci-esdhc-imx51" , - .driver_data =IMX51_ESDHC , + .driver_data = (kernel_ulong_t) &esdhc_imx51_data, }, {/* sentinel */ }
@@ -140,43 +155,33 @@ static struct platform_device_id imx_esdhc_devtype[] = {MODULE_DEVICE_TABLE (platform, imx_esdhc_devtype);static const struct of_device_id imx_esdhc_dt_ids[] = { - { .compatible ="fsl,imx25-esdhc" , .data = (void *)IMX25_ESDHC , }, - { .compatible ="fsl,imx35-esdhc" , .data = (void *)IMX35_ESDHC , }, - { .compatible ="fsl,imx51-esdhc" , .data = (void *)IMX51_ESDHC , }, - { .compatible ="fsl,imx53-esdhc" , .data = (void *)IMX53_ESDHC , }, - { .compatible ="fsl,imx6q-usdhc" , .data = (void *)IMX6Q_USDHC , }, + { .compatible ="fsl,imx25-esdhc" , .data = &esdhc_imx25_data, }, + { .compatible ="fsl,imx35-esdhc" , .data = &esdhc_imx35_data, }, + { .compatible ="fsl,imx51-esdhc" , .data = &esdhc_imx51_data, }, + { .compatible ="fsl,imx53-esdhc" , .data = &esdhc_imx53_data, }, + { .compatible ="fsl,imx6q-usdhc" , .data = &usdhc_imx6q_data, }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, imx_esdhc_dt_ids);static inline int is_imx25_esdhc (struct pltfm_imx_data *data) { -return data->devtype ==IMX25_ESDHC ; -} - -static inline int is_imx35_esdhc (struct pltfm_imx_data *data) -{ -return data->devtype ==IMX35_ESDHC ; -} - -static inline int is_imx51_esdhc (struct pltfm_imx_data *data) -{ -return data->devtype ==IMX51_ESDHC ; +return data->socdata == &esdhc_imx25_data; }static inline int is_imx53_esdhc (struct pltfm_imx_data *data) { -return data->devtype ==IMX53_ESDHC ; +return data->socdata == &esdhc_imx53_data; }static inline int is_imx6q_usdhc (struct pltfm_imx_data *data) { -return data->devtype ==IMX6Q_USDHC ; +return data->socdata == &usdhc_imx6q_data; }static inline int esdhc_is_usdhc (struct pltfm_imx_data *data) { -return !!(data->flags &ESDHC_FLAG_USDHC ); +return !!(data->socdata->flags &ESDHC_FLAG_USDHC ); }static inline void esdhc_clrset_le (struct sdhci_host *host,u32 mask,u32 val,int reg)
@@ -274,7 +279,7 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg) } } -if (unlikely ((imx_data->flags &ESDHC_FLAG_MULTIBLK_NO_INT ) +if (unlikely ((imx_data->socdata->flags &ESDHC_FLAG_MULTIBLK_NO_INT ) && (reg ==SDHCI_INT_STATUS ) && (val &SDHCI_INT_DATA_END ))) {u32 v;
@@ -373,7 +378,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)writel (new_val , host->ioaddr +ESDHC_MIX_CTRL );return ;case SDHCI_TRANSFER_MODE : -if ((imx_data->flags &ESDHC_FLAG_MULTIBLK_NO_INT ) +if ((imx_data->socdata->flags &ESDHC_FLAG_MULTIBLK_NO_INT ) && (host->cmd->opcode ==SD_IO_RW_EXTENDED ) && (host->cmd->data->blocks >1 ) && (host->cmd->data->flags &MMC_DATA_READ )) {
@@ -405,7 +410,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg) val |=SDHCI_CMD_ABORTCMD ;if ((host->cmd->opcode ==MMC_SET_BLOCK_COUNT ) && - (imx_data->flags &ESDHC_FLAG_MULTIBLK_NO_INT )) + (imx_data->socdata->flags &ESDHC_FLAG_MULTIBLK_NO_INT )) imx_data->multiblock_status =MULTIBLK_IN_PROCESS ;if (esdhc_is_usdhc (imx_data))
@@ -861,16 +866,10 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) goto free_sdhci; } - imx_data->devtype = of_id ? (enum imx_esdhc_type ) of_id->data : - pdev->id_entry->driver_data; + imx_data->socdata = of_id ? of_id->data : (struct esdhc_soc_data *) + pdev->id_entry->driver_data; pltfm_host->priv = imx_data; -if (is_imx25_esdhc (imx_data) ||is_imx35_esdhc (imx_data)) - imx_data->flags |=ESDHC_FLAG_ENGCM07207 ; - -if (is_imx6q_usdhc (imx_data)) - imx_data->flags |=ESDHC_FLAG_USDHC ; - imx_data->clk_ipg =devm_clk_get (&pdev->dev,"ipg" );if (IS_ERR (imx_data->clk_ipg)) { err =PTR_ERR (imx_data->clk_ipg);
@@ -911,14 +910,11 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) host->quirks |=SDHCI_QUIRK_BROKEN_TIMEOUT_VAL ; -if (imx_data->flags &ESDHC_FLAG_ENGCM07207 ) +if (imx_data->socdata->flags &ESDHC_FLAG_ENGCM07207 )/* Fix errata ENGcm07207 present on i.MX25 and i.MX35 */ host->quirks |=SDHCI_QUIRK_NO_MULTIBLOCK |SDHCI_QUIRK_BROKEN_ADMA ; -if (is_imx53_esdhc (imx_data)) - imx_data->flags |=ESDHC_FLAG_MULTIBLK_NO_INT ; -/* * The imx6q ROM code will change the default watermark level setting * to something insane. Change it back here.
Signature · 1 line
1.7.9.5
v2 cover mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
In reply to Shawn GuoQuoted 4 lines · Shawn Guo
Changes since v1:
* Create flags only for features and errata such things, and keep using is_imx*_esdhc() for small register differences between esdhc variants.
Quoted 12 lines
Shawn Guo (4):
mmc: sdhci-esdhc-imx: add flagESDHC_FLAG_ENGCM07207
mmc: sdhci-esdhc-imx: add flagESDHC_FLAG_USDHC
mmc: sdhci-esdhc-imx:pdev->id_entryshould be immutable
mmc: sdhci-esdhc-imx: create structesdhc_soc_datadrivers/mmc/host/sdhci-esdhc-imx.c | 126 +++++++++++++++++++----------------- 1 file changed, 68 insertions(+), 58 deletions(-)Signature · 1 line
1.7.9.5
I will rebase my mx6sl std tuning patch series based on it and send out again.
Regards
Dong Aisheng
v2 cover mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
Hi Shawn,
Quoted 11 lines · Dong Aisheng
Quoted 10 lines · Shawn Guo
Changes since v1:
* Create flags only for features and errata such things, and keep using is_imx*_esdhc() for small register differences between esdhc variants.Shawn Guo (4):
mmc: sdhci-esdhc-imx: add flagESDHC_FLAG_ENGCM07207
mmc: sdhci-esdhc-imx: add flagESDHC_FLAG_USDHC
mmc: sdhci-esdhc-imx:pdev->id_entryshould be immutable
mmc: sdhci-esdhc-imx: create structesdhc_soc_data
Quoted 7 lines
Quoted 2 lines
drivers/mmc/host/sdhci-esdhc-imx.c | 126 +++++++++++++++++++----------------- 1 file changed, 68 insertions(+), 58 deletions(-)Acked-by Dong Aisheng <[email protected]>I will rebase my mx6sl std tuning patch series based on it and send out again.
Thanks, pushed to mmc-next for 3.13 with Dong's ACK.
- Chris.
Signature · 1 line
Chris Ball <[email protected]> <http://printf.net/>