ax25: cleanup a range test
Subsystems (3)
PATCH 1/1 ax25: cleanup a range test
The current test works fine in practice. The "amount" variable is actually used as a boolean so negative values or any non-zero values count as "true". However since we don't allow numbers greater than one, let's not allow negative numbers either.
Signed-off-by Dan Carpenter <[email protected]>
net/ax25/af_ax25.c +1 -1
@@ -1735,7 +1735,7 @@ static int ax25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) res = -EFAULT ;break ; } -if (amount >AX25_NOUID_BLOCK ) { +if (amount <0 || amount >AX25_NOUID_BLOCK ) { res = -EINVAL ;break ; }
From: Dan Carpenter <[email protected]>
Date: Fri, 18 Oct 2013 12:06:56 +0300
Quoted 6 lines
The current test works fine in practice. The "amount" variable is actually used as a boolean so negative values or any non-zero values count as "true". However since we don't allow numbers greater than one, let's not allow negative numbers either.
Signed-off-by Dan Carpenter <[email protected]>
Applied to net-next, thanks Dan.