Skip to contentSkip to conversation

ARM: ux500: fix I2C4 clock bit

PATCH New Linus Walleij 2 participants 2 messages Oct 18, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 4/5 ARM: ux500: fix I2C4 clock bit

The PCLK for I2C4 is controlled by bit 10 in the PCKEN registers while the KCLK is controlled by bit 9 on the KCKEN, it's one of these odd assymetric things. Correct the PCLK bit to 10.

---
ChangeLog v1->v2:
- Actually do what the commit says and update the PCLK to bit 10 instead of screwing with the KCLK. The KCLK was right all the time.

---
 arch/arm/boot/dts/ste-dbx5x0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ste-dbx5x0.dtsi +1 -1
index 705bd0d..7da99fe 100644
@@ -694,7 +694,7 @@
 
 			clock-frequency = <400000>;
 
-			clocks = <&prcc_kclk 1 9>, <&prcc_pclk 1 9>;
+			clocks = <&prcc_kclk 1 9>, <&prcc_pclk 1 10>;
 			clock-names = "i2cclk", "apb_pclk";
 		};
 
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH v2 4/5 ARM: ux500: fix I2C4 clock bit

Quoted 19 lines · Linus Walleij

The PCLK for I2C4 is controlled by bit 10 in the PCKEN registers while the KCLK is controlled by bit 9 on the KCKEN, it's one of these odd assymetric things. Correct the PCLK bit to 10.

---
ChangeLog v1->v2:
- Actually do what the commit says and update the PCLK to bit 10 instead of screwing with the KCLK. The KCLK was right all the time.

---
 arch/arm/boot/dts/ste-dbx5x0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ste-dbx5x0.dtsi +0 -0
index 705bd0d..7da99fe 100644

arch/arm/boot/dts/ste-dbx5x0.dtsi line 698

Quoted 6 lines
arch/arm/boot/dts/ste-dbx5x0.dtsi +1 -1
@@ -694,7 +694,7 @@
 
 			clock-frequency = <400000>;
 
-			clocks = <&prcc_kclk 1 9>, <&prcc_pclk 1 9>;
+			clocks = <&prcc_kclk 1 9>, <&prcc_pclk 1 10>;
 			clock-names = "i2cclk", "apb_pclk";

Ah, much better:

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog