Skip to contentSkip to conversation

ASoC: kirkwood: prefer external clock over internal clock

PATCH RESEND In review Jean-Francois Moine 2 participants 2 messages Oct 18, 2013 – Oct 20, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ASoC: kirkwood: prefer external clock over internal clock

When there is an external clock, always use this one. This prevents the two Dove audio devices to use the same DCO clock at different rates.

---
This patch was initialy proposed by Russell, but with an erroneous 'else if'.

---
 sound/soc/kirkwood/kirkwood-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/kirkwood/kirkwood-i2s.c +1 -1
index 0f3d73d..8ac89f5 100644
@@ -103,7 +103,7 @@ static void kirkwood_set_rate(struct snd_soc_dai *dai,
 {
 	uint32_t clks_ctrl;
 
-	if (rate == 44100 || rate == 48000 || rate == 96000) {
+	if (IS_ERR(priv->extclk)) {
 		/* use internal dco for the supported rates
 		 * defined in kirkwood_i2s_dai */
 		dev_dbg(dai->dev, "%s: dco set rate = %lu\n",
Signature · 7 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw
Quoted 3 lines · Jean-Francois Moine

When there is an external clock, always use this one. This prevents the two Dove audio devices to use the same DCO clock at different rates.

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131020/b17dabc8/attachment.sig>