Skip to contentSkip to conversation

ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

PATCH New Amit Daniel Kachhap 4 participants 4 messages Oct 11, 2013 – Oct 21, 2013

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

Now with common clock support added for exynos5250 it is necessary to move this code to exynos5250 common clock driver as clock registers should be handled there. This change is tested in exynos5250 based arndale platform.

---

Changes in V2:
* Rebased against linux-next tree.
* Removed un-used macros in regs-clock.h

 arch/arm/mach-exynos/cpuidle.c                 |   35 --------------------
 arch/arm/mach-exynos/include/mach/regs-clock.h |   16 ---------
 drivers/clk/samsung/clk-exynos5250.c           |   42 ++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 51 deletions(-)
arch/arm/mach-exynos/cpuidle.c +0 -35
index 1bde6ad..40963ce 100644
@@ -161,46 +161,11 @@ static int exynos4_enter_lowpower(struct cpuidle_device *dev,
 		return exynos4_enter_core0_aftr(dev, drv, new_index);
 }
 
-static void __init exynos5_core_down_clk(void)
-{
-	unsigned int tmp;
-
-	/*
-	 * Enable arm clock down (in idle) and set arm divider
-	 * ratios in WFI/WFE state.
-	 */
-	tmp = PWR_CTRL1_CORE2_DOWN_RATIO | \
-	      PWR_CTRL1_CORE1_DOWN_RATIO | \
-	      PWR_CTRL1_DIV2_DOWN_EN	 | \
-	      PWR_CTRL1_DIV1_DOWN_EN	 | \
-	      PWR_CTRL1_USE_CORE1_WFE	 | \
-	      PWR_CTRL1_USE_CORE0_WFE	 | \
-	      PWR_CTRL1_USE_CORE1_WFI	 | \
-	      PWR_CTRL1_USE_CORE0_WFI;
-	__raw_writel(tmp, EXYNOS5_PWR_CTRL1);
-
-	/*
-	 * Enable arm clock up (on exiting idle). Set arm divider
-	 * ratios when not in idle along with the standby duration
-	 * ratios.
-	 */
-	tmp = PWR_CTRL2_DIV2_UP_EN	 | \
-	      PWR_CTRL2_DIV1_UP_EN	 | \
-	      PWR_CTRL2_DUR_STANDBY2_VAL | \
-	      PWR_CTRL2_DUR_STANDBY1_VAL | \
-	      PWR_CTRL2_CORE2_UP_RATIO	 | \
-	      PWR_CTRL2_CORE1_UP_RATIO;
-	__raw_writel(tmp, EXYNOS5_PWR_CTRL2);
-}
-
 static int __init exynos_cpuidle_probe(struct platform_device *pdev)
 {
 	int cpu_id, ret;
 	struct cpuidle_device *device;
 
-	if (soc_is_exynos5250())
-		exynos5_core_down_clk();
-
 	if (soc_is_exynos5440())
 		exynos4_idle_driver.state_count = 1;
 
arch/arm/mach-exynos/include/mach/regs-clock.h +0 -16
index d36ad76..b59b0ad 100644
@@ -347,22 +347,6 @@
 
 #define EXYNOS5_EPLLCON0_LOCKED_SHIFT		(29)
 
-#define PWR_CTRL1_CORE2_DOWN_RATIO		(7 << 28)
-#define PWR_CTRL1_CORE1_DOWN_RATIO		(7 << 16)
-#define PWR_CTRL1_DIV2_DOWN_EN			(1 << 9)
-#define PWR_CTRL1_DIV1_DOWN_EN			(1 << 8)
-#define PWR_CTRL1_USE_CORE1_WFE			(1 << 5)
-#define PWR_CTRL1_USE_CORE0_WFE			(1 << 4)
-#define PWR_CTRL1_USE_CORE1_WFI			(1 << 1)
-#define PWR_CTRL1_USE_CORE0_WFI			(1 << 0)
-
-#define PWR_CTRL2_DIV2_UP_EN			(1 << 25)
-#define PWR_CTRL2_DIV1_UP_EN			(1 << 24)
-#define PWR_CTRL2_DUR_STANDBY2_VAL		(1 << 16)
-#define PWR_CTRL2_DUR_STANDBY1_VAL		(1 << 8)
-#define PWR_CTRL2_CORE2_UP_RATIO		(1 << 4)
-#define PWR_CTRL2_CORE1_UP_RATIO		(1 << 0)
-
 /* Compatibility defines and inclusion */
 
 #include <mach/regs-pmu.h>
drivers/clk/samsung/clk-exynos5250.c +42 -0

72 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 1/1 ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

Hi Amit,

Quoted 7 lines · On Friday 11 of October 2013 11:12:14 Amit Daniel Kachhap wrote:

Now with common clock support added for exynos5250 it is necessary to move this code to exynos5250 common clock driver as clock registers should be handled there. This change is tested in exynos5250 based arndale platform.

Cc Abhilash Kesavan <[email protected]>
Cc Thomas Abraham <[email protected]>

nit: Typo in samsung. Probably something that Kukjin can fix up when applying, though.

Quoted 4 lines

---

Quoted 8 lines

Changes in V2:
* Rebased against linux-next tree.
* Removed un-used macros in regs-clock.h

 arch/arm/mach-exynos/cpuidle.c                 |   35 --------------------
 arch/arm/mach-exynos/include/mach/regs-clock.h |   16 ---------
 drivers/clk/samsung/clk-exynos5250.c           |   42 ++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 51 deletions(-)

Otherwise

Best regards,
Tomasz

#2 lore raw

PATCH v2 1/1 ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

Quoted 22 lines · Tomasz Figa

Hi Amit,

Quoted 7 lines · On Friday 11 of October 2013 11:12:14 Amit Daniel Kachhap wrote:

Now with common clock support added for exynos5250 it is necessary to move this code to exynos5250 common clock driver as clock registers should be handled there. This change is tested in exynos5250 based arndale platform.

Cc Abhilash Kesavan<[email protected]>
Cc Thomas Abraham<[email protected]>

nit: Typo in samsung. Probably something that Kukjin can fix up when applying, though.

Quoted 8 lines

---

Changes in V2:
* Rebased against linux-next tree.
* Removed un-used macros in regs-clock.h

Quoted 9 lines
Quoted 4 lines
  arch/arm/mach-exynos/cpuidle.c                 |   35 --------------------
  arch/arm/mach-exynos/include/mach/regs-clock.h |   16 ---------
  drivers/clk/samsung/clk-exynos5250.c           |   42 ++++++++++++++++++++++++
  3 files changed, 42 insertions(+), 51 deletions(-)

Otherwise

Mike, do you want me to pick this patch into Samsung tree?

- Kukjin

#3 lore raw

PATCH v2 1/1 ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

Quoting Kukjin Kim (2013-10-20 14:34:29)

Quoted 28 lines · Tomasz Figa
Quoted 27 lines

Hi Amit,

Quoted 7 lines · On Friday 11 of October 2013 11:12:14 Amit Daniel Kachhap wrote:

Now with common clock support added for exynos5250 it is necessary to move this code to exynos5250 common clock driver as clock registers should be handled there. This change is tested in exynos5250 based arndale platform.

Cc Abhilash Kesavan<[email protected]>
Cc Thomas Abraham<[email protected]>

nit: Typo in samsung. Probably something that Kukjin can fix up when applying, though.

Quoted 12 lines

---

Changes in V2:
* Rebased against linux-next tree.
* Removed un-used macros in regs-clock.h

  arch/arm/mach-exynos/cpuidle.c                 |   35 --------------------
  arch/arm/mach-exynos/include/mach/regs-clock.h |   16 ---------
  drivers/clk/samsung/clk-exynos5250.c           |   42 ++++++++++++++++++++++++
  3 files changed, 42 insertions(+), 51 deletions(-)
Quoted 5 lines
Quoted 4 lines

Otherwise

Mike, do you want me to pick this patch into Samsung tree?

I'll take it through clk-next.

Thanks,
Mike

Quoted 2 lines

- Kukjin