Skip to contentSkip to conversation

netfilter: skip checksum verification for outgoing rejected ipv6 packets

PATCH Superseded Stanislav Fomichev 3 participants 5 messages Oct 22, 2013 – Oct 23, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: skip checksum verification for outgoing rejected ipv6 packets

Don't verify checksum for outgoing packets because checksum calculation may be done by the device.

Without this patch:

$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection timed out
real    0m7.201s
user    0m0.000s
sys     0m0.000s

With the patch applied:

$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection refused
real    0m0.085s
user    0m0.000s
sys     0m0.000s
---
 net/ipv6/netfilter/ip6t_REJECT.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
net/ipv6/netfilter/ip6t_REJECT.c +5 -3
index 56eef30ee5f6..3ef2b834bca3 100644
@@ -39,7 +39,7 @@ MODULE_DESCRIPTION("Xtables: packet \"rejection\" target for IPv6");
 MODULE_LICENSE("GPL");
 
 /* Send RST reply */
-static void send_reset(struct net *net, struct sk_buff *oldskb)
+static void send_reset(struct net *net, struct sk_buff *oldskb, int hook)
 {
 	struct sk_buff *nskb;
 	struct tcphdr otcph, *tcph;
@@ -88,8 +88,10 @@ static void send_reset(struct net *net, struct sk_buff *oldskb)
 	}
 
 	/* Check checksum. */
-	if (csum_ipv6_magic(&oip6h->saddr, &oip6h->daddr, otcplen, IPPROTO_TCP,
+	if (hook != NF_INET_LOCAL_OUT &&
+	    csum_ipv6_magic(&oip6h->saddr, &oip6h->daddr, otcplen, IPPROTO_TCP,
 			    skb_checksum(oldskb, tcphoff, otcplen, 0))) {
+
 		pr_debug("TCP checksum is invalid\n");
 		return;
 	}
@@ -227,7 +229,7 @@ reject_tg6(struct sk_buff *skb, const struct xt_action_param *par)
 		/* Do nothing */
 		break;
 	case IP6T_TCP_RESET:
-		send_reset(net, skb);
+		send_reset(net, skb, par->hooknum);
 		break;
 	default:
 		net_info_ratelimited("case %u not handled yet\n", reject->with);
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw

net/ipv6/netfilter/ip6t_REJECT.c static void send_reset(struct net *net, struct sk_buff *oldskb) · line 93

Quoted 5 lines · Stanislav Fomichev
net/ipv6/netfilter/ip6t_REJECT.c +2 -1
 	/* Check checksum. */
-	if (csum_ipv6_magic(&oip6h->saddr, &oip6h->daddr, otcplen, IPPROTO_TCP,
+	if (hook != NF_INET_LOCAL_OUT &&
+	    csum_ipv6_magic(&oip6h->saddr, &oip6h->daddr, otcplen, IPPROTO_TCP,
 			    skb_checksum(oldskb, tcphoff, otcplen, 0))) {

Could you try using nf_ip6_checksum() here instead of csum_ipv6_magic()?

It has the advantage that it will also skip checksumming in case inbound packets have already been validated by hardware, etc.

Also this should do the right thing in any case (e.g. local packet in POST_ROUTING).

#2 lore raw
Quoted 1 line

Could you try using nf_ip6_checksum() here instead of csum_ipv6_magic()?

Yes, it works, at least on my checksumming HW. Will resend the patch.

Thanks

#3 lore raw

PATCH v2 1/1 netfilter: skip checksum verification for outgoing rejected ipv6 packets

In reply to Florian Westphal

Don't verify checksum for outgoing packets because checksum calculation may be done by the device.

Without this patch:

$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection timed out
real    0m7.201s
user    0m0.000s
sys     0m0.000s

With the patch applied:

$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection refused
real    0m0.085s
user    0m0.000s
sys     0m0.000s
---
 net/ipv6/netfilter/ip6t_REJECT.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
net/ipv6/netfilter/ip6t_REJECT.c +3 -4
index 70f9abc0efe9..0bf81ef80c90 100644
@@ -39,7 +39,7 @@ MODULE_DESCRIPTION("Xtables: packet \"rejection\" target for IPv6");
 MODULE_LICENSE("GPL");
 
 /* Send RST reply */
-static void send_reset(struct net *net, struct sk_buff *oldskb)
+static void send_reset(struct net *net, struct sk_buff *oldskb, int hook)
 {
 	struct sk_buff *nskb;
 	struct tcphdr otcph, *tcph;
@@ -88,8 +88,7 @@ static void send_reset(struct net *net, struct sk_buff *oldskb)
 	}
 
 	/* Check checksum. */
-	if (csum_ipv6_magic(&oip6h->saddr, &oip6h->daddr, otcplen, IPPROTO_TCP,
-			    skb_checksum(oldskb, tcphoff, otcplen, 0))) {
+	if (nf_ip6_checksum(oldskb, hook, tcphoff, IPPROTO_TCP)) {
 		pr_debug("TCP checksum is invalid\n");
 		return;
 	}
@@ -209,7 +208,7 @@ reject_tg6(struct sk_buff *skb, const struct xt_action_param *par)
 		/* Do nothing */
 		break;
 	case IP6T_TCP_RESET:
-		send_reset(net, skb);
+		send_reset(net, skb, par->hooknum);
 		break;
 	default:
 		net_info_ratelimited("case %u not handled yet\n", reject->with);
Signature · 1 line
1.8.1.2
maintainer Applied
#4 lore raw
Quoted 14 lines · Stanislav Fomichev

Don't verify checksum for outgoing packets because checksum calculation may be done by the device.

Without this patch:

$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection timed out
real    0m7.201s
user    0m0.000s
sys     0m0.000s

With the patch applied:

Quoted 8 lines
$ ip6tables -I OUTPUT -p tcp --dport 80 -j REJECT --reject-with tcp-reset
$ time telnet ipv6.google.com 80
Trying 2a00:1450:4010:c03::67...
telnet: Unable to connect to remote host: Connection refused
real    0m0.085s
user    0m0.000s
sys     0m0.000s

Applied to nf-next, thanks!