Skip to contentSkip to conversation

perf test failing for "sample parsing"

DISCUSSION Arnaldo Carvalho de Melo 2 participants 2 messages Oct 22, 2013 – Oct 23, 2013

lore
Share & tools
lore
#0 lore raw

Andi,

I should've caught this when processing those patches, but
please consider running 'perf test' before and after your future patch kits :-)

[root@sandy ~]# perf test 22
22: Test sample parsing : FAILED!
[root@sandy ~]# perf test -v 22
22: Test sample parsing :
--- start ---
sample format has changed - test needs updating
---- end ----
Test sample parsing: FAILED!
[root@sandy ~]#

So I bisected it down to:

commit fdfbbd07e91f8fe387140776f3fd94605f0c89e5
Author: Andi Kleen <[email protected]>
Date: Fri Sep 20 07:40:39 2013 -0700

perf: Add generic transaction flags

Add a generic qualifier for transaction events, as a new sample type that returns a flag word. This is particularly useful for qualifying aborts: to distinguish aborts which happen due to asynchronous events (like conflicts caused by another CPU) versus instructions that lead to an abort.

extern void perf_output_sample(struct perf_output_handle *handle,
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 009a655..da48837 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -136,8 +136,9 @@ enum perf_event_sample_format {
PERF_SAMPLE_WEIGHT = 1U << 14,
PERF_SAMPLE_DATA_SRC = 1U << 15,
PERF_SAMPLE_IDENTIFIER = 1U << 16,
+ PERF_SAMPLE_TRANSACTION = 1U << 17,

- PERF_SAMPLE_MAX = 1U << 17, /* non-ABI */
+ PERF_SAMPLE_MAX = 1U << 18, /* non-ABI */

--------------------------------------------------------------------------------------

So I looked at tools/perf/tests/builtin-test.c for the "Test sample parsing"
string and found the test__sample_parsing function, and fixed it there, patches sent to my perf/core branch.

This one was harmless, but there were problems that were caught
by running 'perf test' while writing patchkits,

Thanks,

- Arnaldo

#1 lore raw
Quoted 2 lines

This one was harmless, but there were problems that were caught
by running 'perf test' while writing patchkits,

Thanks for fixing. I'll run it in the future.

-Andi