Skip to contentSkip to conversation

drivers: staging: bcm: Removed a developer debug statement.

PATCH In review Chuong Ngo 3 participants 3 messages Oct 23, 2013 – Oct 29, 2013 Staging

lore
Share & tools
lore

Chuong Ngo

author
#0 lore raw

PATCH 1/1 drivers: staging: bcm: Removed a developer debug statement.

Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.

---
 drivers/staging/bcm/Bcmchar.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/bcm/Bcmchar.c +1 -4
index f91bc1f..41554c8 100644
@@ -49,11 +49,8 @@ static int bcm_char_release(struct inode *inode, struct file *filp)
 
 	pTarang = (struct bcm_tarang_data *)filp->private_data;
 
-	if (pTarang == NULL) {
-		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
-				"ptarang is null\n");
+	if (pTarang == NULL)
 		return 0;
-	}
 
 	Adapter = pTarang->Adapter;
 
Signature · 1 line
1.8.4.1
#1 lore raw
Quoted 1 line · Chuong Ngo

Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.

Line wrap the changelog at 72 characters. You don't really need to mention the removed braces because that's too obvious to bother commenting on.

My guess is that Greg will probably be willing to apply this as is so don't worry about resending unless he requests it. (He normally seems to let newbies get by with one line wrapping warning before he starts making you redo it).

regards,
dan carpenter

maintainer
#2 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 1 line · Chuong Ngo

Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.

Line wrap the changelog at 72 characters. You don't really need to mention the removed braces because that's too obvious to bother commenting on.

My guess is that Greg will probably be willing to apply this as is so don't worry about resending unless he requests it. (He normally seems to let newbies get by with one line wrapping warning before he starts making you redo it).

Yes, I'll fix it this time, but Chuong, please be more careful next time.

greg k-h