Skip to contentSkip to conversation

kernel/kallsyms.c: only show legal kernel symbol

RFC PATCH Applied Ming Lei 3 participants 18 messages Oct 23, 2013 – Nov 1, 2013 Kbuild

lore
Share & tools
lore

Ming Lei

author
#0 lore raw

RFC PATCH 1/1 kernel/kallsyms.c: only show legal kernel symbol

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

	00000000 t __vectors_start
	00000020 A cpu_v7_suspend_size
	00001000 t __stubs_start
	00001004 t vector_rst
	00001020 t vector_irq
	000010a0 t vector_dabt
	00001120 t vector_pabt
	000011a0 t vector_und
	00001220 t vector_addrexcptn
	00001224 t vector_fiq
	00001224 T vector_fiq_offset

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

Cc Russell King <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Rusty Russell <[email protected]>
Cc Chen Gang <[email protected]>
---
 kernel/kallsyms.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kallsyms.c +1 -1
index 3127ad5..184f271 100644
@@ -543,7 +543,7 @@ static int s_show(struct seq_file *m, void *p)
 					tolower(iter->type);
 		seq_printf(m, "%pK %c %s\t[%s]\n", (void *)iter->value,
 			   type, iter->name, iter->module_name);
-	} else
+	} else if (iter->value >= CONFIG_PAGE_OFFSET)
 		seq_printf(m, "%pK %c %s\n", (void *)iter->value,
 			   iter->type, iter->name);
 	return 0;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 20 lines · Ming Lei

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

	00000000 t __vectors_start
	00000020 A cpu_v7_suspend_size
	00001000 t __stubs_start
	00001004 t vector_rst
	00001020 t vector_irq
	000010a0 t vector_dabt
	00001120 t vector_pabt
	000011a0 t vector_und
	00001220 t vector_addrexcptn
	00001224 t vector_fiq
	00001224 T vector_fiq_offset
Quoted 2 lines

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

This fix looks hacky; if these symbols are not available, don't just remove them from /proc/kallsyms, but don't put them in the kernel at all.

That way, they won't interfere with other kallsyms uses (eg. backtrace).

Or, better, figure out a smart way of excluding them by knowing why these symbol addresses are wrong.

Thanks,
Rusty.

Quoted 24 lines
Cc Russell King <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Rusty Russell <[email protected]>
Cc Chen Gang <[email protected]>
---
 kernel/kallsyms.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kallsyms.c +1 -1
index 3127ad5..184f271 100644
@@ -543,7 +543,7 @@ static int s_show(struct seq_file *m, void *p)
 					tolower(iter->type);
 		seq_printf(m, "%pK %c %s\t[%s]\n", (void *)iter->value,
 			   type, iter->name, iter->module_name);
-	} else
+	} else if (iter->value >= CONFIG_PAGE_OFFSET)
 		seq_printf(m, "%pK %c %s\n", (void *)iter->value,
 			   iter->type, iter->name);
 	return 0;
Signature · 1 line
1.7.9.5
author
#2 lore raw
Quoted 21 lines · Rusty Russell
Quoted 20 lines · Ming Lei

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

      00000000 t __vectors_start
      00000020 A cpu_v7_suspend_size
      00001000 t __stubs_start
      00001004 t vector_rst
      00001020 t vector_irq
      000010a0 t vector_dabt
      00001120 t vector_pabt
      000011a0 t vector_und
      00001220 t vector_addrexcptn
      00001224 t vector_fiq
      00001224 T vector_fiq_offset
Quoted 8 lines
Quoted 2 lines

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

This fix looks hacky; if these symbols are not available, don't just remove them from /proc/kallsyms, but don't put them in the kernel at all.

That way, they won't interfere with other kallsyms uses (eg. backtrace).

Yes, I agree.

Quoted 2 lines

Or, better, figure out a smart way of excluding them by knowing why these symbol addresses are wrong.

Actually the problem is caused by commit b9b32bf70f2(ARM: use linker magic for vectors and vector stubs), maybe Russell can figure out a smart way to exclude these symbols.

Thanks,

Signature · 1 line
Ming Lei
#3 lore raw
In reply to Rusty Russell
Quoted 21 lines · Rusty Russell
Quoted 20 lines · Ming Lei

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

	00000000 t __vectors_start
	00000020 A cpu_v7_suspend_size
	00001000 t __stubs_start
	00001004 t vector_rst
	00001020 t vector_irq
	000010a0 t vector_dabt
	00001120 t vector_pabt
	000011a0 t vector_und
	00001220 t vector_addrexcptn
	00001224 t vector_fiq
	00001224 T vector_fiq_offset
Quoted 6 lines
Quoted 2 lines

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

This fix looks hacky; if these symbols are not available, don't just remove them from /proc/kallsyms, but don't put them in the kernel at all.

How do you "don't put them in the kernel at all" when they're used by the kernel internally as offsets?

If you mean, just get rid of them, shall I just add these as magic numbers instead based on the values in this email? Is that really a sane solution?

No, we have to keep these symbols IMHO.

author
#4 lore raw
Quoted 29 lines · Russell King - ARM Linux
Quoted 21 lines · Rusty Russell
Quoted 20 lines · Ming Lei

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

    00000000 t __vectors_start
    00000020 A cpu_v7_suspend_size
    00001000 t __stubs_start
    00001004 t vector_rst
    00001020 t vector_irq
    000010a0 t vector_dabt
    00001120 t vector_pabt
    000011a0 t vector_und
    00001220 t vector_addrexcptn
    00001224 t vector_fiq
    00001224 T vector_fiq_offset
Quoted 6 lines
Quoted 2 lines

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

This fix looks hacky; if these symbols are not available, don't just remove them from /proc/kallsyms, but don't put them in the kernel at all.

Quoted 8 lines

How do you "don't put them in the kernel at all" when they're used by the kernel internally as offsets?

If you mean, just get rid of them, shall I just add these as magic numbers instead based on the values in this email? Is that really a sane solution?

No, we have to keep these symbols IMHO.

If so, looks we have to hide them to userspace, so the patch should be OK because the approach is correct and no obvious side-effect.

Thanks,

Signature · 1 line
Ming Lei
#5 lore raw
In reply to Russell King - ARM Linux
Quoted 25 lines · Russell King - ARM Linux
Quoted 24 lines · Rusty Russell
Quoted 22 lines · Ming Lei

Address of non-module kernel symbol should always be located from CONFIG_PAGE_OFFSET on, so only show these legal kernel symbols in /proc/kallsyms.

On ARM, some symbols(see below) may drop in relocatable code, so perf can't parse kernel symbols any more from /proc/kallsyms, this patch fixes the problem.

	00000000 t __vectors_start
	00000020 A cpu_v7_suspend_size
	00001000 t __stubs_start
	00001004 t vector_rst
	00001020 t vector_irq
	000010a0 t vector_dabt
	00001120 t vector_pabt
	000011a0 t vector_und
	00001220 t vector_addrexcptn
	00001224 t vector_fiq
	00001224 T vector_fiq_offset

The issue can be fixed in scripts/kallsyms.c too, but looks this approach is easier.

Quoted 6 lines
Quoted 3 lines

This fix looks hacky; if these symbols are not available, don't just remove them from /proc/kallsyms, but don't put them in the kernel at all.

How do you "don't put them in the kernel at all" when they're used by the kernel internally as offsets?

Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left them in the the kallsyms tables and filtered them out from /proc/kallsyms.

It's weird that cpu_v7_suspend_size appeared above, since kallsyms should filter out 'A' symbols already.

Quoted 5 lines

If you mean, just get rid of them, shall I just add these as magic numbers instead based on the values in this email? Is that really a sane solution?

No, we have to keep these symbols IMHO.

Can you make them absolute symbols? That should Just Work for kallsyms.

Cheers,
Rusty.

author
#6 lore raw
Quoted 4 lines · Rusty Russell

Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left them in the the kallsyms tables and filtered them out from /proc/kallsyms.

Yes, but it isn't easy to do it by script/kallsyms.c , and IMO, it should be correct to hide them for user space but keep them in kallsyms table.

Quoted 3 lines

It's weird that cpu_v7_suspend_size appeared above, since kallsyms should filter out 'A' symbols already.

Sorry, the 'A' symbol is a mistake, but the others do exist in /proc/kallsyms.

Thanks,

Signature · 1 line
Ming Lei
#7 lore raw
Quoted 8 lines · Ming Lei
Quoted 4 lines · Rusty Russell

Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left them in the the kallsyms tables and filtered them out from /proc/kallsyms.

Yes, but it isn't easy to do it by script/kallsyms.c , and IMO, it should be correct to hide them for user space but keep them in kallsyms table.

So they'll appear in backtraces? And turn up randomly for other symbol dereferences?

I don't think you really want this!

Quoted 4 lines
Quoted 2 lines

It's weird that cpu_v7_suspend_size appeared above, since kallsyms should filter out 'A' symbols already.

Sorry, the 'A' symbol is a mistake, but the others do exist in /proc/kallsyms.

Ah, OK.

Cheers,
Rusty.

author
#8 lore raw
Quoted 7 lines · Rusty Russell
Quoted 6 lines · Ming Lei
Quoted 4 lines · Rusty Russell

Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left them in the the kallsyms tables and filtered them out from /proc/kallsyms.

Quoted 7 lines
Quoted 2 lines

Yes, but it isn't easy to do it by script/kallsyms.c , and IMO, it should be correct to hide them for user space but keep them in kallsyms table.

So they'll appear in backtraces? And turn up randomly for other symbol dereferences?

I don't think you really want this!

Basically these symbols are only used to generate code, and in kernel mode, CPU won't run into the corresponding addresses because the generate code is copied to other address during booting, so I understand they won't appear in backtraces.

Thanks,

Signature · 1 line
Ming Lei
#9 lore raw
Quoted 14 lines · Ming Lei
Quoted 13 lines · Rusty Russell
Quoted 8 lines · Ming Lei
Quoted 4 lines · Rusty Russell

Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left them in the the kallsyms tables and filtered them out from /proc/kallsyms.

Yes, but it isn't easy to do it by script/kallsyms.c , and IMO, it should be correct to hide them for user space but keep them in kallsyms table.

So they'll appear in backtraces? And turn up randomly for other symbol dereferences?

Quoted 6 lines
Quoted 1 line

I don't think you really want this!

Basically these symbols are only used to generate code, and in kernel mode, CPU won't run into the corresponding addresses because the generate code is copied to other address during booting, so I understand they won't appear in backtraces.

An oops occurs when something went *wrong*. We look up all kinds of stuff. Are you so sure that *none* of the callers will ever see these strange symbols and produce a confusing result?

Cheers,
Rusty.

author
#10 lore raw
Quoted 9 lines · Rusty Russell
Quoted 5 lines

Basically these symbols are only used to generate code, and in kernel mode, CPU won't run into the corresponding addresses because the generate code is copied to other address during booting, so I understand they won't appear in backtraces.

An oops occurs when something went *wrong*. We look up all kinds of stuff. Are you so sure that *none* of the callers will ever see these strange symbols and produce a confusing result?

Suppose that might happen, kernel should be smart enough to know that the address is not inside kernel address space and won't produce confusing result, right?

Thanks,

Signature · 1 line
Ming Lei
#11 lore raw
Quoted 7 lines · Ming Lei
Quoted 6 lines · Rusty Russell
Quoted 5 lines

Basically these symbols are only used to generate code, and in kernel mode, CPU won't run into the corresponding addresses because the generate code is copied to other address during booting, so I understand they won't appear in backtraces.

Quoted 7 lines
Quoted 3 lines

An oops occurs when something went *wrong*. We look up all kinds of stuff. Are you so sure that *none* of the callers will ever see these strange symbols and produce a confusing result?

Suppose that might happen, kernel should be smart enough to know that the address is not inside kernel address space and won't produce confusing result, right?

I don't know... It would be your job, as the person making the change, to find all the users of kallsyms and prove that.

This is why it is easier not to include incorrect values in the kernel's kallsyms in the first place.

Hope that helps,
Rusty.

author
#12 lore raw
Quoted 7 lines · On Mon, 28 Oct 2013 13:44:30 +1030 Rusty Russell <[email protected]> wrote:

Ming Lei <[email protected]> writes:

I don't know... It would be your job, as the person making the change, to find all the users of kallsyms and prove that.

This is why it is easier not to include incorrect values in the kernel's kallsyms in the first place.

OK, thanks for your comment, and I figured out one way to do it in scripts/kallsyms.c, could you comment on below patch?

--

Quoted 1 line

From 4327534dedfa60d208ac3e23db7556c243e1c7dc Mon Sep 17 00:00:00 2001

From: Ming Lei <[email protected]>
Date: Mon, 28 Oct 2013 13:04:49 +0800
Subject: [PATCH] scripts/kallsyms: filter symbols not in kernel address space

This patch uses CONFIG_PAGE_OFFSET to filter symbols which are not in kernel address space because these symbols are generally for generating code purpose and can't be run at kernel mode, so we needn't keep them in /proc/kallsyms.

For example, on ARM there are some symbols which may be linked in relocatable code section, then perf can't parse symbols any more from /proc/kallsyms, this patch fixes the problem.

Cc Russell King <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Rusty Russell <[email protected]>
Cc Michal Marek <[email protected]>
---
 scripts/kallsyms.c      |   12 +++++++++++-
 scripts/link-vmlinux.sh |    2 ++
 2 files changed, 13 insertions(+), 1 deletion(-)
scripts/kallsyms.c +11 -1
index 487ac6f..9a11f9f 100644
@@ -55,6 +55,7 @@ static struct sym_entry *table;
 static unsigned int table_size, table_cnt;
 static int all_symbols = 0;
 static char symbol_prefix_char = '\0';
+static unsigned long long kernel_start_addr = 0;
 
 int token_profit[0x10000];
 
@@ -65,7 +66,10 @@ unsigned char best_table_len[256];
 
 static void usage(void)
 {
-	fprintf(stderr, "Usage: kallsyms [--all-symbols] [--symbol-prefix=<prefix char>] < in.map > out.S\n");
+	fprintf(stderr, "Usage: kallsyms [--all-symbols] "
+			"[--symbol-prefix=<prefix char>] "
+			"[--page-offset=<CONFIG_PAGE_OFFSET>] "
+			"< in.map > out.S\n");
 	exit(1);
 }
 
@@ -194,6 +198,9 @@ static int symbol_valid(struct sym_entry *s)
 	int i;
 	int offset = 1;
 
+	if (s->addr < kernel_start_addr)
+		return 0;
+
 	/* skip prefix char */
 	if (symbol_prefix_char && *(s->sym + 1) == symbol_prefix_char)
 		offset++;
@@ -646,6 +653,9 @@ int main(int argc, char **argv)
 				if ((*p == '"' && *(p+2) == '"') || (*p == '\'' && *(p+2) == '\''))
 					p++;
 				symbol_prefix_char = *p;
+			} else if (strncmp(argv[i], "--page-offset=", 14) == 0) {
+				const char *p = &argv[i][14];
+				kernel_start_addr = strtoull(p, NULL, 16);
 			} else
 				usage();
 		}
scripts/link-vmlinux.sh +2 -0
index 0149949..32b10f5 100644
@@ -82,6 +82,8 @@ kallsyms()
 		kallsymopt="${kallsymopt} --all-symbols"
 	fi
 
+	kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET"
+
 	local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL}               \
 		      ${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}"
 
Signature · 8 lines
1.7.9.5




Thanks,
-- 
Ming Lei
Acked-by
#13 lore raw
Quoted 5 lines · Ming Lei
Quoted 2 lines · On Mon, 28 Oct 2013 13:44:30 +1030 Rusty Russell <[email protected]> wrote:

Ming Lei <[email protected]> writes:

Quoted 8 lines
Quoted 5 lines

I don't know... It would be your job, as the person making the change, to find all the users of kallsyms and prove that.

This is why it is easier not to include incorrect values in the kernel's kallsyms in the first place.

OK, thanks for your comment, and I figured out one way to do it in scripts/kallsyms.c, could you comment on below patch?

Looks great! Seems like we spent more time arguing than it took you to code that up.

Russell, this seems logical for you to take along with the changes which caused the problem?

Thanks,
Rusty.

Quoted 92 lines

--
From 4327534dedfa60d208ac3e23db7556c243e1c7dc Mon Sep 17 00:00:00 2001
From: Ming Lei <[email protected]>
Date: Mon, 28 Oct 2013 13:04:49 +0800
Subject: [PATCH] scripts/kallsyms: filter symbols not in kernel address space

This patch uses CONFIG_PAGE_OFFSET to filter symbols which are not in kernel address space because these symbols are generally for generating code purpose and can't be run at kernel mode, so we needn't keep them in /proc/kallsyms.

For example, on ARM there are some symbols which may be linked in relocatable code section, then perf can't parse symbols any more from /proc/kallsyms, this patch fixes the problem.

Cc Russell King <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Rusty Russell <[email protected]>
Cc Michal Marek <[email protected]>
---
 scripts/kallsyms.c      |   12 +++++++++++-
 scripts/link-vmlinux.sh |    2 ++
 2 files changed, 13 insertions(+), 1 deletion(-)
scripts/kallsyms.c +11 -1
index 487ac6f..9a11f9f 100644
@@ -55,6 +55,7 @@ static struct sym_entry *table;
 static unsigned int table_size, table_cnt;
 static int all_symbols = 0;
 static char symbol_prefix_char = '\0';
+static unsigned long long kernel_start_addr = 0;
 
 int token_profit[0x10000];
 
@@ -65,7 +66,10 @@ unsigned char best_table_len[256];
 
 static void usage(void)
 {
-	fprintf(stderr, "Usage: kallsyms [--all-symbols] [--symbol-prefix=<prefix char>] < in.map > out.S\n");
+	fprintf(stderr, "Usage: kallsyms [--all-symbols] "
+			"[--symbol-prefix=<prefix char>] "
+			"[--page-offset=<CONFIG_PAGE_OFFSET>] "
+			"< in.map > out.S\n");
 	exit(1);
 }
 
@@ -194,6 +198,9 @@ static int symbol_valid(struct sym_entry *s)
 	int i;
 	int offset = 1;
 
+	if (s->addr < kernel_start_addr)
+		return 0;
+
 	/* skip prefix char */
 	if (symbol_prefix_char && *(s->sym + 1) == symbol_prefix_char)
 		offset++;
@@ -646,6 +653,9 @@ int main(int argc, char **argv)
 				if ((*p == '"' && *(p+2) == '"') || (*p == '\'' && *(p+2) == '\''))
 					p++;
 				symbol_prefix_char = *p;
+			} else if (strncmp(argv[i], "--page-offset=", 14) == 0) {
+				const char *p = &argv[i][14];
+				kernel_start_addr = strtoull(p, NULL, 16);
 			} else
 				usage();
 		}
scripts/link-vmlinux.sh +2 -0
index 0149949..32b10f5 100644
@@ -82,6 +82,8 @@ kallsyms()
 		kallsymopt="${kallsymopt} --all-symbols"
 	fi
 
+	kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET"
+
 	local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL}               \
 		      ${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}"
 
Signature · 8 lines
1.7.9.5




Thanks,
-- 
Ming Lei
#14 lore raw
Quoted 15 lines · Rusty Russell
Quoted 5 lines · Ming Lei
Quoted 2 lines · On Mon, 28 Oct 2013 13:44:30 +1030 Rusty Russell <[email protected]> wrote:

Ming Lei <[email protected]> writes:

Quoted 8 lines
Quoted 5 lines

I don't know... It would be your job, as the person making the change, to find all the users of kallsyms and prove that.

This is why it is easier not to include incorrect values in the kernel's kallsyms in the first place.

OK, thanks for your comment, and I figured out one way to do it in scripts/kallsyms.c, could you comment on below patch?

Quoted 7 lines

Looks great! Seems like we spent more time arguing than it took you to code that up.

Russell, this seems logical for you to take along with the changes which caused the problem?

The changes are already in mainline since a long time (back in July/August time). Am I the right person to take stuff for scripts/ ? Isn't that more kbuild territory?

#15 lore raw
Quoted 19 lines · Russell King - ARM Linux
Quoted 18 lines · Rusty Russell
Quoted 5 lines · Ming Lei
Quoted 2 lines · On Mon, 28 Oct 2013 13:44:30 +1030 Rusty Russell <[email protected]> wrote:

Ming Lei <[email protected]> writes:

Quoted 8 lines
Quoted 5 lines

I don't know... It would be your job, as the person making the change, to find all the users of kallsyms and prove that.

This is why it is easier not to include incorrect values in the kernel's kallsyms in the first place.

OK, thanks for your comment, and I figured out one way to do it in scripts/kallsyms.c, could you comment on below patch?

Looks great! Seems like we spent more time arguing than it took you to code that up.

Quoted 8 lines
Quoted 4 lines

Russell, this seems logical for you to take along with the changes which caused the problem?

The changes are already in mainline since a long time (back in July/August time). Am I the right person to take stuff for scripts/ ? Isn't that more kbuild territory?

Kallsyms tends to fall between modules and scripts. I assume it's not urgent, so no cc:stable on this one.

Applied,
Rusty.

#17 lore raw
Quoted 11 lines · Ming Lei
Quoted 4 lines · Rusty Russell

Russell King - ARM Linux <[email protected]> writes:

Kallsyms tends to fall between modules and scripts. I assume it's not urgent, so no cc:stable on this one.

Rusty, thanks a lot.

BTW, there is already other report on the problem:

   http://lkml.indiana.edu/hypermail/linux/kernel/1310.3/02772.html

OK, *that* references the commit which is the problem, when went into v3.11 (b9b32bf70f2fb710b07c94e13afbc729afe221da)

Unfortunately, *that commit* was cc:stable, so this needs to be cc:stable as well, not just >= 3.11.

Looking back on those patches, there's a mass of cc:stable on them. The descriptions are either misleading, or these patches prevent theoretical attacks which means they shouldn't have been cc:stable.

Grr...
Rusty.