Skip to contentSkip to conversation

self assignment bug in aix94xx

DISCUSSION Dave Jones 2 participants 2 messages Oct 24, 2013 SCSI

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

2908d778 (James Bottomley 2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count;

Is this supposed to maybe be..

	scb->ssp_task.retry_count = task->ssp_task.retry_count;

?

(This and a whole bunch of similar bugs found with Coverity.)

Dave

maintainer
#1 lore raw
Quoted 7 lines · Dave Jones

2908d778 (James Bottomley 2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count;

Is this supposed to maybe be..

	scb->ssp_task.retry_count = task->ssp_task.retry_count;

?

Oh, boy, this was the master commit for aic94xx (so it's not me it was a bunch of people working on the driver). I'll see if I can analyse the logic flow to find out what should have been going on, but it will take a couple of weeks.

Quoted 1 line

(This and a whole bunch of similar bugs found with Coverity.)

May as well send them along and I'll look at them too.

James

Quoted 6 lines

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html