Skip to contentSkip to conversation

xfstests btrfs/020: test device replace on RO btrfs

PATCH Superseded Eryu Guan 6 participants 10 messages Oct 23, 2013 – Oct 24, 2013 Btrfs file system

lore
Share & tools
lore

Eryu Guan

author
#0 lore raw

PATCH 1/1 xfstests btrfs/020: test device replace on RO btrfs

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

---
 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +84 -0
new file mode 100755
index 0000000..cd16dc0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+
+rm -f $seqres.full
+echo "Silence is golden"
+
+loop_mnt=$TEST_DIR/$seq.$$.mnt
+fs_img1=$TEST_DIR/$seq.$$.img1
+fs_img2=$TEST_DIR/$seq.$$.img2
+fs_img3=$TEST_DIR/$seq.$$.img3
+mkdir $loop_mnt
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img1 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img2 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img3 >>$seqres.full 2>&1
+
+loop_dev1=`_create_loop_device $fs_img1`
+loop_dev2=`_create_loop_device $fs_img2`
+loop_dev3=`_create_loop_device $fs_img3`
+
+$MKFS_BTRFS_PROG -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1
+$MOUNT_PROG -o ro $loop_dev1 $loop_mnt
+
+# Fail the second device and replace with the third
+_destroy_loop_device $loop_dev2
+$BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \
+_fail "FAIL: Device replaced on RO btrfs"
+
+status=0
+exit
tests/btrfs/020.out new file +2 -0
new file mode 100644
index 0000000..20d7944
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
tests/btrfs/group +1 -0
index 2f74139..1159499 100644
@@ -22,3 +22,4 @@
 017 auto quick
 018 auto quick
 019 auto quick
+020 auto quick
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 6 lines · Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

Could you speed this up by just truncating the loop files to 256m, rather than writing 256m to each (for a total of 768m IO?)

Also: thanks for including the commit it's testing, that kind of thing will be super helpful down the line.

-Eric

Quoted 116 lines
---
 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +84 -0
new file mode 100755
index 0000000..cd16dc0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+
+rm -f $seqres.full
+echo "Silence is golden"
+
+loop_mnt=$TEST_DIR/$seq.$$.mnt
+fs_img1=$TEST_DIR/$seq.$$.img1
+fs_img2=$TEST_DIR/$seq.$$.img2
+fs_img3=$TEST_DIR/$seq.$$.img3
+mkdir $loop_mnt
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img1 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img2 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "pwrite 0 256m" $fs_img3 >>$seqres.full 2>&1
+
+loop_dev1=`_create_loop_device $fs_img1`
+loop_dev2=`_create_loop_device $fs_img2`
+loop_dev3=`_create_loop_device $fs_img3`
+
+$MKFS_BTRFS_PROG -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1
+$MOUNT_PROG -o ro $loop_dev1 $loop_mnt
+
+# Fail the second device and replace with the third
+_destroy_loop_device $loop_dev2
+$BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \
+_fail "FAIL: Device replaced on RO btrfs"
+
+status=0
+exit
tests/btrfs/020.out new file +2 -0
new file mode 100644
index 0000000..20d7944
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
tests/btrfs/group +1 -0
index 2f74139..1159499 100644
@@ -22,3 +22,4 @@
 017 auto quick
 018 auto quick
 019 auto quick
+020 auto quick
author
#2 lore raw
Quoted 10 lines · Eric Sandeen
Quoted 6 lines · Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

Could you speed this up by just truncating the loop files to 256m, rather than writing 256m to each (for a total of 768m IO?)

Sure, and that does save much time, 7s -> 1s on my test box.

V2 will be coming soon.

Thanks for the review!

Eryu

author
#3 lore raw

PATCH v2 1/1 xfstests btrfs/020: test device replace on RO btrfs

In reply to Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

---
v2: Address Eric's review
- use truncate to create fs image instead of writing to each file

 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +84 -0
new file mode 100755
index 0000000..7464bd0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+
+rm -f $seqres.full
+echo "Silence is golden"
+
+loop_mnt=$TEST_DIR/$seq.$$.mnt
+fs_img1=$TEST_DIR/$seq.$$.img1
+fs_img2=$TEST_DIR/$seq.$$.img2
+fs_img3=$TEST_DIR/$seq.$$.img3
+mkdir $loop_mnt
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img1 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img2 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img3 >>$seqres.full 2>&1
+
+loop_dev1=`_create_loop_device $fs_img1`
+loop_dev2=`_create_loop_device $fs_img2`
+loop_dev3=`_create_loop_device $fs_img3`
+
+$MKFS_BTRFS_PROG -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1
+$MOUNT_PROG -o ro $loop_dev1 $loop_mnt
+
+# Fail the second device and replace with the third
+_destroy_loop_device $loop_dev2
+$BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \
+_fail "FAIL: Device replaced on RO btrfs"
+
+status=0
+exit
tests/btrfs/020.out new file +2 -0
new file mode 100644
index 0000000..20d7944
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
tests/btrfs/group +1 -0
index 2f74139..1159499 100644
@@ -22,3 +22,4 @@
 017 auto quick
 018 auto quick
 019 auto quick
+020 auto quick
Signature · 1 line
1.8.3.1
#4 lore raw
Quoted 70 lines · Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

---
v2: Address Eric's review
- use truncate to create fs image instead of writing to each file

 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +47 -0
new file mode 100755
index 0000000..7464bd0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}

tests/btrfs/020 line 57

Quoted 10 lines
tests/btrfs/020 new file +10 -0
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux

It is still unclear to me why everybody adds this "_supported_os Linux" to the Btrfs tests. Is it because loop devices are used in this particular test btrfs/020 or is it because of Btrfs itself? tests/btrfs/001..010 and tests/btrfs/012..020 contain the "_supported_os Linux".

Quoted 28 lines
tests/btrfs/020 new file +27 -0
+
+rm -f $seqres.full
+echo "Silence is golden"
+
+loop_mnt=$TEST_DIR/$seq.$$.mnt
+fs_img1=$TEST_DIR/$seq.$$.img1
+fs_img2=$TEST_DIR/$seq.$$.img2
+fs_img3=$TEST_DIR/$seq.$$.img3
+mkdir $loop_mnt
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img1 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img2 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img3 >>$seqres.full 2>&1
+
+loop_dev1=`_create_loop_device $fs_img1`
+loop_dev2=`_create_loop_device $fs_img2`
+loop_dev3=`_create_loop_device $fs_img3`
+
+$MKFS_BTRFS_PROG -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1
+$MOUNT_PROG -o ro $loop_dev1 $loop_mnt
+
+# Fail the second device and replace with the third
+_destroy_loop_device $loop_dev2
+$BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \
+_fail "FAIL: Device replaced on RO btrfs"
+
+status=0
+exit
tests/btrfs/020.out +0 -0

[...]

#5 lore raw
Quoted 79 lines · Stefan Behrens
Quoted 78 lines · Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

---
v2: Address Eric's review
- use truncate to create fs image instead of writing to each file

 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +55 -0
new file mode 100755
index 0000000..7464bd0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
Quoted 8 lines

tests/btrfs/020 line 57

Quoted 2 lines
tests/btrfs/020 new file +2 -0
+_supported_fs btrfs
+_supported_os Linux

It is still unclear to me why everybody adds this "_supported_os Linux" to the Btrfs tests. Is it because loop devices are used in this particular test btrfs/020 or is it because of Btrfs itself? tests/btrfs/001..010 and tests/btrfs/012..020 contain the "_supported_os Linux".

Historically xfstests could be run on IRIX & Linux, so some tests needed to differentiate for the capabilities of the OS.

We could probably look at how _supported_os works, and make sure that if it's absent, it means "no OS restrictions" and document it as such.

"_supported_fs btrfs" is probably sufficient to know that we can run this test; if btrfs is ever ported to, say, Solaris, it *should* run there too. ;)

-Eric

#6 lore raw
Quoted 12 lines · Eric Sandeen
Quoted 10 lines · Stefan Behrens

tests/btrfs/020 line 57

Quoted 3 lines · Eryu Guan
tests/btrfs/020 new file +3 -0
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux

It is still unclear to me why everybody adds this "_supported_os Linux" to the Btrfs tests. Is it because loop devices are used in this particular test btrfs/020 or is it because of Btrfs itself? tests/btrfs/001..010 and tests/btrfs/012..020 contain the "_supported_os Linux".

Quoted 5 lines

Historically xfstests could be run on IRIX & Linux, so some tests needed to differentiate for the capabilities of the OS.

We could probably look at how _supported_os works, and make sure that if it's absent, it means "no OS restrictions" and document it as such.

It already does work this way. If you don't add it, then the test will always run.

However, it also has the documentation factor of saying "we expect this to work on Linux's btrfs implementation *only*". IOWs, it's good practice to add the _supported_os field as xfstests is not designed to be Linux specific....

Quoted 2 lines

"_supported_fs btrfs" is probably sufficient to know that we can run this test; if btrfs is ever ported to, say, Solaris, it *should* run there too. ;)

Unless, of course, there are differences in implementation, which there would be given that, for example, Solaris handles devices significantly differently to Linux. :)

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
Reviewed-by on v2 1/1
#7 lore raw
In reply to Eryu Guan
Quoted 6 lines · Eryu Guan

btrfs replace on readonly fs should not be allowed.

Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems

Quoted 119 lines

---
v2: Address Eric's review
- use truncate to create fs image instead of writing to each file

 tests/btrfs/020     | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/020.out |  2 ++
 tests/btrfs/group   |  1 +
 3 files changed, 87 insertions(+)
 create mode 100755 tests/btrfs/020
 create mode 100644 tests/btrfs/020.out
tests/btrfs/020 new file +84 -0
new file mode 100755
index 0000000..7464bd0
@@ -0,0 +1,84 @@
+#! /bin/bash
+# FS QA Test No. btrfs/020
+#
+# btrfs device replace test on RO fs
+#
+# Regression test for commit:
+# bbb651e Btrfs: don't allow the replace procedure on read only filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1	# failure is the default!
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+
+rm -f $seqres.full
+echo "Silence is golden"
+
+loop_mnt=$TEST_DIR/$seq.$$.mnt
+fs_img1=$TEST_DIR/$seq.$$.img1
+fs_img2=$TEST_DIR/$seq.$$.img2
+fs_img3=$TEST_DIR/$seq.$$.img3
+mkdir $loop_mnt
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img1 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img2 >>$seqres.full 2>&1
+$XFS_IO_PROG -f -c "truncate 256m" $fs_img3 >>$seqres.full 2>&1
+
+loop_dev1=`_create_loop_device $fs_img1`
+loop_dev2=`_create_loop_device $fs_img2`
+loop_dev3=`_create_loop_device $fs_img3`
+
+$MKFS_BTRFS_PROG -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1
+$MOUNT_PROG -o ro $loop_dev1 $loop_mnt
+
+# Fail the second device and replace with the third
+_destroy_loop_device $loop_dev2
+$BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \
+_fail "FAIL: Device replaced on RO btrfs"
+
+status=0
+exit
tests/btrfs/020.out new file +2 -0
new file mode 100644
index 0000000..20d7944
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
tests/btrfs/group +1 -0
index 2f74139..1159499 100644
@@ -22,3 +22,4 @@
 017 auto quick
 018 auto quick
 019 auto quick
+020 auto quick
#8 lore raw
In reply to Eryu Guan

tests/btrfs/020 line 39

Quoted 3 lines · Eryu Guan
tests/btrfs/020 new file +3 -0
+_cleanup()
+{
+	cd /

Using root as temporary directory?

Quoted 8 lines
tests/btrfs/020 new file +8 -0
+	rm -f $tmp.*
+	$UMOUNT_PROG $loop_mnt
+	_destroy_loop_device $loop_dev1
+	losetup -d $loop_dev2 >/dev/null 2>&1
+	_destroy_loop_device $loop_dev3
+	rm -rf $loop_mnt
+	rm -f $fs_img1 $fs_img2 $fs_img3
+}