Skip to contentSkip to conversation

Input: tsc2007: Add device tree support.

PATCH Superseded Denis Carikli 6 participants 12 messages Oct 24, 2013 – Nov 4, 2013

Subsystems (5)

v7 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +45 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
+
+Optional properties:
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).
+- interrupt-parent: the phandle for the gpio controller
+  (see interrupt binding[1]).
+- interrupts: (gpio) interrupt to which the chip is connected
+  (see interrupt binding[1]).
+- pinctrl-0: Should specify pin control groups used for the gpio
+  (see pinctrl bindings[0]).
+- pinctrl-names: Should contain only one value - "default"
+  (see pinctrl bindings[0]).
+- ti,max-rt: maximum pressure.
+- ti,fuzzy: specifies the absolute input fuzz value.
+  If set, it will permit noise in the data up to +- the value given to the fuzz
+  parameter, that is used to filter noise from the event stream.
+- ti,poll-period: how much time to wait(in millisecond) before reading again the
+  values from the tsc2007.
+
+[0]: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
+[1]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+[2]: Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+	&i2c1 {
+		/* ... */
+		tsc2007 at 49 {
+			compatible = "ti,tsc2007";
+			reg = <0x49>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_tsc2007_1>;
+			interrupt-parent = <&gpio4>;
+			interrupts = <0x0 0x8>;
+			gpios = <&gpio4 0 0>;
+			ti,x-plate-ohms = <180>;
+		};
+
+		/* ... */
+	};
drivers/input/touchscreen/tsc2007.c +153 -41

301 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v7 2/4 ARM: dts: cpuimx51 Add touchscreen support.

Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>
---
 arch/arm/boot/dts/imx51-eukrea-cpuimx51.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx51-eukrea-cpuimx51.dtsi +11 -0
index 8638656..34ca8d3a 100644
@@ -42,6 +42,17 @@
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;
 	};
+
+	tsc2007: tsc2007 at 49 {
+		compatible = "ti,tsc2007";
+		reg = <0x49>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_tsc2007_1>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <0x0 0x8>;
+		gpios = <&gpio4 0 0>;
+		ti,x-plate-ohms = <180>;
+	};
 };
 
 &iomuxc {
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v7 3/4 ARM: dts: cpuimx35 Add touchscreen support.

In reply to Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>
---
 arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi +11 -0
index 2c2d4cd..a22230b 100644
@@ -41,6 +41,17 @@
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;
 	};
+
+	tsc2007: tsc2007 at 48 {
+		compatible = "ti,tsc2007";
+		reg = <0x48>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_tsc2007_1>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <0x2 0x8>;
+		gpios = <&gpio3 2 0>;
+		ti,x-plate-ohms = <180>;
+	};
 };
 
 &iomuxc {
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH v7 4/4 ARM: imx_v6_v7_defconfig: Enable tsc2007 support.

In reply to Denis Carikli

The eukrea cpuimx35 and cpuimx51 have a tsc2007 touchscreen controller,
so we turn it on.

Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Eric B?nard <[email protected]>
---
 arch/arm/configs/imx_v6_v7_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index d8a52a0..23ba17d 100644
@@ -130,6 +130,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_INPUT_TOUCHSCREEN=y
 CONFIG_TOUCHSCREEN_EGALAX=y
 CONFIG_TOUCHSCREEN_MC13783=y
+CONFIG_TOUCHSCREEN_TSC2007=y
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_MMA8450=y
 CONFIG_SERIO_SERPORT=m
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

In reply to Denis Carikli
Quoted 38 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +8 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
+
+Optional properties:

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +10 -0
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).
+- interrupt-parent: the phandle for the gpio controller
+  (see interrupt binding[1]).
+- interrupts: (gpio) interrupt to which the chip is connected
+  (see interrupt binding[1]).
+- pinctrl-0: Should specify pin control groups used for the gpio
+  (see pinctrl bindings[0]).
+- pinctrl-names: Should contain only one value - "default"
+  (see pinctrl bindings[0]).

Also I haven't seen a response as to why this can't be handled by the GPIO driver. Adding Linus Walleij, perhaps he knows a more definitive answer.

Linus, the issue here is that the pinctrl properties for this chip are supposed to pinmux the pendown GPIO for this chip. I was under the impression that this should be handled by the GPIO controller itself, so that when gpio_request() was called on a pin it would be the GPIO controller driver's responsibility to pinmux it appropriately.

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 22

Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +4 -0
+- ti,max-rt: maximum pressure.
+- ti,fuzzy: specifies the absolute input fuzz value.
+  If set, it will permit noise in the data up to +- the value given to the fuzz
+  parameter, that is used to filter noise from the event stream.

Any reason why these can't be specified per axis? From my experience with this chip it can make sense to use different values for the different axes. Well, perhaps X and Y axes can share one fuzz factor, but the Z axis is sometimes different.

You also modify the driver to ignore the X and Z axes fuzz factor even for platform data where specifying all three separately was explicitly allowed. Have you verified that this doesn't cause any regressions?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131024/80df19dc/attachment.sig>

#5 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

Hi Thierry,

Le Thu, 24 Oct 2013 17:17:37 +0200,
Thierry Reding <[email protected]> a ?crit :

Quoted 5 lines

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 22

Quoted 4 lines
+- ti,max-rt: maximum pressure.
+- ti,fuzzy: specifies the absolute input fuzz value.
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +2 -0
+  If set, it will permit noise in the data up to +- the value given to the fuzz
+  parameter, that is used to filter noise from the event stream.
Quoted 9 lines

Any reason why these can't be specified per axis? From my experience with this chip it can make sense to use different values for the different axes. Well, perhaps X and Y axes can share one fuzz factor, but the Z axis is sometimes different.

You also modify the driver to ignore the X and Z axes fuzz factor even for platform data where specifying all three separately was explicitly allowed. Have you verified that this doesn't cause any regressions?

That was not intended, that's an error, we will fix that.

Thanks,
Eric

#6 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

In reply to Thierry Reding

Hi,

Quoted 54 lines · Thierry Reding
Quoted 38 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +8 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
+
+Optional properties:

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +10 -0
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).
+- interrupt-parent: the phandle for the gpio controller
+  (see interrupt binding[1]).
+- interrupts: (gpio) interrupt to which the chip is connected
+  (see interrupt binding[1]).
+- pinctrl-0: Should specify pin control groups used for the gpio
+  (see pinctrl bindings[0]).
+- pinctrl-names: Should contain only one value - "default"
+  (see pinctrl bindings[0]).

Also I haven't seen a response as to why this can't be handled by the GPIO driver. Adding Linus Walleij, perhaps he knows a more definitive answer.

Quoted 6 lines

Linus, the issue here is that the pinctrl properties for this chip are supposed to pinmux the pendown GPIO for this chip. I was under the impression that this should be handled by the GPIO controller itself, so that when gpio_request() was called on a pin it would be the GPIO controller driver's responsibility to pinmux it appropriately.

When a GPIO is requested the GPIO layer cannot know what it is requested for and how the pinmux for the pin function should be configured (pullups, drive strength, ...). A pin may have multiple functions depending on what modules are plugged into a baseboard.

Thus the pinctrl binding needs to be with the driver that uses the pin.

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
#7 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

Quoted 63 lines · Lothar Wa?mann

Hi,

Quoted 54 lines · Thierry Reding
Quoted 38 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +8 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
+
+Optional properties:

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +10 -0
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).
+- interrupt-parent: the phandle for the gpio controller
+  (see interrupt binding[1]).
+- interrupts: (gpio) interrupt to which the chip is connected
+  (see interrupt binding[1]).
+- pinctrl-0: Should specify pin control groups used for the gpio
+  (see pinctrl bindings[0]).
+- pinctrl-names: Should contain only one value - "default"
+  (see pinctrl bindings[0]).

Also I haven't seen a response as to why this can't be handled by the GPIO driver. Adding Linus Walleij, perhaps he knows a more definitive answer.

Quoted 6 lines

Linus, the issue here is that the pinctrl properties for this chip are supposed to pinmux the pendown GPIO for this chip. I was under the impression that this should be handled by the GPIO controller itself, so that when gpio_request() was called on a pin it would be the GPIO controller driver's responsibility to pinmux it appropriately.

Quoted 4 lines

When a GPIO is requested the GPIO layer cannot know what it is requested for and how the pinmux for the pin function should be configured (pullups, drive strength, ...). A pin may have multiple functions depending on what modules are plugged into a baseboard.

But GPIO is one specific function of a given pin, isn't it?

Quoted 1 line

Thus the pinctrl binding needs to be with the driver that uses the pin.

I wonder if this really needs to be dynamically configured depending on the driver. Properties like pullups and driver strength can potentially harm hardware when they're wrong, so relying on the driver's probe to configure them correctly doesn't sound very safe. It's always possible to disable the device (either via modifying the DTS or by having the bootloader patch it). That means the driver won't be probed at all, and therefore none of the pinctrl or pinmux settings will be applied.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131025/d64703ea/attachment-0001.sig>

#8 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

In reply to Thierry Reding
Quoted 18 lines · Thierry Reding

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 18

Quoted 11 lines · Denis Carikli
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +11 -0
+Optional properties:
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).
+- interrupt-parent: the phandle for the gpio controller
+  (see interrupt binding[1]).
+- interrupts: (gpio) interrupt to which the chip is connected
+  (see interrupt binding[1]).
+- pinctrl-0: Should specify pin control groups used for the gpio
+  (see pinctrl bindings[0]).
+- pinctrl-names: Should contain only one value - "default"
+  (see pinctrl bindings[0]).

Also I haven't seen a response as to why this can't be handled by the GPIO driver. Adding Linus Walleij, perhaps he knows a more definitive answer.

Quoted 5 lines

Linus, the issue here is that the pinctrl properties for this chip are supposed to pinmux the pendown GPIO for this chip. I was under the impression that this should be handled by the GPIO controller itself, so that when gpio_request() was called on a pin it would be the GPIO controller driver's responsibility to pinmux it appropriately.

If this is the only thing it does (just mux in the GPIO and not setting any pulls or other pin config properties) then it can fall through from the GPIO controller's request function to pinctrl_request_gpio() and then pinctrl_free_gpio(), pinctrl_gpio_direction_input() and pinctrl_gpio_direction_output() respectively so that pin control provides a muxing back end to the GPIO driver.

Actually these functions are up to the driver to implement, but the core will call ->gpio_request_enable() on the pinctrl driver, and if all GPIOs are set up the same way (i.e. the same bits are always poked into the hardware) then this can be done in that routine.

If more fine-grained control is needed, this approach providing a full pin control handle and state settings connected to the struct device * can and should be used instead.

Yours,
Linus Walleij

#9 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

In reply to Denis Carikli
Quoted 30 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa??mann <[email protected]>
Cc Eric B??nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +0 -0
new file mode 100644
index 0000000..516b63b

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 10

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +10 -0
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
+
+Optional properties:
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).

Hmmm, why is this needed? Is the line used for anything other than finding the irq number? If it is just an interrupt then an interrupts property is all that should be specified.

g.

#10 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

Hi,

Quoted 37 lines · Grant Likely
Quoted 36 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa??mann <[email protected]>
Cc Eric B??nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +6 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
Quoted 9 lines

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 10

Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +4 -0
+
+Optional properties:
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).

Hmmm, why is this needed? Is the line used for anything other than finding the irq number? If it is just an interrupt then an interrupts property is all that should be specified.

It's also the pendown detect GPIO. It asserts an interrupt when first activated and is then polled in the driver until it goes inactive again.

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
#11 lore raw

PATCH v7 1/4 Input: tsc2007: Add device tree support.

Quoted 49 lines · Lothar Wa??mann

Hi,

Quoted 37 lines · Grant Likely
Quoted 36 lines · Denis Carikli
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa????mann <[email protected]>
Cc Eric B????nard <[email protected]>

---
ChangeLog v6->v7:
- One small whitespace cleanup.
- The properties specific to that driver are now prefixed with "ti,".
- The ti,fuzzy property has now better documentation.

---
 .../bindings/input/touchscreen/tsc2007.txt         |   45 +++++
 drivers/input/touchscreen/tsc2007.c                |  194 +++++++++++++++-----
 2 files changed, 198 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +6 -0
new file mode 100644
index 0000000..516b63b
@@ -0,0 +1,45 @@
+* Texas Instruments tsc2007 touchscreen controller
+
+Required properties:
+- compatible: must be "ti,tsc2007".
+- reg: I2C address of the chip.
+- ti,x-plate-ohms: X-plate resistance in ohms.
Quoted 9 lines

Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt line 10

Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file +4 -0
+
+Optional properties:
+- gpios: the interrupt gpio the chip is connected to (trough the penirq pin)
+  (see GPIO binding[2] for more details).

Hmmm, why is this needed? Is the line used for anything other than finding the irq number? If it is just an interrupt then an interrupts property is all that should be specified.

Quoted 2 lines

It's also the pendown detect GPIO. It asserts an interrupt when first activated and is then polled in the driver until it goes inactive again.

That should definitely be in the document then. Otherwise the binding looks okay to me.

g.