Skip to contentSkip to conversation

dcache: fix outdated DCACHE_NEED_LOOKUP comment

PATCH In review J. Bruce Fields 2 participants 3 messages Oct 25, 2013 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dcache: fix outdated DCACHE_NEED_LOOKUP comment

From: "J. Bruce Fields" <[email protected]>

The DCACHE_NEED_LOOKUP case referred to here was removed with 39e3c9553f34381a1b664c27b0c696a266a5735e "vfs: remove DCACHE_NEED_LOOKUP".

There are only four real_lookup() callers and all of them pass in an unhashed dentry just returned from d_alloc.

---
 fs/namei.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/namei.c +2 -2
index e337f45..b83bf27 100644
@@ -1308,8 +1308,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
 }
 
 /*
- * Call i_op->lookup on the dentry.  The dentry must be negative but may be
- * hashed if it was pouplated with DCACHE_NEED_LOOKUP.
+ * Call i_op->lookup on the dentry.  The dentry must be negative and
+ * unhashed.
  *
  * dir->d_inode->i_mutex must be held
  */
Signature · 1 line
1.7.9.5
#1 lore raw

Also added to the "for-viro" branch at:

git://linux-nfs.org/~bfields/linux.git for-viro

Which now includes:

- the delegation patches
- 32/64-bit filehandle lookup fix
- 4 dcache patches fixing some uses of DCACHE_DISCONECTED.

All previously posted.

--b.

Quoted 32 lines · bfields

From: "J. Bruce Fields" <[email protected]>

The DCACHE_NEED_LOOKUP case referred to here was removed with 39e3c9553f34381a1b664c27b0c696a266a5735e "vfs: remove DCACHE_NEED_LOOKUP".

There are only four real_lookup() callers and all of them pass in an unhashed dentry just returned from d_alloc.

---
 fs/namei.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/namei.c +2 -2
index e337f45..b83bf27 100644
@@ -1308,8 +1308,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
 }
 
 /*
- * Call i_op->lookup on the dentry.  The dentry must be negative but may be
- * hashed if it was pouplated with DCACHE_NEED_LOOKUP.
+ * Call i_op->lookup on the dentry.  The dentry must be negative and
+ * unhashed.
  *
  * dir->d_inode->i_mutex must be held
  */
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 1 line · J. Bruce Fields

- 32/64-bit filehandle lookup fix

I'd really like to see at least that one in 3.12.