Skip to contentSkip to conversation

For x86/mce ... enhanced error logs

GIT PULL In review Luck, Tony 6 participants 15 messages Oct 22, 2013 – Oct 29, 2013

Subsystems (3)
lore
Share & tools
lore

Luck, Tony

author reviewer
#0 lore raw

Ingo,

Ultimate plan is to use these enhanced error logs to feed a perf/trace event ... but we are still discussing the exact format of that, and also how it should interact/complement/replace the existing EDAC trace event. Meanwhile all this precursor work has been reviewed and agreed on by Mauro, Boris & others ... so it can be queued for the next merge window while we continue work on the trace event.

-Tony

The following changes since commit 31d141e3a666269a3b6fcccddb0351caf7454240:

Linux 3.12-rc6 (2013-10-19 12:28:15 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-eMCA

for you to fetch changes up to 7dcb5248a2593539d40b1bcd8da0158e7c3967b5:

EDAC, GHES: Update ghes error record info (2013-10-21 15:12:02 -0700)

----------------------------------------------------------------
There is a enhanced error logging mechanism for Xeon processors. Full description is here:
http://www.intel.com/content/www/us/en/architecture-and-technology/enhanced-mca-logging-xeon-paper.html
This patch series provides a module (and support code) to check for an extended error log and print extra details about the error on the console.

----------------------------------------------------------------
Chen, Gong (9):
ACPI, APEI, CPER: Fix status check during error printing ACPI, CPER: Update cper info
bitops: Introduce a more generic BITMASK macro ACPI, x86: Extended error log driver for x86 platform
DMI: Parse memory device (type 17) in SMBIOS ACPI, APEI, CPER: Add UEFI 2.4 support for memory error ACPI, APEI, CPER: Enhance memory reporting capability ACPI, APEI, CPER: Cleanup CPER memory error output format EDAC, GHES: Update ghes error record info

 arch/ia64/kernel/setup.c              |   1 +
 arch/x86/include/asm/mce.h            |   1 +
 arch/x86/kernel/cpu/mcheck/mce-apei.c |   3 +-
 arch/x86/kernel/setup.c               |   1 +
 drivers/acpi/Kconfig                  |  19 ++
 drivers/acpi/Makefile                 |   2 +
 drivers/acpi/acpi_extlog.c            | 326 ++++++++++++++++++++++++++++++++++
 drivers/acpi/apei/apei-internal.h     |  12 +-
 drivers/acpi/apei/cper.c              | 132 +++++++-------
 drivers/acpi/apei/ghes.c              |  58 +++---
 drivers/acpi/bus.c                    |   3 +-
 drivers/edac/amd64_edac.c             |  46 ++---
 drivers/edac/amd64_edac.h             |   8 -
 drivers/edac/ghes_edac.c              |  16 +-
 drivers/edac/sb_edac.c                |   2 +-
 drivers/firmware/dmi_scan.c           |  60 +++++++
 drivers/video/sis/init.c              |   5 +-
 include/acpi/actbl1.h                 |  14 +-
 include/acpi/ghes.h                   |   2 +-
 include/linux/acpi.h                  |   1 +
 include/linux/bitops.h                |   8 +
 include/linux/cper.h                  |  13 +-
 include/linux/dmi.h                   |   5 +
 include/linux/edac.h                  |   2 +-
 24 files changed, 591 insertions(+), 149 deletions(-)
 create mode 100644 drivers/acpi/acpi_extlog.c
author reviewer
#1 lore raw

Replacement for yesterday's pull request - fixes a build bug when CONFIG_SMP=n found by Fengguang's zero-day auto-build robot army. If you pulled (and pushed) that one before finding this in your mailbox - then I can send the one-line patch to be applied on top of yesterday's version.

-Tony

The following changes since commit 31d141e3a666269a3b6fcccddb0351caf7454240:

Linux 3.12-rc6 (2013-10-19 12:28:15 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-eMCA-fix

for you to fetch changes up to 0f6d98727f0eea8cdeea4a3eacff266cad7dc764:

UEFI, CPER: Move cper.c to a more proper place (2013-10-23 10:11:08 -0700)

----------------------------------------------------------------
There is a enhanced error logging mechanism for Xeon processors. Full description is here:
http://www.intel.com/content/www/us/en/architecture-and-technology/enhanced-mca-logging-xeon-paper.html
This patch series provides a module (and support code) to check for an extended error log and print extra details about the error on the console.

----------------------------------------------------------------
Chen, Gong (10):
ACPI, APEI, CPER: Fix status check during error printing ACPI, CPER: Update cper info
bitops: Introduce a more generic BITMASK macro ACPI, x86: Extended error log driver for x86 platform
DMI: Parse memory device (type 17) in SMBIOS ACPI, APEI, CPER: Add UEFI 2.4 support for memory error ACPI, APEI, CPER: Enhance memory reporting capability ACPI, APEI, CPER: Cleanup CPER memory error output format EDAC, GHES: Update ghes error record info
UEFI, CPER: Move cper.c to a more proper place

 arch/ia64/kernel/setup.c              |   1 +
 arch/x86/include/asm/mce.h            |   1 +
 arch/x86/kernel/cpu/mcheck/mce-apei.c |   3 +-
 arch/x86/kernel/setup.c               |   1 +
 drivers/acpi/Kconfig                  |  20 +++
 drivers/acpi/Makefile                 |   2 +
 drivers/acpi/acpi_extlog.c            | 327 ++++++++++++++++++++++++++++++++++
 drivers/acpi/apei/Kconfig             |   1 +
 drivers/acpi/apei/Makefile            |   2 +-
 drivers/acpi/apei/apei-internal.h     |  12 +-
 drivers/acpi/apei/ghes.c              |  58 +++---
 drivers/acpi/bus.c                    |   3 +-
 drivers/edac/amd64_edac.c             |  46 ++---
 drivers/edac/amd64_edac.h             |   8 -
 drivers/edac/ghes_edac.c              |  16 +-
 drivers/edac/sb_edac.c                |   2 +-
 drivers/firmware/dmi_scan.c           |  60 +++++++
 drivers/video/sis/init.c              |   5 +-
 include/acpi/actbl1.h                 |  14 +-
 include/acpi/ghes.h                   |   2 +-
 include/linux/acpi.h                  |   1 +
 include/linux/bitops.h                |   8 +
 include/linux/cper.h                  |  13 +-
 include/linux/dmi.h                   |   5 +
 include/linux/edac.h                  |   2 +-
 lib/Kconfig                           |   4 +
 lib/Makefile                          |   1 +
 {drivers/acpi/apei => lib}/cper.c     | 132 +++++++-------
 28 files changed, 600 insertions(+), 150 deletions(-)
 create mode 100644 drivers/acpi/acpi_extlog.c
 rename {drivers/acpi/apei => lib}/cper.c (76%)
#2 lore raw
Quoted 4 lines · Tony

Replacement for yesterday's pull request - fixes a build bug when CONFIG_SMP=n found by Fengguang's zero-day auto-build robot army. If you pulled (and pushed) that one before finding this in your mailbox - then I can send the one-line patch to be applied on top of yesterday's version.

Well - I might as well put the brown paper bag over my head and go sit in the corner :-(

I accidentally applied an extra patch "UEFI, CPER: Move cper.c to a more proper place"
that Chen Gong had sent to me internally but has only been mentioned in concept on the mailing list.

So feel free to pop the 10th patch off and drop it.

-Tony

#3 lore raw
Quoted 6 lines · Tony Luck
Quoted 4 lines · Tony

Replacement for yesterday's pull request - fixes a build bug when CONFIG_SMP=n found by Fengguang's zero-day auto-build robot army. If you pulled (and pushed) that one before finding this in your mailbox - then I can send the one-line patch to be applied on top of yesterday's version.

Quoted 7 lines

Well - I might as well put the brown paper bag over my head and go sit in the corner :-(

I accidentally applied an extra patch "UEFI, CPER: Move cper.c to a more proper place"
that Chen Gong had sent to me internally but has only been mentioned in concept on the mailing list.

Hm, I'm not sure we should move something named after a hardware feature into lib/. It's not really generic C library functionality, is it?

Quoted 1 line

So feel free to pop the 10th patch off and drop it.

Yeah, I did that.

Thanks,

Ingo

#4 lore raw
Quoted 4 lines

Hm, I'm not sure we should move something named after a hardware feature into lib/. It's not really generic C library functionality,

Not a hardware feature. CPER stands for Common Platform Error Record from the UEFI standard. So applicable to three? architectures.

As Chen Gong points out, drivers/acpi isn't the right place ... so if not lib/ ... then where?

-Tony

#5 lore raw
Quoted 1 line · Tony Luck

As Chen Gong points out, drivers/acpi isn't the right place ... so if not lib/ ... then where?

A to be created drivers/efi? There should be a lot more shared EFI code coming sooner or later, shouldn't it?

#6 lore raw
In reply to Tony Luck
Quoted 6 lines · Tony Luck
Quoted 2 lines

Hm, I'm not sure we should move something named after a hardware feature into lib/. It's not really generic C library functionality,

Not a hardware feature. CPER stands for Common Platform Error Record from the UEFI standard. [...]

By all means UEFI can be considered platform dependent at the moment:

comet:~/tip> git grep -i uefi arch/arm/
comet:~/tip> git grep -i uefi arch/arm64/
comet:~/tip> git grep -i uefi arch/powerpc/
comet:~/tip> git grep -i uefi arch/mips/
comet:~/tip>

If a committee says that a name of some standard is 'common platform' does not make it so. lib/ is mostly kept for mathematical, C-library alike functionality you see in CS textbooks.

Quoted 2 lines

As Chen Gong points out, drivers/acpi isn't the right place ... so if not lib/ ... then where?

drivers/uefi/?

Thanks,

Ingo

#7 lore raw
Quoted 18 lines · Ingo Molnar
Quoted 6 lines · Tony Luck
Quoted 2 lines

Hm, I'm not sure we should move something named after a hardware feature into lib/. It's not really generic C library functionality,

Not a hardware feature. CPER stands for Common Platform Error Record from the UEFI standard. [...]

By all means UEFI can be considered platform dependent at the moment:

comet:~/tip> git grep -i uefi arch/arm/
comet:~/tip> git grep -i uefi arch/arm64/
comet:~/tip> git grep -i uefi arch/powerpc/
comet:~/tip> git grep -i uefi arch/mips/
comet:~/tip>

Quoted 8 lines

If a committee says that a name of some standard is 'common platform' does not make it so. lib/ is mostly kept for mathematical, C-library alike functionality you see in CS textbooks.

Quoted 2 lines

As Chen Gong points out, drivers/acpi isn't the right place ... so if not lib/ ... then where?

drivers/uefi/?

Hmm, we do have drivers/firmware/, even drivers/firmware/efi/ subdir and since this thing is part of the UEFI spec, we probably should stick it there...

Matt, heads up^^^.

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#8 lore raw
Quoted 23 lines · Borislav Petkov
Quoted 22 lines · Ingo Molnar
Quoted 6 lines · Tony Luck
Quoted 2 lines

Hm, I'm not sure we should move something named after a hardware feature into lib/. It's not really generic C library functionality,

Not a hardware feature. CPER stands for Common Platform Error Record from the UEFI standard. [...]

By all means UEFI can be considered platform dependent at the moment:

comet:~/tip> git grep -i uefi arch/arm/
comet:~/tip> git grep -i uefi arch/arm64/
comet:~/tip> git grep -i uefi arch/powerpc/
comet:~/tip> git grep -i uefi arch/mips/
comet:~/tip>

If a committee says that a name of some standard is 'common platform' does not make it so. lib/ is mostly kept for mathematical, C-library alike functionality you see in CS textbooks.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

As Chen Gong points out, drivers/acpi isn't the right place ... so if not lib/ ... then where?

drivers/uefi/?

Hmm, we do have drivers/firmware/, even drivers/firmware/efi/ subdir and since this thing is part of the UEFI spec, we probably should stick it there...

I've certainly no problem with moving it under drivers/firmware/efi/, but please don't create a new subdirectory in drivers/ just for this.

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center
#9 lore raw
Quoted 2 lines · Matt Fleming

I've certainly no problem with moving it under drivers/firmware/efi/, but please don't create a new subdirectory in drivers/ just for this.

Yeah, no - we have an subdir for this - drivers/firmware/efi/ so no need for the drivers/u?efi thing.

My train of thought here is, we want to put all firmware-related crap into drivers/firmware/ and since CPER is from the UEFI spec, it should go into drivers/firmware/efi.

I guess we can apply that same logic to the remaining UEFI sh*tstorm coming our way.

:-)

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#10 lore raw
Quoted 10 lines · Borislav Petkov
Quoted 2 lines · Matt Fleming

I've certainly no problem with moving it under drivers/firmware/efi/, but please don't create a new subdirectory in drivers/ just for this.

Yeah, no - we have an subdir for this - drivers/firmware/efi/ so no need for the drivers/u?efi thing.

My train of thought here is, we want to put all firmware-related crap into drivers/firmware/ and since CPER is from the UEFI spec, it should go into drivers/firmware/efi.

Makes total sense to me.

Quoted 2 lines

I guess we can apply that same logic to the remaining UEFI sh*tstorm coming our way.

;-)

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center
author reviewer
#11 lore raw

PATCH 1/1 Move cper.c from drivers/acpi/apei to drivers/firmware/efi

cper.c contains code to decode and print "Common Platform Error Records". Originally added under drivers/acpi/apei because the only user was in that same directory - but now we have another consumer, and we shouldn't have to force CONFIG_ACPI_APEI get access to this code.

Since CPER is defined in the UEFI specification - the logical home for this code is under drivers/firmware/efi/

---

Matt: as discussed earlier on the mailing list ... just looking for your "Acked-by" so this can go on top of the patch series in the x86/mce branch of the tip tree that already makes a bunch of changes to cper.c

Based on Chen Gong's original patch that moved cper.c to lib/

drivers/acpi/Kconfig +3 -1
index 252f0e818a49..08eadb4a57cb 100644
@@ -374,7 +374,9 @@ source "drivers/acpi/apei/Kconfig"
 
 config ACPI_EXTLOG
 	tristate "Extended Error Log support"
-	depends on X86_MCE && ACPI_APEI
+	depends on X86_MCE
+	select EFI
+	select UEFI_CPER
 	default n
 	help
 	  Certain usages such as Predictive Failure Analysis (PFA) require
drivers/acpi/apei/Kconfig +2 -0
index f0c1ce95a0ec..786294bb682c 100644
@@ -2,6 +2,8 @@ config ACPI_APEI
 	bool "ACPI Platform Error Interface (APEI)"
 	select MISC_FILESYSTEMS
 	select PSTORE
+	select EFI
+	select UEFI_CPER
 	depends on X86
 	help
 	  APEI allows to report errors (for example from the chipset)
drivers/acpi/apei/Makefile +1 -1
index d1d1bc0a4ee1..5d575a955940 100644
@@ -3,4 +3,4 @@ obj-$(CONFIG_ACPI_APEI_GHES)	+= ghes.o
 obj-$(CONFIG_ACPI_APEI_EINJ)	+= einj.o
 obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o
 
-apei-y := apei-base.o hest.o cper.o erst.o
+apei-y := apei-base.o hest.o erst.o
drivers/firmware/efi/Kconfig +3 -0
index b0fc7c79dfbb..8dfdd2a1cf12 100644
@@ -36,4 +36,7 @@ config EFI_VARS_PSTORE_DEFAULT_DISABLE
 	  backend for pstore by default. This setting can be overridden
 	  using the efivars module's pstore_disable parameter.
 
+config UEFI_CPER
+	defbool n
+
 endmenu
drivers/firmware/efi/Makefile +1 -0
index 99245ab5a79c..9ba156d3c775 100644
@@ -4,3 +4,4 @@
 obj-y					+= efi.o vars.o
 obj-$(CONFIG_EFI_VARS)			+= efivars.o
 obj-$(CONFIG_EFI_VARS_PSTORE)		+= efi-pstore.o
+obj-$(CONFIG_UEFI_CPER)			+= cper.o
drivers/firmware/efi/cper.c renamed from drivers/acpi/apei/cper.c +0 -0
similarity index 100%
rename from drivers/acpi/apei/cper.c
rename to drivers/firmware/efi/cper.c
Acked-by on v1 1/1
#12 lore raw

Re: [PATCH] Move cper.c from drivers/acpi/apei to drivers/firmware/efi

Quoted 8 lines · Tony

cper.c contains code to decode and print "Common Platform Error Records". Originally added under drivers/acpi/apei because the only user was in that same directory - but now we have another consumer, and we shouldn't have to force CONFIG_ACPI_APEI get access to this code.

Since CPER is defined in the UEFI specification - the logical home for this code is under drivers/firmware/efi/

Quoted 8 lines

---

Matt: as discussed earlier on the mailing list ... just looking for your "Acked-by" so this can go on top of the patch series in the x86/mce branch of the tip tree that already makes a bunch of changes to cper.c

You got it.

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center
Acked-by on v1 1/1
#13 lore raw

Re: [PATCH] Move cper.c from drivers/acpi/apei to drivers/firmware/efi

In reply to Luck, Tony
Quoted 9 lines · Luck, Tony

cper.c contains code to decode and print "Common Platform Error Records". Originally added under drivers/acpi/apei because the only user was in that same directory - but now we have another consumer, and we shouldn't have to force CONFIG_ACPI_APEI get access to this code.

Since CPER is defined in the UEFI specification - the logical home for this code is under drivers/firmware/efi/

Looks good to me!

Ingo

#14 lore raw
In reply to Luck, Tony
Quoted 63 lines · Luck, Tony

Replacement for yesterday's pull request - fixes a build bug when CONFIG_SMP=n found by Fengguang's zero-day auto-build robot army. If you pulled (and pushed) that one before finding this in your mailbox - then I can send the one-line patch to be applied on top of yesterday's version.

-Tony

The following changes since commit 31d141e3a666269a3b6fcccddb0351caf7454240:

Linux 3.12-rc6 (2013-10-19 12:28:15 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-eMCA-fix

for you to fetch changes up to 0f6d98727f0eea8cdeea4a3eacff266cad7dc764:

UEFI, CPER: Move cper.c to a more proper place (2013-10-23 10:11:08 -0700)

----------------------------------------------------------------
There is a enhanced error logging mechanism for Xeon processors. Full description is here:
http://www.intel.com/content/www/us/en/architecture-and-technology/enhanced-mca-logging-xeon-paper.html
This patch series provides a module (and support code) to check for an extended error log and print extra details about the error on the console.

----------------------------------------------------------------
Chen, Gong (10):
ACPI, APEI, CPER: Fix status check during error printing ACPI, CPER: Update cper info
bitops: Introduce a more generic BITMASK macro ACPI, x86: Extended error log driver for x86 platform
DMI: Parse memory device (type 17) in SMBIOS ACPI, APEI, CPER: Add UEFI 2.4 support for memory error ACPI, APEI, CPER: Enhance memory reporting capability ACPI, APEI, CPER: Cleanup CPER memory error output format EDAC, GHES: Update ghes error record info
UEFI, CPER: Move cper.c to a more proper place

 arch/ia64/kernel/setup.c              |   1 +
 arch/x86/include/asm/mce.h            |   1 +
 arch/x86/kernel/cpu/mcheck/mce-apei.c |   3 +-
 arch/x86/kernel/setup.c               |   1 +
 drivers/acpi/Kconfig                  |  20 +++
 drivers/acpi/Makefile                 |   2 +
 drivers/acpi/acpi_extlog.c            | 327 ++++++++++++++++++++++++++++++++++
 drivers/acpi/apei/Kconfig             |   1 +
 drivers/acpi/apei/Makefile            |   2 +-
 drivers/acpi/apei/apei-internal.h     |  12 +-
 drivers/acpi/apei/ghes.c              |  58 +++---
 drivers/acpi/bus.c                    |   3 +-
 drivers/edac/amd64_edac.c             |  46 ++---
 drivers/edac/amd64_edac.h             |   8 -
 drivers/edac/ghes_edac.c              |  16 +-
 drivers/edac/sb_edac.c                |   2 +-
 drivers/firmware/dmi_scan.c           |  60 +++++++
 drivers/video/sis/init.c              |   5 +-
 include/acpi/actbl1.h                 |  14 +-
 include/acpi/ghes.h                   |   2 +-
 include/linux/acpi.h                  |   1 +
 include/linux/bitops.h                |   8 +
 include/linux/cper.h                  |  13 +-
Quoted 8 lines
 include/linux/dmi.h                   |   5 +
 include/linux/edac.h                  |   2 +-
 lib/Kconfig                           |   4 +
 lib/Makefile                          |   1 +
 {drivers/acpi/apei => lib}/cper.c     | 132 +++++++-------
 28 files changed, 600 insertions(+), 150 deletions(-)
 create mode 100644 drivers/acpi/acpi_extlog.c
 rename {drivers/acpi/apei => lib}/cper.c (76%)

Pulled, thanks Tony!

Ingo