net: wireless: replace printk with pr_warn in adm8211.c

PATCH In review Georgiana Rodica Chelu 2 participants 2 messages Oct 26, 2013 – Oct 28, 2013 Networking drivers (wireless)

lore

Share & tools

lore

Georgiana Rodica Chelu

author

2013-10-26 19:20 UTC #0 lore raw

PATCH v3 1/3 net: wireless: replace printk with pr_warn in adm8211.c

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...

Signed-off-by Georgiana Rodica Chelu <[email protected]>

---
 drivers/net/wireless/adm8211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/wireless/adm8211.c +1 -1

index f9a24e5..e36d54d 100644
@@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else
 			priv->rf_type = ADM8211_TYPE_AIROHA;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
+		pr_warn("%s (adm8211): Unknown RFtype %d\n",
 		       pci_name(priv->pdev), (cr49 >> 3) & 0x7);
 	}

Signature · 1 line

1.8.1.2

Greg KH

2013-10-28 21:30 UTC #1 lore raw

Quoted 7 lines · Georgiana Rodica Chelu

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
Signed-off-by Georgiana Rodica Chelu <[email protected]>
---
 drivers/net/wireless/adm8211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Like Sarah said, we can't take these as they are not against the staging tree.

And even if they were:

drivers/net/wireless/adm8211.c static int adm8211_read_eeprom(struct ieee80211_hw *dev) · line 154

Quoted 10 lines

drivers/net/wireless/adm8211.c +1 -1

index f9a24e5..e36d54d 100644
@@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else
 			priv->rf_type = ADM8211_TYPE_AIROHA;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
+		pr_warn("%s (adm8211): Unknown RFtype %d\n",

You didn't read the message that sparse was telling you, why didn't you convert this to netdev_warn() instead?

thanks,

greg k-h