Skip to contentSkip to conversation

INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT

PATCH In review Rob Pearce 4 participants 6 messages Oct 27, 2013

Subsystems (2)
lore
Share & tools
lore

Rob Pearce

author
#0 lore raw

PATCH 1/1 INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

drivers/gpu/drm/i915/intel_lvds.c 2013-10-27 15:51:25.000000000 +0000 renamed from drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100 +16 -0
diff -uprN -X linux-3.11.4/Documentation/dontdiff linux-3.11.4/drivers/gpu/drm/i915/intel_lvds.c linux-3.11.4-ovs/drivers/gpu/drm/i915/intel_lvds.c
@@ -696,6 +696,22 @@
 	},
 	{
 		.callback = intel_no_lvds_dmi_callback,
+		.ident = "Intel D410PT",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+			DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
+		},
+	},
+	{
+		.callback = intel_no_lvds_dmi_callback,
+		.ident = "Intel D425KT",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D425KT"),
+		},
+	},
+	{
+		.callback = intel_no_lvds_dmi_callback,
 		.ident = "Intel D510MO",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
#1 lore raw
Quoted 10 lines · Rob Pearce

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

Any reason you don't want this in the stable tree as well?

thanks,

greg k-h

#2 lore raw
Quoted 7 lines · Greg KH
Quoted 6 lines · Rob Pearce

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

Quoted 6 lines
Quoted 4 lines

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

Any reason you don't want this in the stable tree as well?

None. Picked up for -fixes, thanks for the patch. Also I prefer the patch change log in the commit message proper and less screaming in the summary ;-) All fixed while applying.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
author
#3 lore raw
In reply to Greg KH
Quoted 7 lines · Greg KH
Quoted 6 lines · Rob Pearce

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

Quoted 7 lines
Quoted 4 lines

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

Any reason you don't want this in the stable tree as well?

No, should be in stable. Sorry, I'm obviously getting some etiquette wrong (this is the first patch I've submitted).

Cheers,
Rob

#4 lore raw
In reply to Greg KH
Quoted 7 lines · Greg KH
Quoted 6 lines · Rob Pearce

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

Quoted 7 lines
Quoted 4 lines

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

Any reason you don't want this in the stable tree as well?

Hi Greg,

pardon my ignorance, but I thought this was supposed to be the maintainer's call to make ? Did I get this wrong ?

Thanks,
Guenter

#5 lore raw
Quoted 13 lines · Guenter Roeck
Quoted 12 lines · Greg KH
Quoted 10 lines · Rob Pearce

From: Rob Pearce <[email protected]>

The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as having LVDS but the hardware is not populated. This patch adds them to the list of such systems. Patch is against 3.11.4

---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS. According to Intel's documentation, the D410PTL and D410PLTW don't.

Quoted 7 lines
Quoted 2 lines

Any reason you don't want this in the stable tree as well?

Hi Greg,

pardon my ignorance, but I thought this was supposed to be the maintainer's call to make ? Did I get this wrong ?

Maintainer occasionally fumble it, so it's better when the patch submitter also thinks about this. I can always change it when I disagree ;-) -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch