EFI changes

GIT PULL Matt Fleming 2 participants 4 messages Oct 27, 2013 – Oct 28, 2013

Subsystems (2)

x86 EFI

lore

Share & tools

lore

Matt Fleming

author

2013-10-27 21:48 UTC #0 lore raw

Guys, do you think we could get the EFI earlyprintk support into the 'x86/efi' branch for the upcoming merge window? I know it's quite late in the game but since it's a new feature it shouldn't introduce any kind of regression and is a much needed feature.

The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:

boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next

for you to fetch changes up to 32c9e70fc3912c3b9c7d53ce016960ce99ff93d4:

x86/efi: Add EFI framebuffer earlyprintk support (2013-10-27 21:18:48 +0000)

----------------------------------------------------------------
* Add support for earlyprintk=efi which uses the EFI framebuffer. Very useful for debugging boot issues.

----------------------------------------------------------------
Matt Fleming (2):
efi: Add asm-generic/efi.h for non-x86 x86/efi: Add EFI framebuffer earlyprintk support

 Documentation/kernel-parameters.txt  |   8 +-
 arch/ia64/include/asm/efi.h          |   6 ++
 arch/x86/Kconfig.debug               |   9 ++
 arch/x86/boot/compressed/eboot.c     |   1 -
 arch/x86/include/asm/efi.h           |  12 +++
 arch/x86/kernel/early_printk.c       |   6 ++
 arch/x86/kernel/setup.c              |   1 -
 arch/x86/platform/efi/Makefile       |   1 +
 arch/x86/platform/efi/early_printk.c | 191 +++++++++++++++++++++++++++++++++++
 arch/x86/platform/efi/efi.c          |   1 -
 arch/x86/platform/efi/efi_32.c       |   1 -
 arch/x86/platform/efi/efi_64.c       |   1 -
 arch/x86/platform/uv/bios_uv.c       |   1 -
 include/asm-generic/efi.h            |  17 ++++
 include/linux/efi.h                  |  31 +-----
 15 files changed, 249 insertions(+), 38 deletions(-)
 create mode 100644 arch/ia64/include/asm/efi.h
 create mode 100644 arch/x86/platform/efi/early_printk.c
 create mode 100644 include/asm-generic/efi.h

Signature · 1 line

Matt Fleming, Intel Open Source Technology Center

Ingo Molnar

2013-10-28 11:17 UTC #1 lore raw

Quoted 9 lines · Matt Fleming

Guys, do you think we could get the EFI earlyprintk support into the 'x86/efi' branch for the upcoming merge window? I know it's quite late in the game but since it's a new feature it shouldn't introduce any kind of regression and is a much needed feature.
The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:
boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)

Quoted 7 lines

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next
for you to fetch changes up to 32c9e70fc3912c3b9c7d53ce016960ce99ff93d4:
x86/efi: Add EFI framebuffer earlyprintk support (2013-10-27 21:18:48 +0000)

This breaks on x86-64 allmodconfig with:

arch/x86/built-in.o: In function `early_efi_setup':
early_printk.c:(.init.text+0x27e9f): undefined reference to `get_default_font'

Thanks,

Ingo

Matt Fleming

author

2013-10-28 11:49 UTC #2 lore raw

Quoted 16 lines · Ingo Molnar

Quoted 13 lines · Matt Fleming
Guys, do you think we could get the EFI earlyprintk support into the 'x86/efi' branch for the upcoming merge window? I know it's quite late in the game but since it's a new feature it shouldn't introduce any kind of regression and is a much needed feature.
The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:
boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next

Quoted 8 lines

Quoted 3 lines
for you to fetch changes up to 32c9e70fc3912c3b9c7d53ce016960ce99ff93d4:
x86/efi: Add EFI framebuffer earlyprintk support (2013-10-27 21:18:48 +0000)
This breaks on x86-64 allmodconfig with:
arch/x86/built-in.o: In function `early_efi_setup':
early_printk.c:(.init.text+0x27e9f): undefined reference to `get_default_font'

Ooops! The following patch fixes it. Would you like me to squash this with the top commit on 'efi-next', retag and resend the pull request?

---

arch/x86/Kconfig.debug +2 -1

index b6fe388..0f3621e 100644
@@ -61,7 +61,8 @@ config EARLY_PRINTK_DBGP
 
 config EARLY_PRINTK_EFI
 	bool "Early printk via the EFI framebuffer"
-	depends on EFI && EARLY_PRINTK && FONT_SUPPORT
+	depends on EFI && EARLY_PRINTK
+	select FONT_SUPPORT
 	---help---
 	  Write kernel log output directly into the EFI framebuffer.

Signature · 1 line

Matt Fleming, Intel Open Source Technology Center

Ingo Molnar

2013-10-28 11:50 UTC #3 lore raw

Quoted 21 lines · Matt Fleming

Quoted 20 lines · Ingo Molnar
Quoted 16 lines · Matt Fleming
Guys, do you think we could get the EFI earlyprintk support into the 'x86/efi' branch for the upcoming merge window? I know it's quite late in the game but since it's a new feature it shouldn't introduce any kind of regression and is a much needed feature.
The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:
boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next
for you to fetch changes up to 32c9e70fc3912c3b9c7d53ce016960ce99ff93d4:
x86/efi: Add EFI framebuffer earlyprintk support (2013-10-27 21:18:48 +0000)

Quoted 7 lines

Quoted 4 lines
This breaks on x86-64 allmodconfig with:
arch/x86/built-in.o: In function `early_efi_setup':
early_printk.c:(.init.text+0x27e9f): undefined reference to `get_default_font'
Ooops! The following patch fixes it. Would you like me to squash this with the top commit on 'efi-next', retag and resend the pull request?

Yeah, that would be nice, I'd rather re-pull the tree, haven't put much testing into it yet.

Thanks,

Ingo