Skip to contentSkip to conversation

Question about patman

U-Boot Masahiro Yamada 4 participants 6 messages Oct 28, 2013 – Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

Hello Simon.

I'm trying patman, but it looks like
it doesn't work on my Ubuntu box.

How can I resove the following issue?

The subject of HEAD is
ARM: align MVBAR on 32 byte boundary

and the result of my dry run is:

$ python --version
Python 2.7.4
$ tools/patman/patman -n -c1 
Cleaned 1 patches
Traceback (most recent call last):
  File "tools/patman/patman", line 153, in <module>
    not options.ignore_bad_tags)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/series.py", line 225, in MakeCcFile
    raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 308, in BuildEmailList
    raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 472, in LookupEmail
    raise ValueError, msg
ValueError: Alias 'arm' not found

Best Regards
Masahiro Yamada

#1 lore raw

Hi Masahiro,

Quoted 15 lines · Masahiro Yamada

Hello Simon.

I'm trying patman, but it looks like
it doesn't work on my Ubuntu box.

How can I resove the following issue?

The subject of HEAD is
ARM: align MVBAR on 32 byte boundary

and the result of my dry run is:

Quoted 15 lines
$ python --version
Python 2.7.4
$ tools/patman/patman -n -c1
Cleaned 1 patches
Traceback (most recent call last):
  File "tools/patman/patman", line 153, in <module>
    not options.ignore_bad_tags)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/series.py", line 225, in MakeCcFile
    raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 308, in BuildEmailList
    raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 472, in LookupEmail
    raise ValueError, msg
ValueError: Alias 'arm' not found

You should put an alias for arm in your ~/.patman file, like this:

albert: Albert Aribaud <[email protected]>
arm: albert

There is also a -t option to skip bad aliases.

Regards,
Simon

#2 lore raw

Hello Simon.

Quoted 6 lines

You should put an alias for arm in your ~/.patman file, like this:

albert: Albert Aribaud <[email protected]>
arm: albert

There is also a -t option to skip bad aliases.

Thanks! It worked.
I love this tool. :-)

I have one more question.
Does patman have a tag to handle the message area below the delimiter, '---' ?

I often use the area for writing additional explanations, which might be too verbose to be included into git log,
but might be helpful for the code review.

I generally write in the area below '---' with a text editor before posting the patch file.

If patman could do this for me,
it would be appreciated.

Best Regards
Masahiro Yamada

#3 lore raw

Hi Masahiro,

Quoted 20 lines · Masahiro Yamada

Hello Simon.

Quoted 6 lines

You should put an alias for arm in your ~/.patman file, like this:

albert: Albert Aribaud <[email protected]>
arm: albert

There is also a -t option to skip bad aliases.

Thanks! It worked.
I love this tool. :-)

I have one more question.
Does patman have a tag to handle the message area below the delimiter, '---' ?

I often use the area for writing additional explanations, which might be too verbose to be included into git log,
but might be helpful for the code review.

Quoted 5 lines

I generally write in the area below '---' with a text editor before posting the patch file.

If patman could do this for me,
it would be appreciated.

I have posted a patch to allow adding notes below the '---' line, if this is what you mean. So far, there was no comment on it. See:

http://patchwork.ozlabs.org/patch/283057/

Quoted 2 lines

Best Regards
Masahiro Yamada

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

Hello Albert.

Quoted 4 lines

I have posted a patch to allow adding notes below the '---' line, if this is what you mean. So far, there was no comment on it. See:

http://patchwork.ozlabs.org/patch/283057/

Yeah!
This is the function exactly I have wanted.

Thank you.

Beat Regards
Masahiro Yamada

#5 lore raw
Quoted 9 lines · Masahiro Yamada

Hello Albert.

Quoted 4 lines

I have posted a patch to allow adding notes below the '---' line, if this is what you mean. So far, there was no comment on it. See:

http://patchwork.ozlabs.org/patch/283057/

Yeah!
This is the function exactly I have wanted.

Neat :-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750