Skip to contentSkip to conversation

tty: Add NULL check to return value of kzalloc()

PATCH In review RUC_SoftSec 2 participants 2 messages Oct 28, 2013 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty: Add NULL check to return value of kzalloc()

Function kzalloc() may return a NULL pointer, it should be checked against NULL before used. This bug is found by a static analysis tool developed by RUC_SoftSec, supported by China.X.Orion.

---
 drivers/tty/vt/vt.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/tty/vt/vt.c +8 -6
index 9a8e8c5..fcba3ce 100644
@@ -2887,12 +2887,14 @@ static int __init con_init(void)
 
 	for (currcons = 0; currcons < MIN_NR_CONSOLES; currcons++) {
 		vc_cons[currcons].d = vc = kzalloc(sizeof(struct vc_data), GFP_NOWAIT);
-		INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
-		tty_port_init(&vc->port);
-		visual_init(vc, currcons, 1);
-		vc->vc_screenbuf = kzalloc(vc->vc_screenbuf_size, GFP_NOWAIT);
-		vc_init(vc, vc->vc_rows, vc->vc_cols,
-			currcons || !vc->vc_sw->con_save_screen);
+		if (vc) {
+			INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
+			tty_port_init(&vc->port);
+			visual_init(vc, currcons, 1);
+			vc->vc_screenbuf = kzalloc(vc->vc_screenbuf_size, GFP_NOWAIT);
+			vc_init(vc, vc->vc_rows, vc->vc_cols,
+					currcons || !vc->vc_sw->con_save_screen);
+		}
 	}
 	currcons = fg_console = 0;
 	master_display_fg = vc = vc_cons[currcons].d;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 4 lines · RUC_SoftSec

Function kzalloc() may return a NULL pointer, it should be checked against NULL before used. This bug is found by a static analysis tool developed by RUC_SoftSec, supported by China.X.Orion.

I've already explained why I can not accept patches like this, consider all of them that you sent now deleted from my inbox.

greg k-h