Skip to contentSkip to conversation

Should be Acked-by and Reviewed-by inherited for updated patches?

U-Boot Masahiro Yamada 2 participants 2 messages Oct 28, 2013 – Oct 30, 2013

lore
Share & tools
lore

Masahiro Yamada

author Acked-by Simon Glass
#0 lore raw

Hello exports.

When re-posting updated a patch (or patch series), should be Acked-by and Reviewed-by tag inherited?

Let me give an example.

I posted
"First step towards Kbuild: Use Kbuild style makefiles" v3.

Simon reviewed it and issued Acked-by tag.

Quoted 3 lines

The series:

But, unfortunately the series cannot be applied on the current u-boot/master any more.
I will need to rebase the series on the u-boot/master and re-post them as v4.

In this case, should I include

in the log of v4 series?

I think Acked-by tag for v3 cannot garantee the validity of v4.
So, strictly speaking, I think I should drop Acked-by tag if any change exists between v3 and v4.

Or should I use a common sense?

Best Regards
Masahiro Yamada

#1 lore raw

Hi,

2013/10/28 Masahiro Yamada <[email protected]>:

Quoted 28 lines

Hello exports.

When re-posting updated a patch (or patch series), should be Acked-by and Reviewed-by tag inherited?

Let me give an example.

I posted
"First step towards Kbuild: Use Kbuild style makefiles" v3.

Simon reviewed it and issued Acked-by tag.

Quoted 3 lines

The series:

But, unfortunately the series cannot be applied on the current u-boot/master any more.
I will need to rebase the series on the u-boot/master and re-post them as v4.

Quoted 4 lines

In this case, should I include

in the log of v4 series?

Yes, If you need to rebase the patch, and re-send, you can add
Acked-by: to your patches.

Quoted 6 lines

I think Acked-by tag for v3 cannot garantee the validity of v4.
So, strictly speaking, I think I should drop Acked-by tag if any change exists between v3 and v4.

Quoted 7 lines

Or should I use a common sense?

Best Regards
Masahiro Yamada

Best regards,
Nobuhiro

Signature · 3 lines
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6