Skip to contentSkip to conversation

powerpc: boot: Don't change link address for OF-based platforms

PATCH New Paul Mackerras 1 participant 1 message Oct 29, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: boot: Don't change link address for OF-based platforms

Commit c55aef0e5bc6 ("powerpc/boot: Change the load address for the wrapper to fit the kernel") adjusts the wrapper address unnecessarily for platforms that use arch/powerpc/boot/of.c, since the code there allocates space for the kernel wherever it can find it and doesn't necessarily load the kernel at address 0. Changing the link address is actually harmful since it can cause the zImage to overlap with Open Firmware and thus fail to boot.

To fix this, we set make_space to n for all of the platforms that use of.o.

---
 arch/powerpc/boot/wrapper | 4 ++++
 1 file changed, 4 insertions(+)
arch/powerpc/boot/wrapper +4 -0
index cd7af84..ac16e99 100755
@@ -150,18 +150,22 @@ case "$platform" in
 pseries)
     platformo="$object/of.o $object/epapr.o"
     link_address='0x4000000'
+    make_space=n
     ;;
 maple)
     platformo="$object/of.o $object/epapr.o"
     link_address='0x400000'
+    make_space=n
     ;;
 pmac|chrp)
     platformo="$object/of.o $object/epapr.o"
+    make_space=n
     ;;
 coff)
     platformo="$object/crt0.o $object/of.o $object/epapr.o"
     lds=$object/zImage.coff.lds
     link_address='0x500000'
+    make_space=n
     pie=
     ;;
 miboot|uboot*)
Signature · 1 line
1.8.4.rc3