Skip to contentSkip to conversation

sctp_status: server side should also receive msg_cnt times

PATCH In review Hangbin Liu 2 participants 4 messages Oct 27, 2013 – Oct 30, 2013 SCTP protocol

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp_status: server side should also receive msg_cnt times

As client side send msg_cnt times for each repeat. Server will exit too early if we only receive one time for each repeat and leave client keep sent, which makes client could not exit normally

---
 src/apps/sctp_status.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
src/apps/sctp_status.c +6 -1
index 4e21af8..76f96e4 100644
@@ -547,6 +547,8 @@ int receive_r(int sk)
 } /* receive_r () */
 
 void server(int sk) {
+	int i;
+
 	if (max_msgsize > DEFAULT_MAX_WINDOW) {
 		if (setsockopt(sk, IPPROTO_SCTP, SO_RCVBUF, &max_msgsize,
 			       sizeof(max_msgsize)) < 0) {
@@ -555,7 +557,10 @@ void server(int sk) {
 		}
 	}
 
-	receive_r(sk);
+	for (i = 0; i < msg_cnt; i++) {
+		receive_r(sk);
+		DEBUG_PRINT(DEBUG_MIN, "count %d\n", i+1);
+	}
 } /* server() */
 
 void * build_msg(int len) {
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 37 lines · Hangbin Liu

As client side send msg_cnt times for each repeat. Server will exit too early if we only receive one time for each repeat and leave client keep sent, which makes client could not exit normally

---
 src/apps/sctp_status.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
src/apps/sctp_status.c +6 -1
index 4e21af8..76f96e4 100644
@@ -547,6 +547,8 @@ int receive_r(int sk)
 } /* receive_r () */
 
 void server(int sk) {
+	int i;
+
 	if (max_msgsize > DEFAULT_MAX_WINDOW) {
 		if (setsockopt(sk, IPPROTO_SCTP, SO_RCVBUF, &max_msgsize,
 			       sizeof(max_msgsize)) < 0) {
@@ -555,7 +557,10 @@ void server(int sk) {
 		}
 	}
 
-	receive_r(sk);
+	for (i = 0; i < msg_cnt; i++) {
+		receive_r(sk);
+		DEBUG_PRINT(DEBUG_MIN, "count %d\n", i+1);
+	}
 } /* server() */
 
 void * build_msg(int len) {
Signature · 1 line
1.8.1.4

How about this patch?

Signature · 2 lines
Thanks & Best Regards
Hangbin Liu <[email protected]>