vfp: clear vfp_current_hw_state for dying cpu
Subsystems (2)
PATCH v2 1/1 vfp: clear vfp_current_hw_state for dying cpu
Previous version of the patch can be found at:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/201893.html
The CPU_DYING notifier is called by cpu stopper task which does not own the context held in the VFP hardware. Calling vfp_force_reload() has no effect.
Replace it with clearing vfp_current_hw_state.
--- arch/arm/vfp/vfpmodule.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/vfp/vfpmodule.c +3 -3
@@ -642,9 +642,9 @@ int vfp_restore_user_hwstate(struct user_vfp __user *ufp,static int vfp_hotplug (struct notifier_block *b,unsigned long action,void *hcpu) { -if (action ==CPU_DYING || action ==CPU_DYING_FROZEN ) { -vfp_force_reload ((long )hcpu,current_thread_info ()); - }else if (action ==CPU_STARTING || action ==CPU_STARTING_FROZEN ) +if (action ==CPU_DYING || action ==CPU_DYING_FROZEN ) + vfp_current_hw_state[(long )hcpu] =NULL ; +else if (action ==CPU_STARTING || action ==CPU_STARTING_FROZEN )vfp_enable (NULL );return NOTIFY_OK ; }
Signature · 1 line
1.7.9.5
PATCH v2 1/1 vfp: clear vfp_current_hw_state for dying cpu
Quoted 10 lines · Yuanyuan Zhong
Previous version of the patch can be found at:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/201893.htmlThe
CPU_DYINGnotifier is called by cpu stopper task which does not own the context held in the VFP hardware. Callingvfp_force_reload()has no effect.
Replace it with clearingvfp_current_hw_state.Change-Id Icb2c726334c5b0463b8126170cac2b44cd4ac38fSigned-off-by Yuanyuan Zhong <[email protected]>
This is fine, please put the patch into the patch system and I'll send it to Linus soon. Please omit the Change-Id though. Thanks.
Quoted 29 lines
--- arch/arm/vfp/vfpmodule.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/vfp/vfpmodule.c +3
-3@@ -642,9 +642,9 @@ int vfp_restore_user_hwstate(struct user_vfp __user *ufp,static int vfp_hotplug (struct notifier_block *b,unsigned long action,void *hcpu) { -if (action ==CPU_DYING || action ==CPU_DYING_FROZEN ) { -vfp_force_reload ((long )hcpu,current_thread_info ()); - }else if (action ==CPU_STARTING || action ==CPU_STARTING_FROZEN ) +if (action ==CPU_DYING || action ==CPU_DYING_FROZEN ) + vfp_current_hw_state[(long )hcpu] =NULL ; +else if (action ==CPU_STARTING || action ==CPU_STARTING_FROZEN )vfp_enable (NULL );return NOTIFY_OK ; }Signature · 7 lines
1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel