ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
PATCH 1/1 ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
Functions that need in it, already calculate reclen from namelen by themselves:
- ext4_find_dest_de()
- ext4_insert_dentry()
--- fs/ext4/inline.c | 2 -- 1 file changed, 2 deletions(-)
fs/ext4/inline.c +0 -2
@@ -994,11 +994,9 @@ static int ext4_add_dirent_to_inline(handle_t *handle,struct inode *dir = dentry->d_parent->d_inode;const char *name = dentry->d_name.name;int namelen = dentry->d_name.len; -unsigned short reclen;int err;struct ext4_dir_entry_2 *de; - reclen =EXT4_DIR_REC_LEN (namelen); err =ext4_find_dest_de (dir, inode, iloc->bh, inline_start, inline_size, name, namelen, &de);
Signature · 1 line
1.8.4.rc3
Quoted 6 lines · Azat Khuzhin
Functions that need in it, already calculate reclen from namelen by themselves:
-ext4_find_dest_de()
-ext4_insert_dentry()Signed-off-by Azat Khuzhin <[email protected]>
Applied, thanks.
- Ted
Quoted 9 lines · Theodore Ts'o
Quoted 6 lines · Azat Khuzhin
Functions that need in it, already calculate reclen from namelen by themselves:
-ext4_find_dest_de()
-ext4_insert_dentry()Signed-off-by Azat Khuzhin <[email protected]>Applied, thanks.
Thank you!
But there is a typo in subject, s/unsed/unused/ could you fix or it, or tell me, and I will resend it?
Thanks!
Quoted 2 lines
- Ted
Signature · 2 lines
Respectfully Azat Khuzhin
Theodore Ts'o
maintainerQuoted 4 lines · Azat Khuzhin
Thank you!
But there is a typo in subject, s/unsed/unused/ could you fix or it, or tell me, and I will resend it?
I had already reworeded the commit description as follows:
ext4: drop set but otherwise unused variable from ext4_add_dirent_to_inline()
Cheers,
- Ted